-
Notifications
You must be signed in to change notification settings - Fork 954
Weekly meeting
The Valkey community hosts a weekly meeting to discuss any topic that requires an online discussion. The meeting is every Monday at 8:00 Pacific time. (16:00 or 15:00 UTC). You can find the link and the exact details of the upcoming meetings here: https://zoom-lfx.platform.linuxfoundation.org/meetings/valkey?view=week.
Anyone is welcome to come and participate in the meeting. If you have a topic you would like to discuss, please add it under the Next Agenda section in the following format. The discussion must include a link to the relevant pull request or issue to be discussed, we will not review topics that have not been previously discussed in the community.
Notes will take the form of:
- Top level topic
- Discussion point 1
- Discussion point 2
- Top level topic ...
Meeting notes are sometimes posted as bullets under each discussion point, but they're often posted only as comments on the linked issues and pull requests.
If you are an active contributor and on the invite, you can add items here to be discussed in the next invite.
- Implement bigkey real time scan feature - https://github.com/valkey-io/valkey/pull/2819
- Built-in function in Valkey core OR
- Implement it as a seperated module? Extend: same design as calculation memory per key? https://github.com/valkey-io/valkey/issues/2850
- Adds HGETDEL Support to Valkey https://github.com/valkey-io/valkey/pull/2851
- Save cluster file in bio to avoid the stuck io latency https://github.com/valkey-io/valkey/pull/2555 -- any concern for this?
- To demo the initial GLIDE documentation site, discuss its structure, and gather feedback before the public preview.
- Database level access control https://github.com/valkey-io/valkey/pull/2309
- Topics?
- Discuss the various open-replication improvements - https://github.com/valkey-io/valkey/issues/2767, https://github.com/valkey-io/valkey/pull/2470 (Was an intern, maybe we takeover the PR), TBD Forkless improvement.
- https://github.com/valkey-io/valkey/issues/2767#issuecomment-3481411381 - Got consensus about the benefit of the feature, still need to implement it.
- Related to https://github.com/valkey-io/valkey/pull/2470 - probably need information about base.rdb load improvements, BGREWRITEAOF, server start/stop with AOF.
- Related? [Feat] add replid for base aof file with preamble #2366
- We need to start reviewing the multi-threaded BGSave PR, we are starting to review it. We will tell @Nicky-2000 that we will commit to reviewing it.
- Valkey UI official support - https://github.com/valkey-io/valkey-rfc/pull/31
- Looks OK. We will cleanup and merge the RFC and then once the code is in "mini-GA" state we will merge it.
- Valkey 9.0.1
- Release in next weeks.
- Adding support for shared memory - https://github.com/valkey-io/valkey/pull/2472
- (Major decision) Review the API - Approved
- Concerns about code intrusiveness - Have @JimB123 given a second review of the code.
- Make commandlog-request-larger-than and commandlog-reply-larger-than become memory config https://github.com/valkey-io/valkey/pull/2648
- (Major decision) Allow Memory configs to support negative values, this was previously not used. - Approved
- Add ValkeyModule_ACLCheckCommandPermissionsForCurrentUser API https://github.com/valkey-io/valkey/pull/2690
- (Major decision) Add new APIs - Decision was to switch to a draft, as this was not needed.
- Review database level ACLs - https://github.com/valkey-io/valkey/pull/2309
- (Major decision) Decide on the new syntax
db=1,2,3vsdb+=123etc- No concrete decision about the syntax, we provide some guidance for continuing investigation. @hpatro will follow up.
- (Major decision) Decide on the new syntax
- Initial discussion about various full sync replication improvement.
- Initial discussion, will progress further next week.
- Adding merge queue to unstable branch
- This would be helpful to catch test failures that happen in daily tests
- https://github.com/valkey-io/valkey/issues/2086
- We'll try it, if it works well we can keep it. Otherwise we'll revert it.
- House Keeping items
- Any concern with delaying 9.0 until 10/16 or 10/21? The LF would like to do some marketing.
- Decision is 10/21.
- Bug fix for 9.0 that includes breaking changes to the module API: https://github.com/valkey-io/valkey/pull/1826
- Bug fix for 9.0, https://github.com/valkey-io/valkey/pull/685/files
- Let's try to get it merged for 9.0
- Valkey 9.1 decision making process.
- Review Ran's high level proposal: https://github.com/valkey-io/valkey/issues/2564
- Forkless replication - https://github.com/valkey-io/valkey/issues/1754#issuecomment-3392487797
- Review high level design and highlight and potential concerns
- Enable dual channel replication - https://github.com/valkey-io/valkey/issues/2083
- We punting this to 10.0
- For 9.0:
- Distro modules packaging problem: https://github.com/valkey-io/valkey/issues/2678, fix https://github.com/valkey-io/valkey/pull/2689. Bugfix or breaking change?
- Meeting notes posted in the the PR: https://github.com/valkey-io/valkey/pull/2689#issuecomment-3372053164
- Atomic slot migration stuff
- Details around replica key containment and syncslots capa settled.
- Add parsing of future HFE listpack encoding?
- Meeting notes posted in the issue: https://github.com/valkey-io/valkey/issues/2618#issuecomment-3372110792
- Distro modules packaging problem: https://github.com/valkey-io/valkey/issues/2678, fix https://github.com/valkey-io/valkey/pull/2689. Bugfix or breaking change?
- Decision to use the +2 model for all major decision
- Vote
- Approved by majority of TSC (including votes given outside of the meeting)
- Need to update the governance doc (who?)
- Vote
- Add slot migration client flags and module context flags #2639 (Needed for 9.0.0-rc3)
- Fix incorrect lag and entries-read value with tombstone #685
- Notice: New repo valkey-operator created. There is an RFC.
- Check the PRs with 'major-decision-pending'. (Should we use a label like 'major-decision-postponed' on PRs we already discussed and don't want to discuss again right now?)
- Change to a softer major decision model, to avoid decisions being blocked by TSC members passively not giving their votes/approvals.
- No quorum during meeting, but async decision after the meeting to use +2
meeting extracts:
- Jacob will drive RC3. We target early as possible (by 2nd oct)
- Start back porting fixes to older versions. @ranshid - will focus on 8.1
- Follow up on - Fixed blocking behavior (https://github.com/valkey-io/valkey/pull/2329)
- Discussion about SCANDEL = SCAN + delete https://github.com/valkey-io/valkey/issues/2623
- Discussion about the 9.0 release.
- Decision to release RC2 ASAP
- We will make an RC3 with the required ASM follow-ups such as hiding ongoing ASM on replicas.
- Discussion about helm charts! https://github.com/valkey-io/valkey/issues/2371
- RC2 release review
- Review the helm chart issue with bitnami. https://github.com/valkey-io/valkey/issues/2371
- blocking clients should return -MOVED and -REDIRECT correctly #2329
- Add cluster-announce-client-(port|tls-port) configs #2429
- Approved
- Relaxed RDB check for foreign RDB formats (such as the ones from Redis 7.4 and Redis 8) #2543
- Approved
- Separate RDB snapshotting from atomic slot migration #2533
- A few new INFO fields to approve
- Consensus to add these fields, but there are concerns about the chosen INFO sections and exact names for these fields. Suggestions to be posted as comments in the PR.
- A few new INFO fields to approve
- Reset cluster related stats in CONFIG RESETSTATS #2458
- Approved
- New module API event for tracking authentication attempts #2237
- new module API event
ValkeyModuleEvent_AuthenticationAttempt- Approved
- new module API event
- Un-deprecated many deprecated commands. Issue #2459, PR #2546.
- Approved
- Optimize pipelining by parsing and prefetching multiple commands #2092
- Performance regression for pipelining observed in 8.0 (0.63MRPS), 8.1 (0.65MRPS) and unstable (0.75MRSP) compared to 7.2 (0.949MRPS). Benchmarked by @JoBeR007 here.
- Benchmark result possibly not accurate, due to how CPU cores were pinned.
- This PR roughly doubles the RPS for pipelined commands, with and without I/O threads.
- Compensation for not accepting cross-slot MGET.
- Blocker for this PR is just a code review. To be reviewed and merged ASAP.
- Performance regression for pipelining observed in 8.0 (0.63MRPS), 8.1 (0.65MRPS) and unstable (0.75MRSP) compared to 7.2 (0.949MRPS). Benchmarked by @JoBeR007 here.
- Stability issues (crashes) in 8.1 still not solved:
- [CRASH] Crash during downgrade from Valkey 8.1.0 to Valkey 8.0.3 #2341
- [CRASH] Crash during upgrade from Valkey 8.1.0-ga to Valkey 8.1.0-ga #2093
- [CRASH] Unexpected crash after the FULL SYNC #2114
-
[BUG] Unsuccessful (extremely high number) of attempts to perform Partial resynchronization causing CPU/Memory spikes #2119Fixed in #2490- Crashes observed only once or a few times and can't be reproduced are very hard to debug and fix.
- If it's a replica crashing, it's less severed than if it's a primary crashing.
- Backporting of fixes to 8.0 postponed indefinitely due to flaky tests?
- 8.0.4 was released with only some CVE fix, but without 15 PRs backported in #2210.
- From now on, we will backport not only bug fixes but also fixes to flaky tests and and similar testing related fixes to be sure that the tests are passing for the patch releases.
- Viktor will finish the 8.0.5 release within the following days.
- Test failures on the 8.0 branch resolved by backporting additional commits to the 8.0 branch.
- 8.0.4 was released with only some CVE fix, but without 15 PRs backported in #2210.
- Unit testing framework #2492
- Discussion about whether mocking is good or bad. No conclusion.
- Command to SCAN + Delete keys #2501
- Discussion. No conclusion.
- Allow Read requests on IO/Threading #2022
- Presentation of the high level design ideas by Dan.
- In general positive response.
- Discussion and clarification about how the amount of write commands affects the speed of read commands.
- Some concern about added complexity. Doesn't appear to be a blocker.
- Request for ideas about how to expand this to standalone (non-cluster) mode.
- Presentation of the high level design ideas by Dan.
- Allow dynamic modification of databases num if the db is not been used 2385
- Full text search functionality (https://github.com/valkey-io/valkey-rfc/pull/24)
- Valkey 9.0 Project status: (https://github.com/orgs/valkey-io/projects/18)
- Atomic slot migration. We're close, but there are still some open comments: https://github.com/valkey-io/valkey/pull/1949
- Cluster Bus Network In/Out: (https://github.com/valkey-io/valkey/issues/1929)
- Discuss Valkey Search RFC (https://github.com/valkey-io/valkey-rfc/pull/24)
- Valkey 9.0 Project status: https://github.com/orgs/valkey-io/projects/18
- HFE and atomic slot migration making progress.
- Discuss the negative filtering format for client command filters, issue 1936
- Use
NOT-*syntax. Conditionally approved from meeting
- Use
- Analytics on valkey.io via LF standard format
- Notified
Nothing?
- Discuss demos/samples repo as proposed on the issue 2272
- Core team meeting. Directionally aligned, @PingXie will take a look at the proposal offline.
- Discuss Database-level access control 2309
- Change configs for "Auto-failover on shutdown" (not yet released) to match other shutdown options #2292
- I think we discussed this last week, might have forgotten to copy it.
- Discuss Read offloading
- Offloading for pipelining. There is some amount of technical debt that is getting introduced. Let's talk about it.
- Related to https://github.com/valkey-io/valkey/pull/2208
- See notes here: https://github.com/valkey-io/valkey/issues/2022#issuecomment-3045492704
- Introduce HASH items expiration #2089 to discuss HEXPIRE etc writable command flag "DENYOOM"
- @Madelyn will back channel and ask Oran if we can change the
hexpireevent. - Only HSETEX will be marked as a write command.
- @Madelyn will back channel and ask Oran if we can change the
- Discuss client support for Swift language with authors.
- @Madelyn will add http://github.com/adam-fowler and http://github.com/fabianfett to the org. (DONE)
- Review Valkey 9 board decide code freeze.
- Code freeze at end of July? (Target July 29th)
- Required features for the launch
- Atomic slot migration (changes needed to make it source driven)
- Simplify to 1 shot for code freeze. (One week, will re-request review)
- Doesn't need help, will do other work after code freeze.
- Hash field expiration (We have a later discussion for this)
- (See below) We need another person on reviewing this. (Ricardo will take a look)
- Atomic slot migration (changes needed to make it source driven)
- Like to have features
- Memory sharing for VSS (Check with Yair about https://github.com/valkey-io/valkey/pull/1804)
- Read offloading: We should schedule a major discussion about it (Next week?)
- Prefetching and pipelining optimizations: Viktor is a bit busy, maybe we can free him up?
- Potential gaps we should be testing
- Testing multi-database clients.
- Does by-polygon have client support.
- HFE status:
- Module API support - should we add it and which API should we support?
- Current PRs status:
- Moving more towards lazy consensus https://www.apache.org/foundation/voting.html#LazyConsensus as opposed to the full consensus we get today. https://github.com/valkey-io/valkey/blob/unstable/GOVERNANCE.md#voting
- Maybe make a proposal on the governance, then leave it and commit it for after 9.0.
- For 7.2 and 8.0, we will release them with the new CVEs as is. We'll follow up and try to figure out how to reduce the test flakiness.
- Improve CLUSTER FLUSHSLOT routing and propagation https://github.com/valkey-io/valkey/pull/2167
- Didn't have quorum, need a separate vote.
- Valkey + modules named as valkey-extensions or better descriptive name. Valkey-bundle vs valkey-extended.
- Valkey-bundle is preferred name
- Slot-level memory metrics performance test result discussion #2128
- Add SAFE option to SHUTDOWN to reject shutdown in unsafe situations #2195
- Remove the 500ms fixed delay for automatic failover for faster failover #2209
What did we talk about?
- Add CLUSTER FLUSHSLOT command revisit #1384
- We will merge this as is, we can amend to it later without making any breaking change.
- Kyle will create an issue on the docs to make it clearer about how databases are kind of a node level construct.
- Hash field expirations (If we are really up to it) #2089
- Ran will continue with his work.
- Add support for automatic client authentication via TLS certificate fields #1920
- We will go with an enum.
- Automated performance benchmarking #2073
- Adding KEYINFO command to find out keys that have large number of elements#1151
- Slot-level memory metrics POC #2128
- Prevent multiple LUA debug sessions #2112
- ValkeyLDAP module https://github.com/rjd15372/valkey-ldap - discuss the repository move under valkey-io org.
- Should probably use a thread pool instead of creating a new thread per request.
- Should maintain persistent connections for the LDAP work.
- Module distribution story?
- Ricardo will move the repository. Decision is that we will leave the module as valkey-ldap.
- Save to Disk in Bio Thread #1784
PR: https://github.com/valkey-io/valkey/pull/1784
- Looks good. Don't implement a config.
- Consider change default of dual-channel-replication-enabled to "yes"#2083
- We will review this again right before the 9.0 merge. Added the 9.0 project tag.
- [NEW] Introducing an independent admin thread #1893
- Reviewed the high level architecture. Next step is to implement the interrupt code.
- Replication Flow Control – Prioritizing replication traffic in the replica #1838
- Decision was not to use a config
- RDB Compression through LZ4, Batching and Dictionary #1962
- Decision was to move forward with implementation. Some thoughts left on the issue.
- Think again: CLUSTER FLUSHSLOT (#1133, #1384) name is too similar to existing command CLUSTER FLUSHSLOTS
- Leave the name as is.
-
Adding KEYINFO command to find out keys that have large number of elements #1151
- Meeting notes see this comment on the issue
-
DELIFEQhttps://github.com/valkey-io/valkey/pull/1975- Postponed from last week
- Command accepted
- Postponed from last week
-
INCRarguments EX, PX, NX, XX https://github.com/valkey-io/valkey/issues/1818- Postponed from last week
- Meeting in favor but meeting didn't have quorum at this point.
- Postponed from last week
- Auth client using TLS client certificate's common name
- Config idea:
tls-auth-clients-user yes/no- No final decision about the config. Meeting lacked quorum.
- PR: https://github.com/valkey-io/valkey/pull/1920
- Issue: https://github.com/valkey-io/valkey/issues/1866
- Config idea:
- Add framework for cross-slot commands, enable for MGET
- Mark primary node as alive immediately if reachable and failover is not possible
- Info Keysizes section
-
Add GETPXT, MGETPXT (Get with millisecond expiration) commands Candidate
- No decision.
-
DELIFEQhttps://github.com/valkey-io/valkey/pull/1975- No time to discuss. Postponed.
-
INCRarguments EX, PX, NX, XX https://github.com/valkey-io/valkey/issues/1818- No time to discuss. Postponed.
-
Support BYPOLYGON option for GEOSEARCH #1755
- Any concerns with this feature or can it move forward to implementation?
- The API looks correct, seems better than the approach of having an index.
- Are there any concerns related to polygon validation such as overlap?
- Add tests for overlapping polygons, validating a polygon around the equator, spanning hemispheres, make sure it's not looping anywhere.
- Should we support points on the edge?
- Check the implementation of by box and by radius.
- Any concerns with this feature or can it move forward to implementation?
-
- See notes here: https://github.com/valkey-io/valkey-rfc/pull/17#issuecomment-2818791136.
- Moving forward with modules fo rnow.
- Introducing an independent admin thread (https://github.com/valkey-io/valkey/issues/1893)
- Wen will followup to collect more information
- [Client Introspection] Client Commands Extended Filtering (https://github.com/valkey-io/valkey/pull/1466)
- This seems already approved, so will skip it unless there is something else we want to discuss
- Add sentinel_total_tilt to sentinel INFO sentinel (https://github.com/valkey-io/valkey/pull/1904)
- Approved
- Add node pfail and fail count to cluster info metrics (https://github.com/valkey-io/valkey/pull/1910)
- Approved
-
Fixed CROSSSLOT ERROR in Cluster Mode for PUBSUB SHARDNUMSUB #1369
- Will have a vote for whether or not breaking change is worth it.
-
Introduce MPTCP #1811
- Approved
- Bugs and plan for 8.1.1
-
https://github.com/valkey-io/valkey/pull/1819
- Yes, it will be included
- Anything else? Check project 8.1 "To be backported"
- Any patches that have already been merged or are soon ready to merge will be included.
-
https://github.com/valkey-io/valkey/pull/1819
- 8.0.3?
- 7.2.x?
- Major decisions for 9.0:
-
#1091 Trigger manual failover on SIGTERM / shutdown to cluster primary (Viktor's suggestion)
- Approved
-
#1811 Introduce MPTCP (Viktor's suggestion)
- Conceptually approved. Only minor things like config naming were raised and we should comment about it in the PR.
-
#653 Revise config defaults for Valkey 8 (Wen's suggestion)
- We changed some defaults in 8.0. We should close this issue and create new issues for 9.0 for the defaults that are still suggested to change.
- For the listpack sizes, we deferred the decision to wait for the new hashtable to be introduced. Now, we can do some benchmarking and come up with new defaults.
-
#707 Allow multi-slot MGET in Cluster Mode (Wen's suggestion)
- Last week's decision is that Ping will open a PR with an alternative approach.
-
#1840 Enable client eviction by default, set maxmemory-clients too 100% by default (Wen's suggestion)
- The majority seems to prefer to keep it disabled by default. No formal decision.
-
#1091 Trigger manual failover on SIGTERM / shutdown to cluster primary (Viktor's suggestion)
- Other
- Follow up on #23 [NEW] Atomic slot migration HLD (Wen's suggestion)
- Follow up from last week if Jacob has more information
- We will create a feature branch under the valkey repo.
- Discussion around Python test framework. Should we adopt it more widely.
- Follow up on #23 [NEW] Atomic slot migration HLD (Wen's suggestion)
- Way of working
- Backporting changes to older version/branch - Create development guide #1558, comment
- How to prioritize better?
- Concern that e.g. Atomic slot migration is delayed due to less important changes that take our time (discussions, decisions, reviews).
- Prioritize among the 17 PRs and 24 issues that need a decision, without discussing each one in detail.
- Make decisions about individual PRs and issues:
- Enhance valkey-benchmark with Multi-Language Support and Advanced Testing Capabilities (not a major decision?)
- 8.1 GA build to be released on 3/31. [@ranshid]
- Tag the documentation repository at the same time.
- Author the release blog post.
- Feature blogs:
- New hashtable. [@zuiderkwast]
- Pre-release of a bundled container image with the official modules in early April. [@hpatro]
- Fully automated container image release process for all modules by June. [@hpatro]
- Man pages for all modules to be completed by June. [module maintainers]
- Fix for the engine crash on module client blocking during keyspace events to be released as part of 8.1.1.
- Cluster with multiple databases - issue #1671, PR #1319
- Decided to use a new config
cluster-databasesfor the number of databases in cluster mode. Default 1. The existingdatabasesconfig is not used in cluster mode. - We stop rewriting
databasesto 1 on CONFIG REWRITE when cluster is enabled.
- Decided to use a new config
- Lazy memory initialization for databases https://github.com/valkey-io/valkey/pull/1609
- Cluster topology HASH https://github.com/valkey-io/valkey/issues/1814
- We should come up with a more comprehensive plan: https://github.com/valkey-io/valkey/issues/1814#issuecomment-2729968634
- Ask for Valkey 8.1 - https://github.com/valkey-io/valkey/pull/1819
- Not sure if this API is correct, Jacob will follow up.
- More refined memory management system - https://github.com/valkey-io/valkey/issues/1792
- Directionally aligned on extending the existing functionality.
- Add last_fork_start_time to INFO STATS - https://github.com/valkey-io/valkey/pull/978
- Punting to Valkey 9.0
- Introduce cluster-ignore-disk-write-errors to prevent the process from existing when saving fails https://github.com/valkey-io/valkey/pull/1032
- Punting to Valkey 9.0
- Decide on
CLUSTER REPLICATE NO-ONEvsCLUSTER REPLICATE NO ONE: https://github.com/valkey-io/valkey/pull/1674- Decided on
CLUSTER REPLICATE NO ONE.
- Decided on
- Module versioning and bundling strategy - https://github.com/valkey-io/valkey/issues/408
- Discussed an update here: https://github.com/valkey-io/valkey/issues/408#issuecomment-2694855407
- Introduce a new API for shared memory for VSS - https://github.com/valkey-io/valkey/pull/1804/files
- Valkey 8.1 launch time frame (do we want to launch during kubecon?)
- CNCF is part of the Linux foundation, which hosts kubecon.
- Finalize server config
cluster-manual-failover-timeoutmin/max value https://github.com/valkey-io/valkey/pull/1690.- Very high failover timeout could cause write unavailability, so might be beneficial to add a cancel command. However, it's premature to build it without anyone needing it. Hence, decided against it.
- Possibly a breaking change for some clients depending on the output so it shouldn't be included in 8.1 https://github.com/valkey-io/valkey/pull/1559
- Discussed RC2 - Stabilization of test failures in progress. No new major features are getting built in. 3 weeks cadence of RC release can be followed.
- Discuss future of kubernetes operator.
- Good progress. Will try to get everyone together to collect the requirements.
- Discuss PR https://github.com/valkey-io/valkey/pull/1357 -- Add new replicate module API to bypass command validation
- Updated proposal about the the implementation.
- Discuss the naming issue for PR https://github.com/valkey-io/valkey/pull/831
- New item for RC1? https://github.com/valkey-io/valkey/pull/1698 Show capa in client list
- RC1 release content:
-
https://github.com/valkey-io/valkey/pull/1701 - Debugger support for scripting engines.
- Decided to postpone to 9.0. Conversation about whether we should drop support for script debugging.
-
https://github.com/valkey-io/valkey/pull/1091 - need to align everyone that we are taking this to rc1.
- We skip it for RC1. We can include it in RC2 if it's approved until then.
-
https://github.com/valkey-io/valkey/pull/978 - is this ready to be merged?
- ?
-
https://github.com/valkey-io/valkey/pull/1701 - Debugger support for scripting engines.
- Which features can make it to the 8.1.0-rc1.
- Various discussion about the release.
- Release candidate version numbering.
- Whether to revise the decision to use 8.1 rather than 8.2, https://github.com/valkey-io/valkey/issues/1650
- Decision to stick to 8.1
- Which version to use for release candidates e.g. in the INFO and HELLO fields. Options:
8.0.240,8.1.0(same as GA),8.1.0-rc1.- Discussion of pros and cons of each option.
- Decision(?) to use the GA version
8.1.0identical for all release candidates and for the GA release. - Idea raised about introducing an INFO field to identify that the server is running a release candidate.
- Whether to revise the decision to use 8.1 rather than 8.2, https://github.com/valkey-io/valkey/issues/1650
- Scripting engine modulization (Ricardo)
- Allows users to replace builtin Lua with LuaJit, Lua 5.3, etc.
- Convert builtin Lua to module? (how and why) (issue #1627)
- We decided to postpone this to after 8.1.
- How to disable the builtin Lua: Just unload the module? (issue #1204)
- Current state: Module API for defining scripting engines already merged (PR #1277), but needs some more API changes for EVAL and for being able to completely provide a Lua engine using module API.
- Multiple Lua can co-exist in modules if we just change the call to
dlopen()in module.c to use theRTLD_DEEPBINDflag. Safe to change?- We decided that we want a separate pull request for this change.
- Decisions we have to make before RC1. What to prioritize?
- Rolling downgrade, forward compatibility https://github.com/valkey-io/valkey/issues/1108 (Vote)
- Approved the PR "Relaxed RDB version check" https://github.com/valkey-io/valkey/pull/1604
- Add key-eviction-memory parameter for evicting key earlier to avoid OOM https://github.com/valkey-io/valkey/pull/831
- No consensus about config name and semantics. Discussion continues on the PR.
- Add paused_reason to INFO CLIENTS https://github.com/valkey-io/valkey/pull/1564
- Please approve or comment on the PR.
- Extend LATENCY LATEST to add min / sum / cnt stats https://github.com/valkey-io/valkey/pull/1570
- The usefulness of the
minfield is questioned. Maybe we can skip that one and keep the other fields. Comment on the PR.
- The usefulness of the
- Add new SCRIPT STATS subcommand https://github.com/valkey-io/valkey/pull/1418
- The usefulness of this command is questioned, and whether stats for scripts and functions should be covered by the same commands. Ricardo will think about the usefulness of this command while working on scripting engine modularization.
- Reply Offload yes/no https://github.com/valkey-io/valkey/pull/1457
- Concerns about the complexity of the optimization and whether the performance improvement is large enough to justify the complexity.
- Suggestion to open separate PR with a simpler approach, which would only avoid copying large strings (e.g. more than one page size) to the reply buffer, and would not be limited to IO threads. It is likely less performant, but can be achieved with a smaller change and less complexity. Ideas to be posted on the PR.
- Rolling downgrade, forward compatibility https://github.com/valkey-io/valkey/issues/1108 (Vote)
- discuss generally our stance regarding minor code improvements / refactoring / syntactic sugar changes.
-
- We discussed. No consensus about general stance. Changes that are objectively to the better (correcting typos) are more often accepted than changes that are more about personal preferences. Git blame is used extensively by some of us, so there's benefit in avoiding changes.
-
- 8.1 Release
- RC1 on February 11th.
- Discuss Atomic slot migration HLD - https://github.com/valkey-io/valkey/issues/23
- Discussion deferred, Ping will discuss with BinBin offline
- Support Empty Set - https://github.com/valkey-io/valkey/issues/68
- Implementation is waiting for hash field expiration first. See https://github.com/valkey-io/valkey/issues/640.
- Discuss Valkey Vector Search RFC https://github.com/valkey-io/valkey-rfc/pull/15
- Vote for PR https://github.com/valkey-io/valkey/pull/1519 (add paused_actions for INFO stats)
- Vote for PR https://github.com/valkey-io/valkey/pull/1401 (Adding Missing filters to CLIENT LIST and Dedup Parsing)
- Discuss PR Reply offload (https://github.com/valkey-io/valkey/pull/1457)
- Discuss https://github.com/valkey-io/valkey-rfc/pull/14 (OBSERVE command for enhanced observability in Valkey)