Skip to content

Conversation

@soloestoy
Copy link
Member

No description provided.

Signed-off-by: zhaozhao.zz <[email protected]>
@soloestoy soloestoy requested a review from a team February 10, 2025 10:39
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.07%. Comparing base (61a854d) to head (62b08fd).
Report is 7 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1698      +/-   ##
============================================
+ Coverage     70.92%   71.07%   +0.15%     
============================================
  Files           121      121              
  Lines         65313    65316       +3     
============================================
+ Hits          46321    46425     +104     
+ Misses        18992    18891     -101     
Files with missing lines Coverage Δ
src/networking.c 88.77% <100.00%> (+0.01%) ⬆️

... and 14 files with indirect coverage changes

@xbasel
Copy link
Member

xbasel commented Feb 10, 2025

What's the use-case?

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept. 👍

@zuiderkwast zuiderkwast added the major-decision-pending Major decision pending by TSC team label Feb 10, 2025
@soloestoy soloestoy added major-decision-approved Major decision approved by TSC team needs-doc-pr This change needs to update a documentation page. Remove label once doc PR is open. and removed major-decision-pending Major decision pending by TSC team labels Feb 10, 2025
@soloestoy soloestoy merged commit 96857bf into valkey-io:unstable Feb 10, 2025
50 checks passed
@enjoy-binbin enjoy-binbin added the release-notes This issue should get a line item in the release notes label Feb 10, 2025
@enjoy-binbin enjoy-binbin changed the title show capa in CLIENT LIST show capa in CLIENT LIST / CLIENT INFO Feb 10, 2025
soloestoy added a commit to valkey-io/valkey-doc that referenced this pull request Feb 11, 2025
xbasel pushed a commit to xbasel/valkey that referenced this pull request Mar 27, 2025
xbasel pushed a commit to xbasel/valkey that referenced this pull request Mar 27, 2025
murphyjacob4 pushed a commit to enjoy-binbin/valkey that referenced this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major-decision-approved Major decision approved by TSC team needs-doc-pr This change needs to update a documentation page. Remove label once doc PR is open. release-notes This issue should get a line item in the release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants