-
Notifications
You must be signed in to change notification settings - Fork 955
Reset cluster related stats in CONFIG RESETSTATS #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
enjoy-binbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also take a look at https://github.com/valkey-io/valkey/blob/unstable/CONTRIBUTING.md and sign the DOC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2458 +/- ##
============================================
- Coverage 71.58% 71.55% -0.03%
============================================
Files 125 125
Lines 69214 69218 +4
============================================
- Hits 49545 49531 -14
- Misses 19669 19687 +18
🚀 New features to boost your workflow:
|
|
@enjoy-binbin @sarthakaggarwal97 |
@withRiver, unfortunately even though we squash all commits before merging the DCO check will verify all the commits in this PR are signed. you can probably do a |
|
Sorry. I have added DCO signature to all my commits now. |
ranshid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…en executing CONFIG RESETSTATS Reset server.cluster->stats_bus_messages_xx and server.cluster->stat_cluster_links_buffer_limit_exceeded in resetClusterStats() Signed-off-by: Hongrui <[email protected]>
enjoy-binbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valkey-io/core-team This is a minor change, please take a look at the top comment and approve.
zuiderkwast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the behavior change. I didn't review the code.
|
Thanks @withRiver! |
hpatro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just checked new slot migration code, it has different mechanism to maintain/cleanup the finished slot migration operation, so we can avoid that here I guess.
Previously CONFIG RESETSTATS only resets the slot statistics in cluster part, this PR makes it reset cluster bus messages at well. Additionally, we also reset stat_cluster_links_buffer_limit_exceeded. Now we will reset: - cluster_stats_messages_sent* - cluster_stats_messages_received* - total_cluster_links_buffer_limit_exceeded Closes valkey-io#2439. Signed-off-by: Hongrui <[email protected]>
Previously CONFIG RESETSTATS only resets the slot statistics in cluster part, this PR makes it reset cluster bus messages at well. Additionally, we also reset stat_cluster_links_buffer_limit_exceeded. Now we will reset: - cluster_stats_messages_sent* - cluster_stats_messages_received* - total_cluster_links_buffer_limit_exceeded Closes #2439. Signed-off-by: Hongrui <[email protected]>
Previously CONFIG RESETSTATS only resets the slot statistics in cluster part, this PR makes it reset cluster bus messages at well. Additionally, we also reset stat_cluster_links_buffer_limit_exceeded. Now we will reset: - cluster_stats_messages_sent* - cluster_stats_messages_received* - total_cluster_links_buffer_limit_exceeded Closes valkey-io#2439. Signed-off-by: Hongrui <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
Previously CONFIG RESETSTATS only resets the slot statistics in
cluster part, this PR makes it reset cluster bus messages at well.
Additionally, we also reset stat_cluster_links_buffer_limit_exceeded.
Now we will reset:
Closes #2439.