New module API event for tracking authentication attempts #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we introduce a new module API event called `ValkeyModuleEvent_AuthenticationAttempt` to track successful/failed authentication attempts. This event will fill a struct, called `ValkeyModuleAuthenticationInfo`, with the client ID of the connection, the IP address and port, the username, the module name that handle the authentication event, and the result of the authentication attempt. Fixes: valkey-io#2211 Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2237 +/- ##
============================================
+ Coverage 71.41% 72.22% +0.81%
============================================
Files 123 126 +3
Lines 67139 70659 +3520
============================================
+ Hits 47947 51036 +3089
- Misses 19192 19623 +431
🚀 New features to boost your workflow:
|
hpatro
reviewed
Jun 20, 2025
Signed-off-by: Ricardo Dias <[email protected]>
- Used an enumeration for the authentication result - removed IP and port from auth info structure - added tests to test the module blocking authentication Signed-off-by: Ricardo Dias <[email protected]>
Member
Author
|
@madolson can we get this in for 9.0? |
madolson
reviewed
Jul 21, 2025
Signed-off-by: Ricardo Dias <[email protected]>
enjoy-binbin
added
release-notes
zuiderkwast
reviewed
Aug 5, 2025
zuiderkwast
added
major-decision-approved
Signed-off-by: Ricardo Dias <[email protected]>
zuiderkwast
reviewed
Aug 26, 2025
Signed-off-by: Ricardo Dias <[email protected]>
zuiderkwast
approved these changes
Sep 1, 2025
Signed-off-by: Ricardo Dias <[email protected]>
zuiderkwast
approved these changes
Sep 1, 2025
rjd15372
added a commit
to rjd15372/valkey
that referenced
this pull request
Sep 19, 2025
…2237) In this commit we introduce a new module API event called `ValkeyModuleEvent_AuthenticationAttempt` to track successful/failed authentication attempts. This event will fill a struct, called `ValkeyModuleAuthenticationInfo`, with the client ID of the connection, the username, the module name that handle the authentication event, and the result of the authentication attempt. Fixes: valkey-io#2211 --------- Signed-off-by: Ricardo Dias <[email protected]>
rjd15372
added a commit
that referenced
this pull request
Sep 23, 2025
In this commit we introduce a new module API event called `ValkeyModuleEvent_AuthenticationAttempt` to track successful/failed authentication attempts. This event will fill a struct, called `ValkeyModuleAuthenticationInfo`, with the client ID of the connection, the username, the module name that handle the authentication event, and the result of the authentication attempt. Fixes: #2211 --------- Signed-off-by: Ricardo Dias <[email protected]>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
…2237) In this commit we introduce a new module API event called `ValkeyModuleEvent_AuthenticationAttempt` to track successful/failed authentication attempts. This event will fill a struct, called `ValkeyModuleAuthenticationInfo`, with the client ID of the connection, the username, the module name that handle the authentication event, and the result of the authentication attempt. Fixes: valkey-io#2211 --------- Signed-off-by: Ricardo Dias <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we introduce a new module API event called
ValkeyModuleEvent_AuthenticationAttemptto track successful/failed authentication attempts.This event will fill a struct, called
ValkeyModuleAuthenticationInfo, with the client ID of the connection, the username, the module name that handle the authentication event, and the result of the authentication attempt.Fixes: #2211