Relaxed RDB check for foreign RDB formats #2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Söderqvist <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #2543 +/- ##
=========================================
Coverage 72.21% 72.22%
=========================================
Files 126 127 +1
Lines 70618 70713 +95
=========================================
+ Hits 50997 51070 +73
- Misses 19621 19643 +22
🚀 New features to boost your workflow:
|
Signed-off-by: Viktor Söderqvist <[email protected]>
ranshid
approved these changes
Aug 25, 2025
Member
ranshid
left a comment
ranshid
left a comment
There was a problem hiding this comment.
LGTM - small comment about message
zuiderkwast
added
release-notes
Signed-off-by: Viktor Söderqvist <[email protected]>
hpatro
reviewed
Aug 27, 2025
Collaborator
hpatro
left a comment
hpatro
left a comment
There was a problem hiding this comment.
Mostly LGTM. Will be good to have coverage via adding foreign RDB version/type not supported. Might need to start a Redis server and take some snapshots and copy it our test assets.
Signed-off-by: Viktor Söderqvist <[email protected]>
… rdb Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
force-pushed
the
relaxed-rdb-redis
branch
from
12f6a96 to
e03279c
Compare
Signed-off-by: Viktor Söderqvist <[email protected]>
Contributor
Author
@hpatro I have added various RDB files and tests. I created an RDB 12 with the commit just before #665. We actually had RDB 12 in valkey unstable before that PR was merged. The other files RDB 75 and RDB 987 with and without unknonw types were created by editing the binary files. The unknown type is just a string where I changed the type byte. |
enjoy-binbin
approved these changes
Sep 4, 2025
ranshid
approved these changes
Sep 4, 2025
Member
ranshid
left a comment
ranshid
left a comment
There was a problem hiding this comment.
Overall LGTM.
left some minor comments to consider
Signed-off-by: Viktor Söderqvist <[email protected]>
rjd15372
pushed a commit
to rjd15372/valkey
that referenced
this pull request
Sep 19, 2025
In valkey-io#1604, we attempt to read future Valkey RDB formats, but we rejected foreign RDB formats, because of the risk that the opcodes and types added by other projects collide with the new types and opcodes added in recent Valkey versions. This change accepts foreign RDB versions but limits the types and opcodes to the ones that we can understand, to prevent misinterpretation of types/opcodes which could lead to undefined behavior. If unsupported RDB types or opcodes are seen, we error out. Additional changes: * Improve error reporting when encountering unknown RDB types in relaxed version check mode. * Tests for loading various RDB files. * Improvement to valkey-check-rdb to accept future and foreign RDB versions, including tests. --------- Signed-off-by: Viktor Söderqvist <[email protected]>
rjd15372
pushed a commit
that referenced
this pull request
Sep 23, 2025
In #1604, we attempt to read future Valkey RDB formats, but we rejected foreign RDB formats, because of the risk that the opcodes and types added by other projects collide with the new types and opcodes added in recent Valkey versions. This change accepts foreign RDB versions but limits the types and opcodes to the ones that we can understand, to prevent misinterpretation of types/opcodes which could lead to undefined behavior. If unsupported RDB types or opcodes are seen, we error out. Additional changes: * Improve error reporting when encountering unknown RDB types in relaxed version check mode. * Tests for loading various RDB files. * Improvement to valkey-check-rdb to accept future and foreign RDB versions, including tests. --------- Signed-off-by: Viktor Söderqvist <[email protected]>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Oct 3, 2025
In valkey-io#1604, we attempt to read future Valkey RDB formats, but we rejected foreign RDB formats, because of the risk that the opcodes and types added by other projects collide with the new types and opcodes added in recent Valkey versions. This change accepts foreign RDB versions but limits the types and opcodes to the ones that we can understand, to prevent misinterpretation of types/opcodes which could lead to undefined behavior. If unsupported RDB types or opcodes are seen, we error out. Additional changes: * Improve error reporting when encountering unknown RDB types in relaxed version check mode. * Tests for loading various RDB files. * Improvement to valkey-check-rdb to accept future and foreign RDB versions, including tests. --------- Signed-off-by: Viktor Söderqvist <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1604, we attempt to read future Valkey RDB formats, but we rejected foreign RDB formats, because of the risk that the opcodes and types added by other projects collide with the new types and opcodes added in recent Valkey versions.
This change accepts foreign RDB versions but limits the types and opcodes to the ones that we can understand, to prevent misinterpretation of types/opcodes which could lead to undefined behavior. If unsupported RDB types or opcodes are seen, we error out.
Additional changes: