fix(t8s-cluster/workload-cluster): correctly set extraArgs value

[cwrau]

While controllerPlugin.extraArgs works, it doesn't set it for the nodePlugin

Summary by CodeRabbit

• Refactor
  • Reorganized CSI plugin configuration to improve compatibility across Kubernetes versions.
  • Added version-specific conditional handling to ensure proper deployment behavior for different releases.

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where extraArgs were not being correctly propagated to the node plugin of the Cinder CSI driver. By adjusting the placement of the extraArgs definition within the Helm chart template and introducing a version-based conditional, the configuration now applies universally to the Cinder CSI plugin, improving its functionality and compatibility across different Kubernetes versions.

Highlights

• Cinder CSI extraArgs Configuration: The extraArgs for the Cinder CSI plugin have been refactored to apply at the top-level plugin scope, ensuring they are correctly passed to both controller and node plugins. This change is conditionally applied for Kubernetes minor versions 32 and above.

Changelog

• charts/t8s-cluster/templates/workload-cluster/cinder-csi-plugin/cinder-csi-plugin.yaml
  • Moved the extraArgs definition from controllerPlugin to the parent plugin level.
  • Introduced a conditional check (if ge (int .Values.version.minor) 32) to apply extraArgs only for Kubernetes minor versions 32 and higher.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa7d054 and 62bfbb0.

📒 Files selected for processing (1)

• charts/t8s-cluster/templates/workload-cluster/cinder-csi-plugin/cinder-csi-plugin.yaml

---

📝 Walkthrough

Walkthrough

The PR relocates the Cinder CSI plugin's topology argument from controllerPlugin to the plugin configuration under csi.plugin, with a conditional guard ensuring the change only applies when the minor version is 32 or later, maintaining backward compatibility with older versions.

Changes

Cohort / File(s)	Summary
Cinder CSI Plugin Configuration charts/t8s-cluster/templates/workload-cluster/cinder-csi-plugin/cinder-csi-plugin.yaml	Relocated --with-topology=false argument from the top-level controllerPlugin extraArgs block to the plugin configuration under csi.plugin, guarded by a conditional check for minor version >= 32 to ensure compatibility with older versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix(t8s-cluster/workload-cluster): migrate extraArgs type to string #1985: Modifies the cinder-csi-plugin's controllerPlugin.extraArgs handling by converting it to a string format, directly related to the extraArgs management being changed here.
• chore(t8s-cluster): migrate config, ignore-volume-az is not enough #1679: Introduces the original --with-topology=false argument under controllerPlugin, which this PR now relocates with version-based conditioning.

Suggested labels

t8s-cluster

Suggested reviewers

• tasches
• teutonet-bot
• marvinWolff

Poem

🐰 A topology arg takes flight,
From controller to plugin, version-gated right,
Thirty-two and above shall see,
The CSI dance, backward-compatible and free!
✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(t8s-cluster/workload-cluster): correctly set extraArgs value' directly describes the main change - fixing the extraArgs configuration for the workload cluster CSI plugin.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/t8s-cluster/csi-values

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request correctly moves the extraArgs to apply to both the controller and node CSI plugins. However, the newly introduced condition if ge (int .Values.version.minor) 32 removes these arguments for Kubernetes versions older than 1.32. This is a change from the previous behavior where the argument was set for the controller plugin, and could potentially cause issues on clusters running older Kubernetes versions. I've added a comment with a suggestion to address this.

[Copilot]

Pull request overview

This PR fixes the configuration of the cinder-csi-plugin to ensure the --with-topology=false argument is applied to both the controller plugin and the node plugin, not just the controller plugin. The issue was that controllerPlugin.extraArgs only affected the controller, leaving the node plugin without this critical configuration.

Changes:

• Moved extraArgs from csi.plugin.controllerPlugin.extraArgs to csi.plugin.extraArgs to apply to both controller and node plugins

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.