feat(t8s-cluster/management-cluster): add compute-plane role label to nodes

[cwrau]

Summary by CodeRabbit

Release Notes

• Chores
  • Updated cluster configuration to enhance worker node organization by adding compute-plane labels to worker deployments. This improvement enables better cluster resource categorization and supports more effective node management and administration workflows. Existing health checks, deployment behaviors, and rollout strategies remain unchanged.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a standardized labeling convention for nodes within the t8s-cluster management framework. By automatically assigning the node-role.kubernetes.io/compute-plane label to all machine deployments, it provides a clear and consistent way to identify general-purpose worker nodes. This change aims to improve cluster manageability, facilitate more precise workload scheduling, and align with established Kubernetes node labeling practices.

Highlights

• Node Labeling: Added the node-role.kubernetes.io/compute-plane label to all machine deployments defined within the clusterClass.yaml.
• Configuration Update: The new label is applied under the metadata.labels section for each machine deployment class, ensuring consistent identification of compute nodes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

📝 Walkthrough

Walkthrough

A Kubernetes Helm template is updated to add a node-role.kubernetes.io/compute-plane label to worker machineDeployment metadata. This enables worker nodes to carry a compute-plane designation, allowing for proper Kubernetes role-based identification and scheduling decisions.

Changes

Cohort / File(s)	Summary
Kubernetes Cluster Template charts/t8s-cluster/templates/management-cluster/clusterClass/clusterClass.yaml	Added metadata.labels block with node-role.kubernetes.io/compute-plane label to worker machineDeployment entries, enabling compute-plane node classification without altering deployment logic or health checks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A label here, a label there,
Now workers wear their role with care,
Compute-plane nodes so bright and true,
Kubernetes knows just what to do! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a compute-plane role label to nodes in the management-cluster template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request adds the node-role.kubernetes.io/compute-plane label to all worker nodes in the cluster. This is a useful feature for identifying compute nodes. However, the current implementation applies this label to all node pools without an option to disable it. I've suggested making this configurable to provide more flexibility for users who might want to create node pools for other purposes (e.g., infrastructure nodes) that are not part of the compute plane.

[Copilot]

Pull request overview

This PR adds the node-role.kubernetes.io/compute-plane label to machine deployment nodes in the management cluster's ClusterClass specification.

Changes:

• Added metadata.labels section to machine deployments with the node-role.kubernetes.io/compute-plane: "" label

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.