[SFP-Refactor] Fix vendor revision key issue#231
Conversation
aravindmani-1
changed the title
|
@aravindmani-1 and @prgeor can you please share the refactored sfp change which is related to this change? |
|
|
@aravindmani-1 and @prgeor - There are corresponding changes required in sonic-mgmt platform tests to accommodate this change. Specifically:
Could you please make the appropriate change in sonic-mgmt as well. |
sonic-net/sonic-mgmt#481 has been raised to handle it. |
|
@aravindmani-1 i think you meant this PR sonic-net/sonic-mgmt#4816 |
Yes.That's right. |
Because only master support the PR:sonic-net/sonic-platform-daemons#231
What is the motivation for this PR? In test_transceiver_info the key of hardware_rev has been changed to vendor_rev. According to these PRs(sonic-net/sonic-platform-daemons#231, sonic-net/sonic-utilities#1950), now only master branch support the key of vendor_rev. So, for other branches it still keeps the key of hardware_rev. How did you do it? For latest master release, use "vendor_rev" as transceiver info key. For release in ["201911", "202012", "202106", "202111"], use "hardware_rev" as transceiver info key. How did you verify/test it? Run test_transceiver_info on different branches, for example: master, 202012.
|
@qiluo-msft could you please cherry-pick this fix to 202012 to fix sonic-mgmt test failure https://dev.azure.com/mssonic/12b9cbf4-b1d3-4768-8e49-669345c32e5d/_apis/build/builds/65630/logs/22 |
qiluo-msft
added
Included in 202012 Branch
and removed
Included in 202012 Branch
labels
|
Removing the label as its not required |
- What I did In the TRANSCEIVER_INFO table of STATE_DB, the key of transceiver reversion was changed from "hardware_rev" to "vendor_rev", detail info please refer to PR sonic-net/sonic-platform-daemons#231 RFC2737 implementation needs to be updated with the new key name in order to get the correct info from the state DB - How I did it Update the key name from "hardware_rev" to "vendor_rev", update the unit test cases. - How to verify it Run the community SNMP test. - Description for the changelog
|
@aravindmani-1 it seems that this PR is missing on 202111 |
@prgeor , @qiluo-msft Could you please help to cherry pick this PR on 202111 branch?. |
- What I did In the TRANSCEIVER_INFO table of STATE_DB, the key of transceiver reversion was changed from "hardware_rev" to "vendor_rev", detail info please refer to PR sonic-net/sonic-platform-daemons#231 RFC2737 implementation needs to be updated with the new key name in order to get the correct info from the state DB - How I did it Update the key name from "hardware_rev" to "vendor_rev", update the unit test cases. - How to verify it Run the community SNMP test. - Description for the changelog
7 participants
Description
With new SFP refactor, hardware_rev is replaced with Vendor_rev key.
Made the changes in alignment with sonic-net/sonic-mgmt#4816
Motivation and Context
xcvrd may crash for platform vendors as hardware_rev key is used in place of vendor_rev key.
How Has This Been Tested?
Tested in DellEMC Z9332f platform.
Additional Information (Optional)