Fix RFC2737 implementation with updated xcvr vendor version key name#241
Merged
SuvarnaMeenakshi merged 1 commit intosonic-net:masterfrom Feb 1, 2022
Merged
Conversation
Signed-off-by: Kebo Liu <[email protected]>
Junchao-Mellanox
approved these changes
Jan 19, 2022
liat-grozovik
approved these changes
Jan 19, 2022
Collaborator
Author
|
Hi @qiluo-msft would you please help to review this fix when you have time? |
Contributor
|
@keboliu Please add required labels if this is to be cherry picked to the older branches. |
ssithaia-ebay
pushed a commit
to ssithaia-ebay/sonic-snmpagent
that referenced
this pull request
May 23, 2025
- What I did In the TRANSCEIVER_INFO table of STATE_DB, the key of transceiver reversion was changed from "hardware_rev" to "vendor_rev", detail info please refer to PR sonic-net/sonic-platform-daemons#231 RFC2737 implementation needs to be updated with the new key name in order to get the correct info from the state DB - How I did it Update the key name from "hardware_rev" to "vendor_rev", update the unit test cases. - How to verify it Run the community SNMP test. - Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu [email protected]
- What I did
In the TRANSCEIVER_INFO table of STATE_DB, the key of transceiver reversion was changed from "hardware_rev" to "vendor_rev", detail info please refer to PR sonic-net/sonic-platform-daemons#231
RFC2737 implementation needs to be updated with the new key name in order to get the correct info from the state DB
- How I did it
Update the key name from "hardware_rev" to "vendor_rev", update the unit test cases.
- How to verify it
Run the community SNMP test.
- Description for the changelog