[test_snmp_phy_entity] Fix key error for test_transceiver_info#4963
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jan 20, 2022
Merged
[test_snmp_phy_entity] Fix key error for test_transceiver_info#4963wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
Because only master support the PR:sonic-net/sonic-platform-daemons#231
JibinBao
changed the title
liat-grozovik
approved these changes
Jan 19, 2022
Collaborator
|
@yxieca could you please help to review? |
wangxin
approved these changes
Jan 20, 2022
This was referenced Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test_transceiver_info the key of hardware_rev has been changed to vendor_rev.
According to these PRs(sonic-net/sonic-platform-daemons#231, sonic-net/sonic-utilities#1950), now only master branch support the key of vendor_rev. So, for other branches it still keeps the key of hardware_rev.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix key error issue in test_transceiver_info.
How did you do it?
Run test_transceiver_info
How did you verify/test it?
Run test_transceiver_info on different branches, for example: master, 202012.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation