[test_get_transceiver_info] Fix key error for test_get_transceiver_info #5164
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Feb 20, 2022
Merged
Conversation
liat-grozovik
approved these changes
Feb 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In test_get_transceiver_info, for branch 20111, we should use key of hardware_rev instead of vendor_rev.
According to these PRs(sonic-net/sonic-platform-daemons#231, sonic-net/sonic-utilities#1950), now branch 202111 only support the key of hardware_rev.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix key error issue for test_get_transceiver_info
How did you do it?
When branch is 20111, use key of hardware_rev instead of vendor_rev.
How did you verify/test it?
Run test_get_transceiver_info
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Documentation