[SFP-Refactor] Modify transceiver key name#9447
Merged
prgeor merged 2 commits intosonic-net:masterfrom Dec 9, 2021
Merged
Conversation
Contributor
Author
|
@prgeor Can you please review this PR?. |
aravindmani-1
changed the title
4 tasks
prgeor
requested changes
Dec 6, 2021
Contributor
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
can you change the comment under "Information"
device/accton/x86_64-accton_as4630_54te-r0/sonic_platform/sfp.py
Outdated
Show resolved
Hide resolved
prgeor
approved these changes
Dec 7, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes the issue sonic-net/sonic-platform-common#250
How I did it
Modified transceiver dict keys for all the vendors
How to verify it
Check "sfpshow eeprom".
Check xcvrd logs.
Note:
Merge this PR only when sonic-net/sonic-platform-daemons#231 is merged
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)