[platform] Implement platform phase 1 cases by wangxin · Pull Request #915 · sonic-net/sonic-mgmt

wangxin · 2019-05-16T08:08:07Z

Description of PR

Summary:
Fixes # (issue)

Implement the SONiC platform phase 1 test cases using the pytest-ansible framework.

The SONiC platform test cases are documented here:
https://github.com/Azure/SONiC/blob/master/doc/pmon/sonic_platform_test_plan.md

Test cases implemented in phase 1:

Test Case	Script	Common for all vendors?
Case 1.1 Check platform information	tests/platform/test_platform_info.py	Yes
Case 1.3 Check SFP status and configure SFP	tests/platform/test_sfp.py	Yes
Case 1.4 Check xcvrd information in DB	tests/platform/test_xcvr_info_in_db.py	Yes
Case 2.1 Ensure that the hw-management service is running properly	tests/platform/mellanox/test_hw_management_service.py	No
Case 2.2 Check SFP using ethtool	tests/platform/mellanox/test_check_sfp_using_ethtool.py	No
Case 2.3 Check SYSFS	tests/platform/mellanox/test_check_sysfs.py	No
Case 2.4 Verify that /var/run/hw-management is mapped to docker pmon	tests/platform/mellanox/check_sysfs.py	No

Please note that only the scripts for common test cases were included in this PR.

root@75978c06de6f:~/code/sonic-mgmt/tests# py.test --inventory ../ansible/inventory --host-pattern mtbc-sonic-03-2700 --module-path ../ansible/library/ --testbed mtbc-sonic-03-2700-t1 --testbed_file ../ansible/testbed.csv platform/test_* -ra -vvvvv
========================================================================================================= test session starts ==========================================================================================================platform linux2 -- Python 2.7.12, pytest-4.4.1, py-1.8.0, pluggy-0.9.0 -- /usr/bin/python
cachedir: .pytest_cache
ansible: 2.0.0.2
rootdir: /root/code/sonic-mgmt/tests, inifile: setup.cfg
plugins: ansible-2.0.2
collected 6 items                                                                                                                                                                                                                      

platform/test_platform_info.py::test_show_platform_summary PASSED                                                                                                                                                                [ 16%]
platform/test_platform_info.py::test_show_platform_psustatus PASSED                                                                                                                                                              [ 33%]
platform/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus PASSED                                                                                                                                                  [ 50%]
platform/test_platform_info.py::test_show_platform_syseeprom PASSED                                                                                                                                                              [ 66%]
platform/test_sfp.py::test_check_sfp_status_and_configure_sfp PASSED                                                                                                                                                             [ 83%]
platform/test_xcvr_info_in_db.py::test_xcvr_info_in_db PASSED                                                                                                                                                                    [100%]

=========================================================================================================== warnings summary ===========================================================================================================platform/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus
  /usr/local/lib/python2.7/dist-packages/paramiko/rsakey.py:129: CryptographyDeprecationWarning: signer and verifier have been deprecated. Please use sign and verify instead.
    algorithm=hashes.SHA1(),

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================================================================================================ 6 passed, 1 warnings in 337.47 seconds ================================================================================================

Type of change

[] Bug fix
[] Testbed and Framework(new/improvement)
Test case(new/improvement)

Approach

How did you do it?

Implement the SONiC platform phase 1 test cases using the pytest-ansible framework and follow the design of PR #802

How did you verify/test it?

Tested on the mellanox platform

Any platform specific information?

This PR does not include platform specific test cases.

Supported testbed topology if it's a new test case?

All current test topologies are supported:
[t0, t0-16, t0-56, t0-64, t0-64-32, t0-116, t1, t1-lag, t1-64-lag, ptf32, ptf64]

Documentation

The SONiC platform test plan:
https://github.com/Azure/SONiC/blob/master/doc/pmon/sonic_platform_test_plan.md

Signed-off-by: Xin Wang <[email protected]>

wangxin · 2019-05-20T09:05:59Z

@jleveque Could you please help review this PR?

tests/platform/psu_controller.py

Changes: * Add mellanox_psu_controller.py which has Mellanox implementation of PSU controller. * Increase the delay between reset SFP and checking SFP presence for SFP to be fully recovered. * Improve the checking of PSU status. * Correct spelling errors. Signed-off-by: Xin Wang <[email protected]>

wangxin · 2019-05-28T01:05:15Z

@jleveque Any more comments or concerns?

neethajohn

Looks good to me

liat-grozovik · 2019-06-02T08:58:01Z

tests/platform/test_platform_info.py

+    hostname = testbed['dut']
+    ans_host = ansible_host(ansible_adhoc, hostname)
+
+    logging.info("Check output of 'show platform summary'")


In general I suggest that commands name as well as expected error/OK message will be defined once (as a constant) and will be used by both log info as well as he command / message to use.
it is simpler in term changes might be introduced later on and code change will be done only once

Sure, updated in the new commit.

liat-grozovik · 2019-06-02T09:05:17Z

tests/platform/test_sfp.py

+    return res
+
+
+def test_check_sfp_status_and_configure_sfp(localhost, ansible_adhoc, testbed):


If i am not mistaken we also have low power mode option under sfputil. Should we add it as well?

Sure. Added SFP low power mode testing in the new commit.

* Replace inline command strings with predefined variables * Add test case for testing SFP low power mode Signed-off-by: Xin Wang <[email protected]>

wangxin · 2019-06-14T08:32:13Z

@lguohan @liat-grozovik Any more comments?

The order of information output by command "show platform syseeprom" is not guranteed. This commit improve the method of comparing the content output by syseeprom plugin and the show command to avoid the failure caused by inconsistent output order. Signed-off-by: Xin Wang <[email protected]>

wangxin · 2019-06-22T14:03:58Z

Added a new commit fixing an issue of comparing syseeprom output from "show platform syseeprom" and platform plugin.

[201911][thermal control] Backport changes from master branch (sonic-net#929) [201911][config] Support abbreviation (sonic-net#933) Add 'hw-management-generate-dump.sh' to 'show techsupport' command (sonic-net#934) [fwutil]: Update fwutil to v2.0.0.0. (sonic-net#942) Fixes bug for PFCWD feature parameters (sonic-net#838) Fixed fast-reboot for BFN platform (sonic-net#871) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) [warm-reboot]: added pre-check for ISSU file (sonic-net#915) [config] Don't attempt to restart disabled services (sonic-net#944)

[platform] Implement platform phase 1 cases

696e426

Signed-off-by: Xin Wang <[email protected]>

liat-grozovik requested review from jleveque and lguohan May 21, 2019 16:17

jleveque reviewed May 22, 2019

View reviewed changes

tests/platform/psu_controller.py Show resolved Hide resolved

lguohan requested a review from neethajohn May 28, 2019 16:59

neethajohn approved these changes May 30, 2019

View reviewed changes

liat-grozovik requested changes Jun 2, 2019

View reviewed changes

[platform] Improve scripts according to review comments

c67c6e1

* Replace inline command strings with predefined variables * Add test case for testing SFP low power mode Signed-off-by: Xin Wang <[email protected]>

jleveque added the Enhancement label Jun 14, 2019

liat-grozovik approved these changes Jun 23, 2019

View reviewed changes

liat-grozovik merged commit 8eb8f22 into sonic-net:master Jun 23, 2019

wangxin mentioned this pull request Jun 26, 2019

[platform] Implement platform phase 2 cases #980

Merged

1 task

wangxin deleted the platform-pytest-pr branch September 26, 2019 12:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[platform] Implement platform phase 1 cases#915

[platform] Implement platform phase 1 cases#915
liat-grozovik merged 4 commits intosonic-net:masterfrom
wangxin:platform-pytest-pr

wangxin commented May 16, 2019 •

edited

Loading

Uh oh!

wangxin commented May 20, 2019

Uh oh!

Uh oh!

wangxin commented May 28, 2019

Uh oh!

neethajohn left a comment

Uh oh!

liat-grozovik Jun 2, 2019

Uh oh!

wangxin Jun 3, 2019

Uh oh!

liat-grozovik Jun 2, 2019

Uh oh!

wangxin Jun 3, 2019

Uh oh!

wangxin commented Jun 14, 2019

Uh oh!

wangxin commented Jun 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		return res


		def test_check_sfp_status_and_configure_sfp(localhost, ansible_adhoc, testbed):

Conversation

wangxin commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

wangxin commented May 20, 2019

Uh oh!

Uh oh!

wangxin commented May 28, 2019

Uh oh!

neethajohn left a comment

Choose a reason for hiding this comment

Uh oh!

liat-grozovik Jun 2, 2019

Choose a reason for hiding this comment

Uh oh!

wangxin Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

liat-grozovik Jun 2, 2019

Choose a reason for hiding this comment

Uh oh!

wangxin Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

wangxin commented Jun 14, 2019

Uh oh!

wangxin commented Jun 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wangxin commented May 16, 2019 •

edited

Loading