Conversation
Stablize the test by adding pause after the route change Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
lguohan
approved these changes
Jun 11, 2019
stcheng
added a commit
to stcheng/sonic-mgmt
that referenced
this pull request
Jul 15, 2019
Stablize the test by adding pause after the route change Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
fraserg-arista
pushed a commit
to fraserg-arista/sonic-mgmt
that referenced
this pull request
Feb 24, 2026
…v6 topo (sonic-net#942) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: t0-isolated-v6-*: Downstream neighbors are servers connected to VLAN interface. Use DOWNSTREAM_DST_IP_VLAN as dest ips. IPv6 cases have been skipped for t0 since beginning, only fix it for v6 topos now. t1-isolated-v6-*: V6 topo files set ipv6_address_pattern: 2064:100:0::%02X%02X:%02X%02X:0/120. announce_routes.py uses the pattern to generate routes for PTF and pass them to VMs. If it is not set, default pattern 20%02X:%02X%02X:0:%02X::/64 is used. acl tests use hardcoded dest ip 20c0:a800::1 that is not covered by v6 topo pattern, so packets are forwarded with the default route to upstream VM. Fix it by changing dest ip for v6 topos, also add acl rules for these dest ips. With extra ACL rules for v6 topos, also increase timeout for check_rule_counters. Manual cherry pick of sonic-net#21760 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202412 - [x] 202505 ### Approach #### What is the motivation for this PR? test_acl.py [ipv6-ingress-uplink->downlink-*] cases failed on v6 topo #### How did you do it? Correct DOWNSTREAM_DST_IP for t0/t1-isolated-v6-*. topos, and add corresponding acl rules #### How did you verify/test it? Test passed on t0/t1-isolated-v6-*. topos #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> --------- Signed-off-by: markxiao <markxiao@arista.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[201911][thermal control] Backport changes from master branch (sonic-net#929) [201911][config] Support abbreviation (sonic-net#933) Add 'hw-management-generate-dump.sh' to 'show techsupport' command (sonic-net#934) [fwutil]: Update fwutil to v2.0.0.0. (sonic-net#942) Fixes bug for PFCWD feature parameters (sonic-net#838) Fixed fast-reboot for BFN platform (sonic-net#871) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) [warm-reboot]: added pre-check for ISSU file (sonic-net#915) [config] Don't attempt to restart disabled services (sonic-net#944)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stablize the test by adding pause after the route change
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com