[plugins/connection/switch] Use timeout from args rather than hard coded value#838
Merged
lguohan merged 2 commits intosonic-net:masterfrom Mar 22, 2019
wangxin:connection-switch-pr
Merged
[plugins/connection/switch] Use timeout from args rather than hard coded value#838lguohan merged 2 commits intosonic-net:masterfrom wangxin:connection-switch-pr
lguohan merged 2 commits intosonic-net:masterfrom
wangxin:connection-switch-pr
Conversation
added 2 commits
March 22, 2019 16:29
The connection plugin 'switch' uses hard coded timeout value 60s for establishing SSH connection to target. After connection is spawned, then the timeout value for matching expected output is set to value passed in from keyword arguments. In practice, sometimes the hard coded 60s timeout is not enough for establishing SSH connection to targets. This improvement is to use value passed in from keyword arguments for connection timeout. Since the pexpect lib uses the same timeout value for establishing SSH connection and matching expected output, there is no need to set timeout for spawned connection in later code. Signed-off-by: Xin Wang <xinw@mellanox.com>
* Replace hard coded SSH ConnectionTimeout with value from args too Signed-off-by: Xin Wang <xinw@mellanox.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[201911][thermal control] Backport changes from master branch (sonic-net#929) [201911][config] Support abbreviation (sonic-net#933) Add 'hw-management-generate-dump.sh' to 'show techsupport' command (sonic-net#934) [fwutil]: Update fwutil to v2.0.0.0. (sonic-net#942) Fixes bug for PFCWD feature parameters (sonic-net#838) Fixed fast-reboot for BFN platform (sonic-net#871) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) [warm-reboot]: added pre-check for ISSU file (sonic-net#915) [config] Don't attempt to restart disabled services (sonic-net#944)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Replace hard coded timeout values with value passed in from arguments. When no timeout argument is passed in, use default 60s.
How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Documentation