[fdb] Improve robustness of checking PTF PID after config reload#929
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Jun 20, 2019
wangxin:fdb-ptf-pid-pr
Merged
[fdb] Improve robustness of checking PTF PID after config reload#929qiluo-msft merged 1 commit intosonic-net:masterfrom wangxin:fdb-ptf-pid-pr
qiluo-msft merged 1 commit intosonic-net:masterfrom
wangxin:fdb-ptf-pid-pr
Conversation
In case the config reload operation takes longer than the PTF script's running time, checking PTF script PID after config reload may fail. This change is to improve the robustness of checking PTF script PID after config reload. Signed-off-by: Xin Wang <[email protected]>
fraserg-arista
pushed a commit
to fraserg-arista/sonic-mgmt
that referenced
this pull request
Feb 24, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> 1. xfail the following cases due to sonic-net#21571 ``` test_custom_acl_table.py, test_ipv4_arp, test_drop_counters.py test_route_flap.py ``` 2. xfail the following cases due to sonic-net/sonic-buildimage#24537 ``` test_secure_upgrade, test_bgp_speaker.py test_ipv4_arp test_default_route_set_src test_static_route and test_static_route_ecmp ``` ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? Xfail some tests on the scale topo #### How did you do it? Add the tests to the xfail list #### How did you verify/test it? Run the tess on the scale topo #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[201911][thermal control] Backport changes from master branch (sonic-net#929) [201911][config] Support abbreviation (sonic-net#933) Add 'hw-management-generate-dump.sh' to 'show techsupport' command (sonic-net#934) [fwutil]: Update fwutil to v2.0.0.0. (sonic-net#942) Fixes bug for PFCWD feature parameters (sonic-net#838) Fixed fast-reboot for BFN platform (sonic-net#871) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) [warm-reboot]: added pre-check for ISSU file (sonic-net#915) [config] Don't attempt to restart disabled services (sonic-net#944)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
In case the config reload operation takes longer than the PTF
script's running time, checking PTF script PID after config reload
may fail. This change is to improve the robustness of checking
PTF script PID after config reload.
Type of change
Approach
How did you do it?
Add "ignore_errors: yes" for the step checking PTF PID after config reload. If a PTF PID is found, then wait for the PTF script to complete running.
How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
At this point, it is Mellanox specific change.
Supported testbed topology if it's a new test case?
Documentation