[port-toggle.yml] Correct the commmand for shutdown/startup interface#748
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 31, 2018
wangxin:master
Merged
[port-toggle.yml] Correct the commmand for shutdown/startup interface#748lguohan merged 1 commit intosonic-net:masterfrom wangxin:master
lguohan merged 1 commit intosonic-net:masterfrom
wangxin:master
Conversation
stcheng
approved these changes
Dec 6, 2018
Contributor
|
thanks for fixing this |
Collaborator
Author
|
We plan to run this script in our daily regression. Without this fix, this script won't work. Could you please merge this at your earliest convenience? |
Signed-off-by: Xin Wang <xinw@mellanox.com>
Collaborator
Author
|
I accidentally closed this PR by a force-push. Now reopen this PR with the same code change. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…onic-net#14169) swss: * 2447754 2023-02-23 | Do not allow to add port to .1Q bridge while router port deletion is not completed (sonic-net#2669) (HEAD -> 202205) [Lior Avramov] * 641c65c 2023-03-07 | [bfdorch] add default TOS value for BFD session (sonic-net#2689) (HEAD -> 202205) [Baorong Liu] * 95d3f6d 2023-03-08 | [ACL] Write ACL table/rule creation status into STATE_DB (sonic-net#2662) [bingwang-ms] swss-common: * 1fdeb9e 2023-03-03 | Define ACL_TABLE and ACL_RULE table in STATE_DB (sonic-net#748) (HEAD -> 202205, github/202205) [bingwang-ms] platform-common: * c441bd7 2023-03-07 | [sonic_ssd] Nokia-7215: Fix "show platform ssdhealth" (sonic-net#337) (HEAD -> 202205) [Pavan-Nokia] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
To include following changes: - [teammgrd]: Add retry logic for starting port channel with teamd (sonic-net#756) - [portsorch] fix bug in initializePort (sonic-net#753) - [intfmgrd] Fix intfmgrd hanging untill first interface becomes ready (sonic-net#748) - [intfmgrd]: Support loopback (sonic-net#742) -Improve comments for neighbor warmrestart related functions and warmRestartAssist class (sonic-net#740) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xin Wang xinw@mellanox.com
Description of PR
The syntax of CLI commands for shutting down and bringing up interfaces is wrong.
Changed commands from:
config interface shutdown <interface_name>
config interface startup <interface_name>
to:
config interface <interface_name> shutdown
config interface <interface_name> startup
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Changed the command syntax in port-toggle.yml file
How did you verify/test it?
Test run the script on multiple topologies of Mellanox SONiC platforms. The script passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation