Skip to content

Move location of template file used by test_bgp_speaker#2491

Merged
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:bgp-speaker-template-location
Nov 10, 2020
Merged

Move location of template file used by test_bgp_speaker#2491
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:bgp-speaker-template-location

Conversation

@wangxin
Copy link
Collaborator

@wangxin wangxin commented Nov 9, 2020

Description of PR

Summary:
Fixes # (issue)
Move location of template file used by tests/bgp/test_bgp_speaker.py from tests/bgp_speaker/ to tests/bgp/templates.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Template file tests/bgp_speaker/bgp_speaker_route.j2 is only used by
script tests/bgp/test_bgp_speaker.py. What's more, it is also the only
file under folder tests/bgp_speaker. It would be better to put test scripts
and their dependent template files together.

How did you do it?

This change moves file tests/bgp_speaker/bgp_speaker_route.j2 to tests/bgp/templates.

How did you verify/test it?

Test run tests/bgp/test_bgp_speaker.py, all the cases passed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Template file tests/bgp_speaker/bgp_speaker_route.j2 is only used by
script tests/bgp/test_bgp_speaker.py. What's more, it is also the only
file under folder tests/bgp_speaker. It would be better to put test scripts
and their dependent template files together. This change moves file
tests/bgp_speaker/bgp_speaker_route.j2 to tests/bgp/templates.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
@wangxin wangxin requested a review from a team November 9, 2020 09:40
Copy link
Collaborator

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxin wangxin merged commit 798bc2e into sonic-net:master Nov 10, 2020
@wangxin wangxin deleted the bgp-speaker-template-location branch November 30, 2020 09:57
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
utilities:
* 4b7335f 2022-11-29 | Add db_migrator_constants.py script to setup.py (sonic-net#2534) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* 8a78cf4 2022-11-23 | Port 202012 DB migration changes to newer branches (sonic-net#2515) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* 0157086 2022-11-22 | [VXLAN]Fixing traceback in show remotemac when mac moves during command execution (sonic-net#2506) [Sudharsan Dhamal Gopalarathnam]
* 1f26c8c 2022-11-17 | avoid printing error if no neighbors are present (sonic-net#2502) [arlakshm]
* 2573aae 2022-11-19 | [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) [Junchao-Mellanox]
* 1d96b55 2022-11-10 | [show][muxcable] Catch port Value error exception (sonic-net#2076) (sonic-net#2486) [Isabella de Leon]
* 6ed2afb 2022-11-09 | bugfix[2024] vnet route check exit code fix. (sonic-net#2480) [siqbal1986]
* d8c49dc 2022-11-17 | Fixed SONIC_CLI_IFACE_MODE=alias show ip|ipv6 route output in default mode issue (sonic-net#2422) [Marty Y. Lok]
* 166739e 2022-11-11 | Accept 0 for queue and dscp (sonic-net#2494) (github/202205) [bingwang-ms]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-net#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b157b5083a5ba59fb2cfc2ae2a61779549.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants