test bgp facts - skip for supervisor card in a SONiC chassis#2509
Merged
wangxin merged 3 commits intosonic-net:masterfrom Nov 17, 2020
Merged
test bgp facts - skip for supervisor card in a SONiC chassis#2509wangxin merged 3 commits intosonic-net:masterfrom
wangxin merged 3 commits intosonic-net:masterfrom
Conversation
wangxin
reviewed
Nov 13, 2020
- check if duthost is a 'supervisor' card based on the 'type' defined in host vars in the inventory. - if 'type' is defined and is 'supervisor', then skip the test
…ts and using is_supervisor_node in test_bgp_facts. This is per review comment
sanmalho-git
force-pushed
the
test_bgp_facts
branch
from
24c3626 to
693885b
Compare
wangxin
approved these changes
Nov 17, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326) dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) Signed-off-by: Stephen Sun <[email protected]> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) 510d330 Fix typo in xcvrd (sonic-net#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308) 4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298) 3622aac Remove shell=True (sonic-net#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) 4b3b238 Install libyang to azure pipeline (sonic-net#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287) Signed-off-by: Stephen Sun <[email protected]> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304) f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294) Signed-off-by: Stephen Sun <[email protected]> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b157b5083a5ba59fb2cfc2ae2a61779549. Signed-off-by: Stephen Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
In a SONiC chassis, we have 'supervisor' cards (control cards) that are not running 'bgp' dockers.
If we use the multi-DUT approach, we are including the 'supervisor' card as well in the list of DUTs. Thus, test_bgp_facts gets run on 'supervisor' card as well.
We need to skip the test when duthost is a 'supervisor' card.
How did you do it?
A card is identified as a 'supervisor' card, if it has a 'type' field in its host vars in the ansible inventory that is set to 'supervisor'.
We use this check to figure out if the test is to be skipped.
How did you verify/test it?
Ran test_bgp_facts against a SONiC chassis with two linecards (board1, board2) and a supervisor card (supervisor1). Results summary below:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation