[cont_link_flap] address issue in fixture bring_up_fanout_interfaces#2481
Merged
yxieca merged 2 commits intosonic-net:masterfrom Nov 6, 2020
Merged
[cont_link_flap] address issue in fixture bring_up_fanout_interfaces#2481yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Fixture mistaenly uses all_ports enumerator, which causes test_cont_link_flap itself being parameterized with all available ports on DUT. So the test was executed N times instead of once. Where N is number of ports. Also the warning in candidate builder is intended to give warning when port enumeration failed. Add another explicit value to get all ports without triggering the warning. Signed-off-by: Ying Xie <[email protected]>
|
This pull request introduces 1 alert when merging 6c93f32 into 6571830 - view on LGTM.com new alerts:
|
daall
approved these changes
Nov 6, 2020
Contributor
daall
left a comment
daall
left a comment
There was a problem hiding this comment.
Some nits + 1 quick question, feel free to address in a follow-up PR.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-swss submodule pointer to include the following: * 08711a8 [orchdaemon]: Fixed sairedis record file rotation ([sonic-net#2481](sonic-net/sonic-swss#2481)) Signed-off-by: dprital <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326) dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) Signed-off-by: Stephen Sun <[email protected]> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) 510d330 Fix typo in xcvrd (sonic-net#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308) 4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298) 3622aac Remove shell=True (sonic-net#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) 4b3b238 Install libyang to azure pipeline (sonic-net#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287) Signed-off-by: Stephen Sun <[email protected]> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304) f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294) Signed-off-by: Stephen Sun <[email protected]> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b157b5083a5ba59fb2cfc2ae2a61779549. Signed-off-by: Stephen Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Type of change
Approach
What is the motivation for this PR?
test_cont_link_flap was executed N times, where N is number of ports of the testbed.
How did you do it?
Fixture mistaenly uses all_ports enumerator, which causes test_cont_link_flap itself being parameterized with all available ports on DUT. So the test was executed N times instead of once. Where N is number of ports.
Also the warning in candidate builder is intended to give warning when port enumeration failed. Add another explicit value to get all ports without triggering the warning.
Signed-off-by: Ying Xie [email protected]
How did you verify/test it?
Run link flap tests.
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /var/src/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, forked-1.3.0, xdist-1.28.0, html-1.22.1, repeat-0.8.0, metadata-1.10.0
collected 69 items
platform_tests/link_flap/test_cont_link_flap.py::TestContLinkFlap::test_cont_link_flap Loading callback plugin json of type stdout, v2.0 from /usr/local/lib/python2.7/dist-packages/ansible/plugins/callback/json.pyc
Loading callback plugin json of type stdout, v2.0 from /usr/local/lib/python2.7/dist-packages/ansible/plugins/callback/json.pyc
FAILED [ 1%]Loading callback plugin json of type stdout, v2.0 from /usr/local/lib/python2.7/dist-packages/ansible/plugins/callback/json.pyc
Loading callback plugin json of type stdout, v2.0 from /usr/local/lib/python2.7/dist-packages/ansible/plugins/callback/json.pyc
platform_tests/link_flap/test_cont_link_flap.py::TestContLinkFlap::test_cont_link_flap ERROR [ 1%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet8] PASSED [ 2%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet0] SKIPPED [ 4%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet4] PASSED [ 5%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet108] SKIPPED [ 7%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet100] SKIPPED [ 8%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet104] SKIPPED [ 10%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet68] PASSED [ 11%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet96] PASSED [ 13%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet124] PASSED [ 14%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet92] PASSED [ 15%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet120] PASSED [ 17%]
platform_tests/link_flap/test_link_flap.py::test_link_flap[str2-7050cx3-acs-06|Ethernet56] PASSED