[enumerators] unify naming convention of the parameter enumerators#2494
Merged
yxieca merged 3 commits intosonic-net:masterfrom Nov 10, 2020
Merged
[enumerators] unify naming convention of the parameter enumerators#2494yxieca merged 3 commits intosonic-net:masterfrom
yxieca merged 3 commits intosonic-net:masterfrom
Conversation
- Prefix enumerators with enum_ when the parameter is enumerating all applicable entities. - Prefix enumerators with rand_ when the parameter is randomly select some applicable entities. - Introduce rand_one_dut_hostname to enumerate one randomly chosen dut hostname. Signed-off-by: Ying Xie <[email protected]>
Collaborator
Author
|
retest vsimage please |
wangxin
approved these changes
Nov 10, 2020
3 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
utilities: * 4b7335f 2022-11-29 | Add db_migrator_constants.py script to setup.py (sonic-net#2534) (HEAD -> 202205) [Vaibhav Hemant Dixit] * 8a78cf4 2022-11-23 | Port 202012 DB migration changes to newer branches (sonic-net#2515) (HEAD -> 202205) [Vaibhav Hemant Dixit] * 0157086 2022-11-22 | [VXLAN]Fixing traceback in show remotemac when mac moves during command execution (sonic-net#2506) [Sudharsan Dhamal Gopalarathnam] * 1f26c8c 2022-11-17 | avoid printing error if no neighbors are present (sonic-net#2502) [arlakshm] * 2573aae 2022-11-19 | [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) [Junchao-Mellanox] * 1d96b55 2022-11-10 | [show][muxcable] Catch port Value error exception (sonic-net#2076) (sonic-net#2486) [Isabella de Leon] * 6ed2afb 2022-11-09 | bugfix[2024] vnet route check exit code fix. (sonic-net#2480) [siqbal1986] * d8c49dc 2022-11-17 | Fixed SONIC_CLI_IFACE_MODE=alias show ip|ipv6 route output in default mode issue (sonic-net#2422) [Marty Y. Lok] * 166739e 2022-11-11 | Accept 0 for queue and dscp (sonic-net#2494) (github/202205) [bingwang-ms] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: unify naming convention of the parameter enumerators.
Type of change
Approach
What is the motivation for this PR?
Due the the ambiguity of parameter enumerators, some testcase has been written with unintended enumeration. Which causes the testcase being executed many times during nightly test.
How did you do it?
Signed-off-by: Ying Xie [email protected]
How did you verify/test it?
Tested against test_link_flap, test_lag_2, test_pretest, test_posttest, and test_interfaces.
Tested the new enumerator rand_one_dut_hostname with instrumented code.
All above tests passed.