[Bugfix][QoS] Add port index fix for t0 backend#12358
Merged
yxieca merged 1 commit intosonic-net:masterfrom Apr 9, 2024
Merged
[Bugfix][QoS] Add port index fix for t0 backend#12358yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
add port index fix for t0 backend
developfast
changed the title
neethajohn
approved these changes
Apr 9, 2024
Contributor
Author
|
@yxieca can you pls help merge? |
Contributor
|
@StormLiangMS, please help with the cherry-pick |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Apr 25, 2024
add port index fix for t0 backend
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Apr 25, 2024
add port index fix for t0 backend
Collaborator
|
Cherry-pick PR to 202311: #12592 |
Collaborator
|
Cherry-pick PR to 202205: #12593 |
This was referenced Apr 25, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Apr 25, 2024
add port index fix for t0 backend
Collaborator
|
Cherry-pick PR to 202305: #12594 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Apr 26, 2024
add port index fix for t0 backend
mssonicbld
pushed a commit
that referenced
this pull request
Apr 26, 2024
add port index fix for t0 backend
mssonicbld
pushed a commit
that referenced
this pull request
Apr 26, 2024
add port index fix for t0 backend
mssonicbld
added
Included in 202305 branch
Included in 202205 branch
and removed
Created PR to 202305 branch
labels
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202205 branch
Created PR to 202311 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Port indexing error was occurring on backend T0 devices since the test port IDs (based off of regular VLAN ports) are set before the port IPs which are vlan subinterfaces. Therefore, the port IDs need to be updated after the appropriate port IPs are set.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
bugfix for qos sai backend t0 test
How did you do it?
update the correct port IDs to match port IPs
How did you verify/test it?
tested on backend + frontend testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation