[test_feature] Fix test_show_features

[bingwang-ms]

Description of PR

Summary:
Fixes # (issue)
The code used for parsing redis output is not robust enough. As a result, the result is incorrect if the order for output of redis-cli is changed. This commit addressed the issue.

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to address issue for parsing output of redis-cli to get feature enable status.

How did you do it?

Update the method to retrieve state from redis.

How did you verify/test it?

Verified on both Arista-7260 and Celestica-DX010

py.test --inventory ../ansible/str,../ansible/veos --host-pattern str-7260cx3-acs-2 --module-path ../ansible --testbed vms7-t0-7260-2 --testbed_file ../ansible/testbed.csv --junit-xml=tr.xml --log-cli-level warn --collect_techsupport=False --topology=t0,any,util test_features.py
========================================================================================= test session starts =========================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
metadata: {'Python': '2.7.12', 'Platform': 'Linux-4.10.0-42-generic-x86_64-with-Ubuntu-16.04-xenial', 'Packages': {'py': '1.9.0', 'pytest': '4.6.5', 'pluggy': '0.13.1'}, 'Plugins': {u'repeat': u'0.8.0', u'html': u'1.22.1', u'xdist': u'1.28.0', u'ansible': u'2.2.2', u'forked': u'1.3.0', u'metadata': u'1.10.0'}}
ansible: 2.8.12
rootdir: /data/Networking-acs-sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, forked-1.3.0, xdist-1.28.0, html-1.22.1, repeat-0.8.0, metadata-1.10.0
collected 1 item                                                                                                                                                                                      

test_features.py::test_show_features PASSED                                                                                                                                                     [100%]

------------------------------------------------------------------ generated xml file: /data/Networking-acs-sonic-mgmt/tests/tr.xml -------------------------------------------------------------------
====================================================================================== 1 passed in 19.58 seconds ======================================================================================

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

No.

[wangxin]

The redis_value will have double quote, the comparison will fail.

admin@str-msn2700-02:~$ /usr/bin/redis-cli -n 4 hget "FEATURE|teamd" "state"
"enabled"
admin@str-msn2700-02:~$ /usr/bin/redis-cli -n 4 --raw hget "FEATURE|teamd" "state"
enabled

Suggest to add --raw option for the redis-cli command.

[bingwang-ms]

Thanks. Updated.

[neethajohn]

use pytest_assert

[bingwang-ms]

Thanks. Updated.