Update the static dns test case#11652
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 16, 2024
Merged
Conversation
When do the dhclient, if not specify the management port, it will also do dhclient other port,and may cause some error msg. To avoid this, need to specify the management port when do the dhclient, and kill the deamon after the test finish.
Collaborator
|
@oleksandrivantsiv please review and confirm this is fixes the issue seen on master |
oleksandrivantsiv
approved these changes
Feb 12, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 22, 2024
When do the dhclient, if not specify the management port, it will also do dhclient other port,and may cause some error msg. To avoid this, need to specify the management port when do the dhclient, and kill the deamon after the test finish.
Collaborator
|
Cherry-pick PR to 202311: #11751 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 22, 2024
When do the dhclient, if not specify the management port, it will also do dhclient other port,and may cause some error msg. To avoid this, need to specify the management port when do the dhclient, and kill the deamon after the test finish.
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
byu343
reviewed
Feb 23, 2024
| def stop_dhclient(duthost): | ||
| yield | ||
|
|
||
| if os.path.exists(DHCLIENT_PID_FILE): |
Contributor
There was a problem hiding this comment.
@yxieca It is found by @Staphylo that this check runs on the test server, but should be on the DUT, which will make the cleanup of dhclient still not happen. This PR lets dhclient only started for MGMT_PORT which was also including many front panel ports before this PR; it can fix the original issue. @nhe-NV Still, can you please further fix the cleanup of the dhclient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #11681
When do the dhclient, if not specify the management port, it will also do dhclient other port,and may cause some error msg. To avoid this, need to specify the management port when do the dhclient, and kill the deamon after the test finish.
Description of PR
Summary: To make the test could pass without any err msg
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation