Skip to content

[copp]: Add UDLD test in COPP test suite#607

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:udld
Jan 20, 2019
Merged

[copp]: Add UDLD test in COPP test suite#607
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:udld

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented May 10, 2018

https://tools.ietf.org/html/rfc5171

The UDLD protocol runs on top of the LLC sub-layer of the data link
layer of the OSI model. It uses a specially assigned multicast
destination MAC address 01-00-0C-CC-CC-CC.

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

@stcheng
Copy link
Contributor Author

stcheng commented May 10, 2018 

ok: [str-s6000-on-2] => {
    "out.stdout_lines": [
        "WARNING: Failed to execute tcpdump. Check it is installed and in the PATH",
        "WARNING: No route found for IPv6 destination :: (no default route?)",
        "copp_tests.UDLDTest ... ok",
        "",
        "----------------------------------------------------------------------",
        "Ran 1 test in 42.613s",
        "",
        "OK",
        "2018-05-10 23:38:23 : UDLDTest",
        "2018-05-10 23:39:06 : ",
        "2018-05-10 23:39:06 : Sent through NN to local ptf_nn_agent:    100000",
        "2018-05-10 23:39:06 : Sent through If to remote ptf_nn_agent:   100000",
        "2018-05-10 23:39:06 : Recv from If on remote ptf_nn_agent:      99159",
        "2018-05-10 23:39:06 : Recv from NN on from remote ptf_nn_agent: 99159",
        "2018-05-10 23:39:06 : ",
        "2018-05-10 23:39:06 : test stats",
        "2018-05-10 23:39:06 : Packet sent =     100000",
        "2018-05-10 23:39:06 : Packet rcvd =      99155",
        "2018-05-10 23:39:06 : Test time = 0:00:25.310992",
        "2018-05-10 23:39:06 : TX PPS = 3951",
        "2018-05-10 23:39:06 : RX PPS = 3917",
        "2018-05-10 23:39:06 : ",
        "2018-05-10 23:39:06 : Checking constraints (NoPolicy):",
        "2018-05-10 23:39:06 : rx_pps (3917) > NO_POLICER_LIMIT (840): True",
        "2018-05-10 23:39:06 : total_rcv_pkt_cnt (99155) > pkt_rx_limit (90000): True"
    ]
}

@stcheng stcheng mentioned this pull request May 10, 2018
Merged
@stcheng stcheng requested a review from maggiemsft May 10, 2018 23:52
zhenggen-xu
zhenggen-xu reviewed May 11, 2018
View reviewed changes
ansible/roles/test/files/ptftests/copp_tests.py Outdated
Copy link

@zhenggen-xu zhenggen-xu May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this real eth_type or we don't need this at all?

Copy link
Contributor Author

@stcheng stcheng May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the real eth_type. since UDLD is using IEEE 802.3, this is the length of the frame.

Copy link
Contributor Author

@stcheng stcheng May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd better leave some comments here 💬

Copy link

@zhenggen-xu zhenggen-xu May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if IEEE 802.3 is not supported, can you add a comment here in the code for the eth_type meaning?

Copy link
Contributor Author

@stcheng stcheng May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i have added the comments. please check.

@stcheng
[copp]: Add UDLD test in COPP test suite
ab2cac5 
https://tools.ietf.org/html/rfc5171

The UDLD protocol runs on top of the LLC sub-layer of the data link
layer of the OSI model. It uses a specially assigned multicast
destination MAC address 01-00-0C-CC-CC-CC.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@stcheng stcheng merged commit ea45432 into sonic-net:master Jan 20, 2019
@stcheng stcheng deleted the udld branch January 20, 2019 03:41
@yxieca
Copy link
Collaborator

yxieca commented Jan 22, 2019 •
edited
Loading

made to 201811 branch on 1/22/2019

sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Aug 2, 2025
@mssonicbld
[action] [PR:18854] Stabilize the crm test (sonic-net#607)
a1a0842 
The fixture crm_resources is auto use fixture, in it, it will check the crm resources, the timeout of checking the crm resource is 90s, if there is a config reload did before the test, and since the default crm polling interval is 360s, so the 90s timeout is not enough, actually, there is another auto use fixture set_polling_interval which is also module level, in it, the crm polling interval will be changed to 1s, but it is called after the crm_resources, change the set_polling_interval always called before the crm_resources, then even if there is config reload did before this test, 90s timeout is enough to get the crm resources.

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary: The fixture crm_resources is new added in sonic-net#18465.
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202205][linkmgrd][utilities][swss][swss-common][sairedis][platform-d…
e8fe21b 
…aemon] advance submodule head (sonic-net#11652)

linkmgrd:
* 17240f1 2022-08-02 | [active-active] Update unhealthy label definition (sonic-net#102) (HEAD -> 202205, github/202205) [Jing Zhang]
* 99a7b4b 2022-07-28 | Update the definition of healthy label (sonic-net#99) [Jing Zhang]
* 551144b 2022-08-08 | [Active-Standby]Remove unnecessary `handleMuxWaitTimeout` logs (sonic-net#100) [Jing Zhang]

utilities:
* 8cbbe4f 2022-08-08 | [crm] add checking for CRM interval range (sonic-net#2293) (HEAD -> 202205, github/202205) [Andriy Yurkiv]
* 7dac7a7 2022-08-03 | Fix version in db_migrator  for `PORT_QOS_MAP|global` (#2289) [bingwang-ms]
* e14f0c9 2022-08-03 | Add override testcase to verify removal (#2288) [jingwenxie]
* 61ea21d 2022-07-29 | [watermarkstat] Fix CLI script for unconfigured PG counters (sonic-net#2239) [Nazarii Hnydyn]
* e206e2d 2022-05-19 | [portconfig] Allow to configure interface mtu for physical ports only [Sudharsan Dhamal Gopalarathnam]
* 9751479 2022-08-01 | Transfer organization from Azure to sonic-net (sonic-net#2285) [Liu Shilong]
* 218b175 2022-07-29 | [202205][counters] Keep counters cache in a single directory (sonic-net#2280) [Stepan Blyshchak]

swss:
* d772a70 2022-08-09 | [muxorch] return true if the nbr IP is in the skip_neighbors list (sonic-net#2407) (HEAD -> 202205) [Nikola Dancejic]
* a3ac275 2022-08-08 | [EVPN]Modified tunnel creation logic when creating tunnel in VRF-VNI map creation flow (sonic-net#2404) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam]
* 67c1376 2022-08-09 | [QoS] Fix issue: the WRED profile can not be set if current min > new max or current max < new min (sonic-net#2379) [Stephen Sun]
* 0295a35 2022-07-21 | [Buffer Orch] Support removing buffer port profile list (sonic-net#2371) [Stephen Sun]
* 450e9ec 2022-07-07 | Fix: missing sonic-db-cli in docker-sonic-vs image (sonic-net#2357) [Qi Luo]
* c1c1147 2022-06-02 | Purge package sonic-db-cli which depends on libswsscommon (sonic-net#2308) [Qi Luo]

swss-common:
* 749cd6f 2022-07-21 | Fix PING database command not backward compatible with python version issue. (sonic-net#650) (HEAD -> 202205) [Hua Liu]
* 4fa7484 2022-06-27 | Fix: missing sonic-db-cli in docker-sonic-vs image (sonic-net#640) [Qi Luo]
* 4d0dc7a 2022-06-23 | [sonic-cli] Fix sonic-db-cli output format not backward compatible with python version issue. (sonic-net#631) [Hua Liu]
* c5573fe 2022-06-03 | Purge package sonic-db-cli which depends on libswsscommon (sonic-net#628) [Qi Luo]
* 0ade483 2022-08-02 | Add docker-mux related table names  (sonic-net#627) [Jing Zhang]
* 675d793 2022-05-26 | Re-write sonic-db-cli with c++ for sonic startup performance issue (sonic-net#607) [Hua Liu]
* 1155773 2022-08-01 | Transfer organization from Azure to sonic-net (sonic-net#661) (github/202205) [Liu Shilong]

sairedis:
* c62a453 2022-06-03 | Purge package sonic-db-cli which depends on libswsscommon (sonic-net#1057) (HEAD -> 202205) [Qi Luo]
* 8be9292 2022-07-20 | [syncd] Remove error message when tryTranslateVidToRid fails (sonic-net#1048) [Kamil Cudnik]
* eb552ee 2022-08-01 | Transfer organization from Azure to sonic-net (sonic-net#1099) (github/202205) [Liu Shilong]

platform-daemon:
* d150229 2022-08-11 | Correct the peer forwarding state table (sonic-net#281) (HEAD -> 202205) [Longxiang Lyu]
* 9507e6c 2022-08-10 | [ycabled] remove some spurious logs (sonic-net#282) (HEAD -> 202205) [vdahiya12]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[201811][utilities][swss] advance sub module head (sonic-net#3383)
60b2e54 
Submodule src/sonic-utilities 7460f5c..4f72e14:
  > [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (sonic-net#607)
  > [neighbor advertiser] try getting vlan addresses from o.s first (sonic-net#613)
  > [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (sonic-net#612)

Submodule src/sonic-swss 384c21e..46bc1f4:
  > [portsyncd]: Add default catch block in portsyncd (sonic-net#1033)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maggiemsft maggiemsft Awaiting requested review from maggiemsft

2 more reviewers

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

@zhenggen-xu zhenggen-xu zhenggen-xu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Included in 201811 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stcheng @yxieca @pavel-shirshov @zhenggen-xu