Skip to content

[test_feature] Fix test_show_features #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bingwang-ms merged 3 commits into from
Sep 30, 2020
Merged

[test_feature] Fix test_show_features #2285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13d2daa
Fix test_show_features
bingwang-ms Sep 29, 2020
c8c9257
add -raw in redis-cli command line
bingwang-ms Sep 29, 2020
d2789bb
use pytest_assert
bingwang-ms Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions tests/test_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,6 @@
pytest.mark.topology('any')
]

def get_status_redisout(status_out):
"""Extract status value for feature in redis
"""
status_list = status_out[1:]
status = ""
for s in status_list:
status = s.encode('UTF-8')
return status

# Test Functions
def test_show_features(duthost):
"""Verify show features command output against CONFIG_DB
Expand All @@ -23,7 +14,5 @@ def test_show_features(duthost):
pytest_assert(succeeded, "failed to obtain feature status")
for cmd_key, cmd_value in features_dict.items():
feature = str(cmd_key)
status_out = duthost.shell('/usr/bin/redis-cli -n 4 hgetall "FEATURE|{}"'.format(feature), module_ignore_errors=False)['stdout_lines']
redis_value = get_status_redisout(status_out)
status_value_expected = str(cmd_value)
assert str(redis_value) == status_value_expected, "'{}' is '{}' which does not match with config_db".format(cmd_key, cmd_value)
redis_value = duthost.shell('/usr/bin/redis-cli -n 4 --raw hget "FEATURE|{}" "state"'.format(feature), module_ignore_errors=False)['stdout']
pytest_assert(redis_value.lower() == cmd_value.lower(), "'{}' is '{}' which does not match with config_db".format(cmd_key, cmd_value))