[202511] Fix duplicate key 'bgp/test_bgp_vnet.py' in tests_mark_conditions.yaml#22796
Merged
vmittal-msft merged 1 commit intosonic-net:202511from Mar 9, 2026
Merged
Conversation
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is identical to the first occurrence (lines 479-484). The duplicate key causes check-yaml pre-commit hook failures on all PRs that modify this file. This unblocks PRs sonic-net#22793, sonic-net#22779, sonic-net#22321, sonic-net#22112, sonic-net#22041, sonic-net#22006. Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
approved these changes
Mar 9, 2026
StormLiangMS
added a commit
to StormLiangMS/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
Cherry-pick of PR sonic-net#22775 to 202511, rebased on latest 202511 to include the duplicate key fix from PR sonic-net#22796. The test performs multiple config reloads that cause pmon start-limit-hit due to missing sonic.target symlinks after systemd-sonic-generator rework. Fix PRs: sonic-net/sonic-buildimage#25932, sonic-net/sonic-utilities#4314 Tracking issue: sonic-net/sonic-buildimage#25931 Signed-off-by: Storm Liang <stormliang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 10, 2026
StormLiangMS
added a commit
that referenced
this pull request
Mar 10, 2026
…fig (#22830) Cherry-pick of PR #22775 to 202511, rebased on latest 202511 to include the duplicate key fix from PR #22796. The test performs multiple config reloads that cause pmon start-limit-hit due to missing sonic.target symlinks after systemd-sonic-generator rework. Fix PRs: sonic-net/sonic-buildimage#25932, sonic-net/sonic-utilities#4314 Tracking issue: sonic-net/sonic-buildimage#25931 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicate
bgp/test_bgp_vnet.pyentry intests/common/plugins/conditional_mark/tests_mark_conditions.yaml. The key appeared twice (identical content), causing thecheck-yamlpre-commit hook to fail.Impact
This duplicate key is blocking the following open PRs targeting
202511:Change
Removed the second identical
bgp/test_bgp_vnet.pyblock (6 lines). No functional change.cc @vmittal-msft @liushilongbuaa