avoid GCU ECN test for currently unsupported Cisco platforms#22321
Closed
dcaugher wants to merge 1 commit intosonic-net:202511from
Closed
avoid GCU ECN test for currently unsupported Cisco platforms#22321dcaugher wants to merge 1 commit intosonic-net:202511from
dcaugher wants to merge 1 commit intosonic-net:202511from
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Dan Caugherty <[email protected]>
dcaugher
force-pushed
the
gcu-ecn-config-skip
branch
from
c2b2b55 to
18426cb
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Sorry for the PR confusion, this should be the one to review. Thanks. |
This was referenced Mar 8, 2026
Pterosaur
added a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 8, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is identical to the first occurrence (lines 479-484). The duplicate key causes check-yaml pre-commit hook failures on all PRs that modify this file. This unblocks PRs sonic-net#22793, sonic-net#22779, sonic-net#22321, sonic-net#22112, sonic-net#22041, sonic-net#22006. Signed-off-by: Ze Gan <[email protected]>
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 9, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is identical to the first occurrence (lines 479-484). The duplicate key causes check-yaml pre-commit hook failures on all PRs that modify this file. This unblocks PRs #22793, #22779, #22321, #22112, #22041, #22006. Signed-off-by: Ze Gan <[email protected]>
Collaborator
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@dcaugher please share master pr |
yxieca
approved these changes
Mar 18, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
vmittal-msft
approved these changes
Mar 23, 2026
Contributor
Author
|
Hmm, not sure how this managed to get here, but it shouldn't have. My apologies! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
WRED configuration for certain Cisco platforms (GR2, PAC) are not yet propagated to hardware or
to ASIC_DB. So for the time being, we are skipping tests that will always fail.
Type of change
Back port request
Approach
What is the motivation for this PR?
Allowing GCU tests to pass for the time being
How did you do it?
Determined that GR2 platforms don't support propagation correctly, omitted them
How did you verify/test it?
It's difficult to test something that doesn't happen.
Any platform specific information?
See the PR documentation and comments.
Supported testbed topology if it's a new test case?
Documentation