[action] [PR:21155] Support running acl tests without any IPv4 management configuration#22006
Open
mssonicbld wants to merge 1 commit intosonic-net:202511from
Open
[action] [PR:21155] Support running acl tests without any IPv4 management configuration#22006mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld wants to merge 1 commit intosonic-net:202511from
Conversation
…onic-net#21155) * Support running acl tests without any IPv4 management configuration. Signed-off-by: Will Rideout <wrideout@arista.com>
mssonicbld
requested review from
bingwang-ms,
wangxin and
yejianquan
as code owners
11 tasks
Collaborator
Author
|
Original PR: #21155 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
Contributor
|
/azp run |
|
Commenter does not have sufficient privileges for PR 22006 in repo sonic-net/sonic-mgmt |
Contributor
|
Failing checks are unrelated to changes. @yutongzhang-microsoft can someone kick this build? This has been sitting stuck for a while now. Alternatively, if someone wants to close this I'm happy to make a new PR for these changes and babysit it. |
Collaborator
|
/azp run |
|
Commenter does not have sufficient privileges for PR 22006 in repo sonic-net/sonic-mgmt |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Commenter does not have sufficient privileges for PR 22006 in repo sonic-net/sonic-mgmt |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 8, 2026
Pterosaur
added a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 8, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is identical to the first occurrence (lines 479-484). The duplicate key causes check-yaml pre-commit hook failures on all PRs that modify this file. This unblocks PRs sonic-net#22793, sonic-net#22779, sonic-net#22321, sonic-net#22112, sonic-net#22041, sonic-net#22006. Signed-off-by: Ze Gan <ganze718@gmail.com>
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 9, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is identical to the first occurrence (lines 479-484). The duplicate key causes check-yaml pre-commit hook failures on all PRs that modify this file. This unblocks PRs #22793, #22779, #22321, #22112, #22041, #22006. Signed-off-by: Ze Gan <ganze718@gmail.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #18077
Modify the gratuitous arp service such that arp or neighbor-discovery packets are sent based on the L3 configuration of the testbed topology. For testbed topologies which do not configure IPv4 addressing, such as isolated-v6 testbeds, we skip the creation of arp packets and do not send them. In this case, only IPv6 neighbor-discovery packets are created and sent. The inverse is true as well when a testbed topology only specifies the use of IPv4 connections.
Type of change
Back port request
Approach
What is the motivation for this PR?
This change was made as a part of the isolated-v6 testbed qualification effort. Running acl tests on isolated-v6 testbeds was previously unsupported, and skipped via conditional mark, as the tests expected to receive IPv4 arp packets when no IPv4 connectivity was established.
How did you verify/test it?
The full suite of acl tests was run against a testbed where IPv4 and IPv6 connectivity was specified in the topology config, and no regressions were seen. The same suite of tests was run against a isolated-v6 testbed, and new test passes were observed: some new failures were also observed for tests which were previously skipped. However @r12f asked that we submit this change, and follow up with the remaining failing tests individually in subsequent changes as this change improves overall test coverage.
Any platform specific information?
None.