[action] [PR:22775] Add conditional skip for test_load_minigraph_with_golden_config#22793
Merged
mssonicbld merged 1 commit intosonic-net:202511from Mar 18, 2026
Merged
Conversation
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
6 tasks
Collaborator
Author
|
Original PR: #22775 |
Collaborator
Author
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 8, 2026
Pterosaur
added a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 8, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is identical to the first occurrence (lines 479-484). The duplicate key causes check-yaml pre-commit hook failures on all PRs that modify this file. This unblocks PRs sonic-net#22793, sonic-net#22779, sonic-net#22321, sonic-net#22112, sonic-net#22041, sonic-net#22006. Signed-off-by: Ze Gan <ganze718@gmail.com>
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 9, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is identical to the first occurrence (lines 479-484). The duplicate key causes check-yaml pre-commit hook failures on all PRs that modify this file. This unblocks PRs #22793, #22779, #22321, #22112, #22041, #22006. Signed-off-by: Ze Gan <ganze718@gmail.com>
Collaborator
|
This PR is failing Pre_test Static Analysis because its branch was created before PR #22796 merged on 202511. That PR fixed a duplicate YAML key (\�gp/test_bgp_vnet.py) in \ ests_mark_conditions.yaml, which causes the \check-yaml\ pre-commit hook to reject the file. I've raised a rebased replacement PR: #22830 (based on latest 202511 which includes the duplicate key fix). This PR can be closed once #22830 merges. |
Contributor
|
/azpw run |
Collaborator
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The test
override_config_table/test_override_config_table.py::test_load_minigraph_with_golden_configperforms 4 consecutiveconfig load_minigraphoperations. After the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340), container services like pmon are no longer listed assonic.targetdependencies, so their systemd start rate limit counters are never reset between reloads. This causes pmon to hitstart-limit-hiton the 4th reload, leaving pmon in a failed state that affects subsequent tests in the nightly run.Root cause issue: sonic-net/sonic-buildimage#25931
Fix PRs (in progress):
[Install] WantedBy=sonic.targetto 9 container service templates_reset_failed_services()to include reverse dependenciesHow I did it
Added a conditional skip entry in
tests_mark_conditions.yamlfortest_load_minigraph_with_golden_configlinked to issue sonic-net/sonic-buildimage#25931. The skip will automatically resolve (test re-enabled) when the issue is closed.How to verify it
The test will be skipped in nightly runs until the fix PRs are merged and issue #25931 is closed.
Which release branch to backport
Description for the changelog
Add conditional skip for test_load_minigraph_with_golden_config to prevent pmon start-limit-hit failures in nightly runs.