Add conditional skip for test_load_minigraph_with_golden_config#22775
Merged
wangxin merged 1 commit intosonic-net:masterfrom Mar 7, 2026
Merged
Conversation
Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com>
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
StormLiangMS
added
the
Request for 202511 branch
wangxin
approved these changes
Mar 7, 2026
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 7, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Collaborator
|
Cherry-pick PR to 202511: #22793 |
6 tasks
StormLiangMS
added a commit
to StormLiangMS/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
Cherry-pick of PR sonic-net#22775 to 202511, rebased on latest 202511 to include the duplicate key fix from PR sonic-net#22796. The test performs multiple config reloads that cause pmon start-limit-hit due to missing sonic.target symlinks after systemd-sonic-generator rework. Fix PRs: sonic-net/sonic-buildimage#25932, sonic-net/sonic-utilities#4314 Tracking issue: sonic-net/sonic-buildimage#25931 Signed-off-by: Storm Liang <stormliang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
StormLiangMS
added a commit
that referenced
this pull request
Mar 10, 2026
…fig (#22830) Cherry-pick of PR #22775 to 202511, rebased on latest 202511 to include the duplicate key fix from PR #22796. The test performs multiple config reloads that cause pmon start-limit-hit due to missing sonic.target symlinks after systemd-sonic-generator rework. Fix PRs: sonic-net/sonic-buildimage#25932, sonic-net/sonic-utilities#4314 Tracking issue: sonic-net/sonic-buildimage#25931 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com>
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 10, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com> Signed-off-by: Mihut Aronovici <aronovic@cisco.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Mar 16, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com> Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…c-net#22775) Skip test_load_minigraph_with_golden_config when issue #25931 is open. This test performs 4 consecutive config reloads which causes pmon to hit start-limit-hit due to missing sonic.target.wants/ symlinks after the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340). The test leaves pmon in a bad state (start-limit-hit), which can affect subsequent tests in the nightly run. Fix PRs: - sonic-net/sonic-buildimage#25932 (add [Install] to service templates) - sonic-net/sonic-utilities#4314 (fix _reset_failed_services) The skip will auto-resolve when sonic-net/sonic-buildimage#25931 is closed. Signed-off-by: Storm Liang <stormliang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The test
override_config_table/test_override_config_table.py::test_load_minigraph_with_golden_configperforms 4 consecutiveconfig load_minigraphoperations. After the systemd-sonic-generator rework (sonic-net/sonic-buildimage#23340), container services like pmon are no longer listed assonic.targetdependencies, so their systemd start rate limit counters are never reset between reloads. This causes pmon to hitstart-limit-hiton the 4th reload, leaving pmon in a failed state that affects subsequent tests in the nightly run.Root cause issue: sonic-net/sonic-buildimage#25931
Fix PRs (in progress):
[Install] WantedBy=sonic.targetto 9 container service templates_reset_failed_services()to include reverse dependenciesHow I did it
Added a conditional skip entry in
tests_mark_conditions.yamlfortest_load_minigraph_with_golden_configlinked to issue sonic-net/sonic-buildimage#25931. The skip will automatically resolve (test re-enabled) when the issue is closed.How to verify it
The test will be skipped in nightly runs until the fix PRs are merged and issue #25931 is closed.
Which release branch to backport
Description for the changelog
Add conditional skip for test_load_minigraph_with_golden_config to prevent pmon start-limit-hit failures in nightly runs.