GCU: skip ECN test for certain Cisco platforms#23213
Closed
dcaugher wants to merge 8 commits intosonic-net:masterfrom
Closed
GCU: skip ECN test for certain Cisco platforms#23213dcaugher wants to merge 8 commits intosonic-net:masterfrom
dcaugher wants to merge 8 commits intosonic-net:masterfrom
Conversation
GR2 (Graphene 2 / Lightning) ASIC platforms like Cisco-8122 do not support dynamic WRED configuration updates in the SAI layer. The SDK's sai_wred_manager_gr2.cpp has stub (no-op) implementations for WRED configuration functions such as set_sms_dequeue_cgmlevel_ecnmark_probability(). This causes CONFIG_DB changes to be accepted but never propagated to ASIC_DB, resulting in test failures with 'ASIC DB does not properly reflect newly configured field(s)' errors. Changes: - Add Cisco-8122-O128S2 and Cisco-8122-O64 HWSKUs to skip conditions - Add detailed comments explaining the SAI limitation - Add module docstring documenting platform support The existing skip for Cisco-8800-LC-48H-C48 (PAC ASIC) remains for similar reasons - PAC also lacks full dynamic WRED update support.
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
isabelmsft and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
12 tasks
Signed-off-by: Dan Caugherty <dcaugher@cisco.com>
Signed-off-by: Dan Caugherty <dcaugher@cisco.com>
dcaugher
force-pushed
the
gcu-ecn-config-skip
branch
from
5246c86 to
1e367e0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add skip conditions for Cisco 8000 GR2 ASIC platforms (Cisco-8122) to
test_ecn_config_updates. These platforms do not support dynamic WRED configuration updates in the SAI layer.Type of change
Back port request
Approach
What is the motivation for this PR?
The
test_ecn_config_updatestest validates that WRED profile changes in CONFIG_DB propagate correctly to ASIC_DB. On Cisco-8122 platforms (GR2 ASIC), dynamic WRED configuration updates are not implemented in the SAI layer. CONFIG_DB changes are accepted but don't propagate to ASIC_DB, causing the test to fail.The existing skip for Cisco-8800-LC-48H-C48 (PAC ASIC) has the same root cause.
How did you do it?
How did you verify/test it?
Verified test fails on Cisco-8122 platforms without this skip, and is correctly skipped after the change.
Any platform specific information?
Affects Cisco 8000 platforms with PAC or GR2 ASICs:
Other Cisco 8000 platforms (GB/GR ASICs like 8101, 8102, 8111) are supported.
Supported testbed topology if it's a new test case?
N/A
Documentation