Use the creds fixture to get username and password#1885
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jul 14, 2020
wangxin:replace-secret-group-vars
Merged
Use the creds fixture to get username and password#1885wangxin merged 1 commit intosonic-net:masterfrom wangxin:replace-secret-group-vars
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:replace-secret-group-vars
Conversation
The original code uses secrets['secret-group-vars'] to get username and password of DUT. This is not the standard way for getting credentials. This PR uses the `creds` fixture to get DUT username and password. Signed-off-by: Xin Wang <[email protected]>
tahmed-dev
approved these changes
Jul 13, 2020
yxieca
approved these changes
Jul 13, 2020
Collaborator
|
retest vsimage please |
3 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-swss commits 5fbd113 [Flex-counters] Fix the delay of flex counters flow to prevent infinite loop (sonic-net#1899) dc685b6 [portsorch] Add an extra check before setting oper speed to APPL_DB (sonic-net#1885) ceef728 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855) sonic-utilities commits 3160753 [ci]: Support PR coverage (sonic-net#1806) 3316fdb fix wrong code indent in sfputil (sonic-net#1808) c33e3a8 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) 4f7e107 [portconfig] Validate duplicate speed value and interface type value (sonic-net#1745) 59817e2 [warm-reboot] Add new preboot health check: verify database integrity (sonic-net#1785) bf2ff3c [portstat, intfstat] added rates and utilization (sonic-net#1750) 3bf962c [show][platform] Revise chassis info fallback to only fall back on pmon crash (sonic-net#1751)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The original code uses secrets['secret-group-vars'] to get username and password
of DUT. This is not the standard way for getting credentials. This PR uses the
credsfixture to get DUT username and password.
Type of change
Approach
What is the motivation for this PR?
The method for getting credential in test_wr_arp and advanced_reboot is not standard. Replace it with using the
credsfixture to get the username and password.How did you do it?
credsfixture.How did you verify/test it?
Test run
tests/arp/test_wr_arp.pyandtests/platform_tests/test_advanced_reboot.py.Any platform specific information?
No
Supported testbed topology if it's a new test case?
Documentation