[tests/conftest.py] Add parameter for collecting dump: "since yesterday"#1855
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jul 10, 2020
stephenxs:collect-dump-since-yesterday
Merged
[tests/conftest.py] Add parameter for collecting dump: "since yesterday"#1855wangxin merged 1 commit intosonic-net:masterfrom stephenxs:collect-dump-since-yesterday
wangxin merged 1 commit intosonic-net:masterfrom
stephenxs:collect-dump-since-yesterday
Conversation
sonic dump will be collected when a test case fail. However, it can be very time-consuming to collect dump in a switch with a lot of log files. To collect dump since yesterday prevents DUT from consuming too much time on it. Signed-off-by: Stephen Sun <[email protected]>
wangxin
reviewed
Jul 7, 2020
| testname = request.node.name | ||
| if request.config.getoption("--collect_techsupport") and request.node.rep_call.failed: | ||
| res = duthost.shell("generate_dump") | ||
| res = duthost.shell("generate_dump -s yesterday") |
Collaborator
There was a problem hiding this comment.
Can you make the time range configurable? When config option is not supplied, use default -s yesterday?
Contributor
Author
There was a problem hiding this comment.
Looks like to make the time range configurable doesn't yield too much benefit.
- So far we don't have any test case which requires log information for more than 1 day. In this sense, this modification doesn't affect test cases current running.
- to make the time range shorter doesn't reduce the size of tarball too much.
How do you think?
Collaborator
There was a problem hiding this comment.
Sounds OK if there is no much improvement in dump tarball size if the time range is reduced to hours.
wangxin
approved these changes
Jul 9, 2020
Collaborator
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* d240291 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855) * a71a5d3 [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1761) * 197f427 Fix vs test failure in test_buffer_traditional (sonic-net#1881) * 8471f42 Revert "[debugcounterorch] check if counter type is supported before querying… (sonic-net#1789)" (sonic-net#1884) Signed-off-by: Volodymyr Samotiy <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-swss commits 5fbd113 [Flex-counters] Fix the delay of flex counters flow to prevent infinite loop (sonic-net#1899) dc685b6 [portsorch] Add an extra check before setting oper speed to APPL_DB (sonic-net#1885) ceef728 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855) sonic-utilities commits 3160753 [ci]: Support PR coverage (sonic-net#1806) 3316fdb fix wrong code indent in sfputil (sonic-net#1808) c33e3a8 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) 4f7e107 [portconfig] Validate duplicate speed value and interface type value (sonic-net#1745) 59817e2 [warm-reboot] Add new preboot health check: verify database integrity (sonic-net#1785) bf2ff3c [portstat, intfstat] added rates and utilization (sonic-net#1750) 3bf962c [show][platform] Revise chassis info fallback to only fall back on pmon crash (sonic-net#1751)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The sonic dump will be collected when a test case fails.
However, it can be very time-consuming to collect dump in a switch with a lot of log files.
To collect dump since yesterday prevents DUT from consuming too much time on it.
Signed-off-by: Stephen Sun [email protected]
Type of change
Approach
What is the motivation for this PR?
To reduce the time consumed by collecting sonic dump when a test case fails
How did you do it?
Add "s yesterday"
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation