Skip to content

[vtestbed] Add another t0 testbed to virtual inventory#1750

Merged
daall merged 3 commits intosonic-net:masterfrom
daall:expand_virtual_testbed
Jun 10, 2020
Merged

[vtestbed] Add another t0 testbed to virtual inventory#1750
daall merged 3 commits intosonic-net:masterfrom
daall:expand_virtual_testbed

Conversation

@daall
Copy link
Contributor

@daall daall commented Jun 9, 2020

Signed-off-by: Danny Allen daall@microsoft.com

Description of PR

Summary: Adds another t0 topology to the testbed we can use for running KVM tests.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

We want to be able to run multiple KVM tests on the same runner concurrently, so we need a second t0 topology defined that we can use for running the tests.

How did you do it?

Updated the inventory/testbed files.

How did you verify/test it?

Deployed the new system using ansible.

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall marked this pull request as draft June 9, 2020 23:37
@daall
Copy link
Contributor Author

daall commented Jun 9, 2020

Oops, I found an issue when I tried to redeploy, trying to verify if it's my local system or the testbed config...

EDIT: The serial port of kvm-t0-1 and kvm-t0-2 have to be different, otherwise they can't be deployed on the same system. I also changed the IPs and base VMs to line up with #1720.

I tested again deploying the two testbeds concurrently and was able to deploy both and run test_bgp_fact succesfully on both.

@daall daall marked this pull request as ready for review June 10, 2020 00:57
@daall daall requested a review from tahmed-dev June 10, 2020 00:59
@lguohan
Copy link
Contributor

lguohan commented Jun 10, 2020

others lgtm

@daall daall merged commit efcd75d into sonic-net:master Jun 10, 2020
@daall daall deleted the expand_virtual_testbed branch June 10, 2020 17:48
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-swss commits

5fbd113 [Flex-counters] Fix the delay of flex counters flow to prevent infinite loop (sonic-net#1899)
dc685b6 [portsorch] Add an extra check before setting oper speed to APPL_DB (sonic-net#1885)
ceef728 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855)

sonic-utilities commits

3160753 [ci]: Support PR coverage (sonic-net#1806)
3316fdb fix wrong code indent in sfputil (sonic-net#1808)
c33e3a8 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814)
4f7e107 [portconfig] Validate duplicate speed value and interface type value (sonic-net#1745)
59817e2 [warm-reboot] Add new preboot health check: verify database integrity (sonic-net#1785)
bf2ff3c [portstat, intfstat] added rates and utilization (sonic-net#1750)
3bf962c [show][platform] Revise chassis info fallback to only fall back on pmon crash (sonic-net#1751)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…tically (#25609)

#### Why I did it
src/sonic-sairedis
```
* c7a61be0 - (HEAD -> 202511, origin/202511) Fix switch stat counters by using get_stats_ext instead of get_stats (sonic-net#1775) (3 hours ago) [mssonicbld]
* 4f1d7d99 - Revert "Temp workaround for sonic-buildimage issue 23387 (sonic-net#1629)" (sonic-net#1758) (13 hours ago) [mssonicbld]
* 7c5f17d2 - [ci] Install redis from Debian (sonic-net#1778) (24 hours ago) [mssonicbld]
* ec4a54d5 - Fix dash meter COUNTERS_DB keys to use VID instead of RID (sonic-net#1750) (4 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants