add gnmi_get output test by pra-moh · Pull Request #1808 · sonic-net/sonic-mgmt

pra-moh · 2020-06-23T20:06:24Z

Description of PR

Run pyclient available on ptfdocker to verify output from gnmi server on sonic duT

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
[ -] Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR to verify gnmi server end to end testing

Change settings for gnmi_server to client_auth=false. This is needed for pyclient to work.
run pyclient on ptfdocker
reset settings to original client_auth=true.

How did you do it?

How did you verify/test it?

pytest logs:

------------------------------------------------------------------------------------ live log setup -------------------------------------------------------------------------------------
23:04:53 INFO __init__.py:loganalyzer:15: Add start marker into DUT syslog
------------------------------------------------------------------------------------- live log call -------------------------------------------------------------------------------------
23:04:54 INFO test_telemetry.py:test_telemetry_ouput:77: start telemetry output testing
23:04:58 INFO test_telemetry.py:test_telemetry_ouput:81: telemetry process restarted. Now run pyclient on ptfdocker

  name: "COUNTERS"
}
elem {
  name: "Ethernet0"
}
The GetResponse is below
-------------------------

{
  "SAI_PORT_STAT_ETHER_STATS_TX_NO_ERRORS": "0",
  "SAI_PORT_STAT_PFC_0_RX_PKTS": "0",
  "SAI_PORT_STAT_IF_OUT_ERRORS": "0",
  "SAI_PORT_STAT_ETHER_TX_OVERSIZE_PKTS": "0",
  "SAI_PORT_STAT_PFC_3_TX_PKTS": "0",
  "SAI_PORT_STAT_PFC_1_TX_PKTS": "0",
  "SAI_PORT_STAT_PFC_5_RX_PKTS": "0",
  "SAI_PORT_STAT_IF_IN_ERRORS": "0",
  "SAI_PORT_STAT_PFC_7_RX_PKTS": "0",
  "SAI_PORT_STAT_IF_IN_DISCARDS": "0",
  "SAI_PORT_STAT_IF_IN_UNKNOWN_PROTOS": "0",
  "SAI_PORT_STAT_PFC_3_RX_PKTS": "0",
  "SAI_PORT_STAT_PAUSE_TX_PKTS": "0",
  "SAI_PORT_STAT_IF_IN_BROADCAST_PKTS": "0",
  "SAI_PORT_STAT_PFC_2_TX_PKTS": "0",
  "SAI_PORT_STAT_IF_OUT_MULTICAST_PKTS": "0",
  "SAI_PORT_STAT_PFC_5_TX_PKTS": "0",
  "SAI_PORT_STAT_ETHER_IN_PKTS_128_TO_255_OCTETS": "0",
  "SAI_PORT_STAT_IF_OUT_BROADCAST_PKTS": "0",
  "SAI_PORT_STAT_PAUSE_RX_PKTS": "0",
  "SAI_PORT_STAT_IF_OUT_DISCARDS": "0",
  "SAI_PORT_STAT_ETHER_RX_OVERSIZE_PKTS": "0",
  "SAI_PORT_STAT_IF_OUT_OCTETS": "0",
  "SAI_PORT_STAT_IF_IN_NON_UCAST_PKTS": "0",
  "SAI_PORT_STAT_PFC_6_RX_PKTS": "0",
  "SAI_PORT_STAT_PFC_1_RX_PKTS": "0",
  "SAI_PORT_STAT_PFC_6_TX_PKTS": "0",
  "SAI_PORT_STAT_PFC_7_TX_PKTS": "0",
  "SAI_PORT_STAT_IF_OUT_UCAST_PKTS": "0",
  "SAI_PORT_STAT_PFC_4_RX_PKTS": "0",
  "SAI_PORT_STAT_IF_IN_UCAST_PKTS": "0",
  "SAI_PORT_STAT_IF_IN_OCTETS": "0",
  "SAI_PORT_STAT_IF_OUT_QLEN": "0",
  "SAI_PORT_STAT_PFC_2_RX_PKTS": "0",
  "SAI_PORT_STAT_IF_OUT_NON_UCAST_PKTS": "0",
  "SAI_PORT_STAT_PFC_4_TX_PKTS": "0",
  "SAI_PORT_STAT_PFC_0_TX_PKTS": "0",
  "SAI_PORT_STAT_IP_IN_UCAST_PKTS": "0",
  "SAI_PORT_STAT_IF_IN_MULTICAST_PKTS": "0"
}
PASSED                                                                                                                                                                            [100%]
----------------------------------------------------------------------------------- live log teardown -----------------------------------------------------------------------------------
23:05:06 INFO __init__.py:loganalyzer:26: Add end marker into DUT syslog

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

lgtm-com · 2020-06-23T20:25:30Z

This pull request introduces 1 alert when merging bcd191c0e94522c79bf7d2de573a119aff007738 into 6025ffb - view on LGTM.com

new alerts:

1 for Syntax error

hui-ma

can you share test result in the description?

tests/telemetry/test_telemetry.py

lgtm-com · 2020-06-24T20:52:35Z

This pull request introduces 2 alerts when merging cba1b45d5d6d0fbd6d3846bbc8c2387f743b63db into ff37238 - view on LGTM.com

new alerts:

2 for Unused local variable

tests/telemetry/test_telemetry.py

lguohan

use py_gnmicli.py from https://github.com/lguohan/gnxi/blob/master/gnmi_cli_py/py_gnmicli.py

lgtm-com · 2020-07-17T00:44:47Z

This pull request introduces 1 alert when merging 8308e58d79e307a4445af72714c2bb89a66dd84d into b22f3cf - view on LGTM.com

new alerts:

1 for Unused local variable

tests/telemetry/test_telemetry.py

lguohan · 2020-07-22T02:23:30Z

can you resolve the conflict?

tests/telemetry/test_telemetry.py

lguohan · 2020-07-23T04:44:33Z

why do i still see conflicts?

lgtm-com · 2020-07-23T20:08:32Z

This pull request introduces 1 alert when merging a545c42 into a8277f5 - view on LGTM.com

new alerts:

1 for Unused local variable

jleveque

Please fix LGTM alert.

pra-moh · 2020-07-23T20:36:05Z

Please fix LGTM alert.

Fixed.

sonic-swss commits 5fbd113 [Flex-counters] Fix the delay of flex counters flow to prevent infinite loop (sonic-net#1899) dc685b6 [portsorch] Add an extra check before setting oper speed to APPL_DB (sonic-net#1885) ceef728 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855) sonic-utilities commits 3160753 [ci]: Support PR coverage (sonic-net#1806) 3316fdb fix wrong code indent in sfputil (sonic-net#1808) c33e3a8 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) 4f7e107 [portconfig] Validate duplicate speed value and interface type value (sonic-net#1745) 59817e2 [warm-reboot] Add new preboot health check: verify database integrity (sonic-net#1785) bf2ff3c [portstat, intfstat] added rates and utilization (sonic-net#1750) 3bf962c [show][platform] Revise chassis info fallback to only fall back on pmon crash (sonic-net#1751)

hui-ma reviewed Jun 23, 2020

View reviewed changes

tests/telemetry/test_telemetry.py Outdated Show resolved Hide resolved

tests/telemetry/test_telemetry.py Outdated Show resolved Hide resolved

lguohan reviewed Jun 24, 2020

View reviewed changes