Skip to content

Fix ntp synchronization issue for test_ntp#18841

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
JibinBao:fix_ntp_issue
Jul 3, 2025
Merged

Fix ntp synchronization issue for test_ntp#18841
bingwang-ms merged 1 commit intosonic-net:masterfrom
JibinBao:fix_ntp_issue

Conversation

@JibinBao
Copy link
Copy Markdown
Contributor

@JibinBao JibinBao commented Jun 6, 2025 •
edited
Loading

Description of PR

The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To resolve the issue, remove the network NTP configuration from the pool.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fix ntp synchronization issue for test_ntp

How did you do it?

Just keep one ntp clock for the ptf ntp server

How did you verify/test it?

Run test_ntp.py

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

@JibinBao
Fix test_ntp_long_jump issue
3c3179c 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 6, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

wsycqyz
wsycqyz approved these changes Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lğtm

@wsycqyz
Copy link
Copy Markdown
Contributor

wsycqyz commented Jun 16, 2025

Nice catch!

@nhe-NV
Copy link
Copy Markdown
Contributor

nhe-NV commented Jun 28, 2025

@bingwang-ms Can you help to merge?

@bingwang-ms bingwang-ms merged commit a7de0fb into sonic-net:master Jul 3, 2025
19 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 4, 2025
@JibinBao @mssonicbld
Fix test_ntp_long_jump issue (sonic-net#18841)
0279b94 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 4, 2025

Cherry-pick PR to 202505: #19405

@mssonicbld mssonicbld mentioned this pull request Jul 4, 2025
Closed
11 tasks
@mssonicbld mssonicbld mentioned this pull request Jul 10, 2025
Merged
11 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jul 10, 2025

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#516

@r12f r12f mentioned this pull request Jul 10, 2025
Merged
11 tasks
@bingwang-ms bingwang-ms mentioned this pull request Jul 30, 2025
Merged
bingwang-ms added a commit to Azure/sonic-mgmt.msft that referenced this pull request Jul 30, 2025
@bingwang-ms
Cherry-pick NTP test fix to 202503 (#592)
c48b273 
This PR is to cherry-pick below PRs to 202503 branch

- sonic-net/sonic-mgmt#17434
- sonic-net/sonic-mgmt#17629
- sonic-net/sonic-mgmt#18583
- sonic-net/sonic-mgmt#18627
- sonic-net/sonic-mgmt#18841
- sonic-net/sonic-mgmt#19444
@yejianquan
Copy link
Copy Markdown
Collaborator

yejianquan commented Jul 31, 2025

202505, has been included in #19948

nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
@JibinBao @nissampa
Fix test_ntp_long_jump issue (sonic-net#18841)
bba99d0 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
@JibinBao @ashutosh-agrawal
Fix test_ntp_long_jump issue (sonic-net#18841)
fe141a7 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
@JibinBao @vidyac86
Fix test_ntp_long_jump issue (sonic-net#18841)
0330187 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@JibinBao
Fix test_ntp_long_jump issue (sonic-net#18841)
0ac8ebb 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@JibinBao @gshemesh2
Fix test_ntp_long_jump issue (sonic-net#18841)
4654690 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@JibinBao @AharonMalkin
Fix test_ntp_long_jump issue (sonic-net#18841)
a26f9e6 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@JibinBao @gshemesh2
Fix test_ntp_long_jump issue (sonic-net#18841)
4297814 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@JibinBao @venu-nexthop
Fix test_ntp_long_jump issue (sonic-net#18841)
0647b5a 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@JibinBao @gshemesh2
Fix test_ntp_long_jump issue (sonic-net#18841)
4163b68 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@JibinBao @ytzur1
Fix test_ntp_long_jump issue (sonic-net#18841)
7b2de4f 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request Feb 3, 2026
@JibinBao @bingwang-ms
Fix test_ntp_long_jump issue (sonic-net#18841)
69662f4 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@JibinBao
Fix test_ntp_long_jump issue (sonic-net#18841)
6043af7 
The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsycqyz wsycqyz wsycqyz approved these changes

@bingwang-ms bingwang-ms bingwang-ms approved these changes

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Approved for msft-202503 Branch Approved for 202505 branch Cherry Pick Conflict_msft-202503 Included in msft-202412 Branch Included in 202505 branch Request for msft-202412 Branch Request for msft-202503 Branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JibinBao @mssonicbld @wsycqyz @nhe-NV @yejianquan @bingwang-ms @r12f