Skip to content

Update gnoi and mvrf test cases for chrony support#17434

Merged
yxieca merged 7 commits intosonic-net:masterfrom
saiarcot895:fix-gnoi-for-chrony
Mar 15, 2025
Merged

Update gnoi and mvrf test cases for chrony support#17434
yxieca merged 7 commits intosonic-net:masterfrom
saiarcot895:fix-gnoi-for-chrony

Conversation

@saiarcot895
Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 commented Mar 10, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

With the NTP daemon being changed from ntpd to chrony, commands that refer to the ntpd daemon need to be updated to point to chrony instead.

How did you do it?

Update the gnoi and mvrf test cases to point to chrony-related commands instead of ntpd-related commands.

How did you verify/test it?

Tested on physical T0 and T2 testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@saiarcot895 saiarcot895 requested review from YatishSVC and yxieca March 12, 2025 18:56
Copy link
Copy Markdown
Contributor

@YatishSVC YatishSVC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
Asked SaiKrishna to test on T2 platforms.
Confirmed from SaiKrishna that the tests pass on T2 chassis.

@yxieca yxieca merged commit afe83b9 into sonic-net:master Mar 15, 2025
18 checks passed
@saiarcot895 saiarcot895 deleted the fix-gnoi-for-chrony branch March 17, 2025 20:05
OriTrabelsi pushed a commit to OriTrabelsi/sonic-mgmt that referenced this pull request Apr 1, 2025
What is the motivation for this PR?
With the NTP daemon being changed from ntpd to chrony, commands that refer to the ntpd daemon need to be updated to point to chrony instead.

How did you do it?
Update the gnoi and mvrf test cases to point to chrony-related commands instead of ntpd-related commands.

How did you verify/test it?
Tested on physical T0 and T2 testbed.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
What is the motivation for this PR?
With the NTP daemon being changed from ntpd to chrony, commands that refer to the ntpd daemon need to be updated to point to chrony instead.

How did you do it?
Update the gnoi and mvrf test cases to point to chrony-related commands instead of ntpd-related commands.

How did you verify/test it?
Tested on physical T0 and T2 testbed.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
What is the motivation for this PR?
With the NTP daemon being changed from ntpd to chrony, commands that refer to the ntpd daemon need to be updated to point to chrony instead.

How did you do it?
Update the gnoi and mvrf test cases to point to chrony-related commands instead of ntpd-related commands.

How did you verify/test it?
Tested on physical T0 and T2 testbed.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request Feb 3, 2026
What is the motivation for this PR?
With the NTP daemon being changed from ntpd to chrony, commands that refer to the ntpd daemon need to be updated to point to chrony instead.

How did you do it?
Update the gnoi and mvrf test cases to point to chrony-related commands instead of ntpd-related commands.

How did you verify/test it?
Tested on physical T0 and T2 testbed.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants