Skip to content

[action] [PR:18841] Fix ntp synchronization issue for test_ntp#19405

Closed
mssonicbld wants to merge 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/18841
Closed

[action] [PR:18841] Fix ntp synchronization issue for test_ntp#19405
mssonicbld wants to merge 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/18841

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To resolve the issue, remove the network NTP configuration from the pool.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fix ntp synchronization issue for test_ntp

How did you do it?

Just keep one ntp clock for the ptf ntp server

How did you verify/test it?

Run test_ntp.py

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

The test initiates an NTP server on PTF, which has a pool of 4 network NTP servers and sets the local clock as the preferred option. However, the local server's clock (crystal oscillator) has poor accuracy, causing the PTF's NTP server to dynamically switch to other network NTP servers in the pool. As a result, when DUT uses the PTF NTP server as the clock, synchronization becomes difficult. To  resolve the issue, remove the network NTP configuration from the pool.
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #18841

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wsycqyz
Copy link
Copy Markdown
Contributor

wsycqyz commented Jul 9, 2025

Re-trigger the PR test

@yejianquan
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@yejianquan
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Copy Markdown
Collaborator

Hi @JibinBao , could you check the test failure of cherry-picking to 202505 branch?

@JibinBao
Copy link
Copy Markdown
Contributor

Hi @JibinBao , could you check the test failure of cherry-picking to 202505 branch?

I have seen the same error on other PRs. It looks like not related to my fix.
Let's re-run the checker.

@JibinBao
Copy link
Copy Markdown
Contributor

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Copy Markdown
Collaborator

Hi @JibinBao , could you check the test failure of cherry-picking to 202505 branch?

I have seen the same error on other PRs. It looks like not related to my fix. Let's re-run the checker.

Hi @JibinBao , multi-asic failures we can ignore, but on t0 and t1-lag, the ntp test is failing

@JibinBao
Copy link
Copy Markdown
Contributor

hi @yejianquan ,
From the logs, I cannot see what is the root cause.However, it passed the checker on master branch, I am not sure whether it is the environmental issue. What is the difference for ntp server between master and 202505 branch?
Or let try re-run it multi times. Usually if it is a environmental issue, re-running it many times can pass the checker.

@JibinBao
Copy link
Copy Markdown
Contributor

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Verma-Anukul
Copy link
Copy Markdown
Contributor

@JibinBao

Any update here

@yejianquan
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Copy Markdown
Collaborator

has been included in #19948

@yejianquan yejianquan closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants