Add check for max root dispersion on the PTF's NTP daemon#17629
Merged
yxieca merged 2 commits intosonic-net:masterfrom Mar 21, 2025
Merged
Add check for max root dispersion on the PTF's NTP daemon#17629yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). Therefore, block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Mar 21, 2025
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
…17629) * Add check for max root dispersion on the PTF's NTP daemon When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). Therefore, block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix math and fix whitespace Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
…17629) * Add check for max root dispersion on the PTF's NTP daemon When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). Therefore, block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix math and fix whitespace Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added
Request for msft-202412 Branch
and removed
Request for msft-202412 Branch
Cherry Pick Conflict_msft-202412
labels
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#423 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
bingwang-ms
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jul 30, 2025
This PR is to cherry-pick below PRs to 202503 branch - sonic-net/sonic-mgmt#17434 - sonic-net/sonic-mgmt#17629 - sonic-net/sonic-mgmt#18583 - sonic-net/sonic-mgmt#18627 - sonic-net/sonic-mgmt#18841 - sonic-net/sonic-mgmt#19444
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…17629) * Add check for max root dispersion on the PTF's NTP daemon When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). Therefore, block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix math and fix whitespace Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…17629) * Add check for max root dispersion on the PTF's NTP daemon When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). Therefore, block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix math and fix whitespace Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…17629) * Add check for max root dispersion on the PTF's NTP daemon When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). Therefore, block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix math and fix whitespace Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…17629) * Add check for max root dispersion on the PTF's NTP daemon When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). Therefore, block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix math and fix whitespace Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting).
How did you do it?
Block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation