Skip to content

Update setup_ntp_context to detect NTP daemon type on PTF Host#18583

Merged
wangxin merged 1 commit intosonic-net:masterfrom
opcoder0:fix/bookworm-uses-ntpsec
May 27, 2025
Merged

Update setup_ntp_context to detect NTP daemon type on PTF Host#18583
wangxin merged 1 commit intosonic-net:masterfrom
opcoder0:fix/bookworm-uses-ntpsec

Conversation

@opcoder0
Copy link
Copy Markdown
Contributor

Description of PR

Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Required for migration of Docker PTF to Bookworm.

How did you do it?

See description.

How did you verify/test it?

Manually.

Any platform specific information?

NA

Supported testbed topology if it's a new test case?

NA

Documentation

NA

@opcoder0 opcoder0 requested review from saiarcot895 and yutongzhang-microsoft and removed request for saiarcot895 May 23, 2025 07:59
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@opcoder0 opcoder0 requested review from saiarcot895 and wangxin May 23, 2025 08:00
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit 52d8be7 into sonic-net:master May 27, 2025
17 checks passed
bachalla pushed a commit to bachalla/sonic-mgmt that referenced this pull request Jun 2, 2025
Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 17, 2025
Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #19048

yejianquan pushed a commit that referenced this pull request Jun 18, 2025
…9049)

Description of PR
Consolidated PR with all changes required for docker-ptf Bookworm based image. Based on these PRs for master -

#18544
#18627
#18584
#18583

Summary:
Fixes # (issue)

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
This change is backward compatible and is required to support running tests in docker-ptf Bookworm image.

How did you do it?
See description

signed-off-by: [email protected]
opcoder0 added a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only

Signed-off-by: opcoder0 <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only

Signed-off-by: Guy Shemesh <[email protected]>
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request Feb 3, 2026
Bookworm uses ntpsec as the NTP daemon on the PTF host. The PR is modified to be backward compatible with Bullseye. It detects the NTP daemon type which is NTP on Bullseye and NTPSEC on Bookworm. Fixes test failures on Bookworm that rely on the NTP daemon setup like ip/test_mgmt_ipv6_only.py::test_ntp_ipv6_only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants