Fix the issue of handling telemetry keys&certs during deploy-mg#1737
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jun 5, 2020
wangxin:fix-deploy-mg-pr
Merged
Fix the issue of handling telemetry keys&certs during deploy-mg#1737lguohan merged 1 commit intosonic-net:masterfrom wangxin:fix-deploy-mg-pr
lguohan merged 1 commit intosonic-net:masterfrom
wangxin:fix-deploy-mg-pr
Conversation
The keys and certs are directly generated on SONiC switch, not on localhost. There is no need to copy the files from local to remote. Even worse, trying to copy the keys and certs from localhost to SONiC will fail with source file not found issue. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
3 tasks
lguohan
approved these changes
Jun 5, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
a631f04 Add check_db_integrity script to setup.py (sonic-net#1828) ddf6793 Implement script null_route_helper (sonic-net#1737)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tically (#25244) #### Why I did it src/sonic-sairedis ``` * 2457bb8d - (HEAD -> 202511, origin/202511) [Mellanox] Add phcsync activation for mellanox platforms. (sonic-net#1752) (2 days ago) [mssonicbld] * bcbf7158 - [202511] Upgrade SAI to v1.17.4 (sonic-net#1749) (3 days ago) [Vivek] * 5eec8434 - [syncd] Remove syncd redis objects if using ZMQ notifications (sonic-net#1738) (6 days ago) [mssonicbld] * 7770f146 - [vslib] MACsec interface creation command fails on VM/VS with send_sci=false and SCI combination. (sonic-net#1737) (6 days ago) [mssonicbld] * 4a62e3d2 - [202511][ci] use correct slave container for each branch (sonic-net#1746) (6 days ago) [yijingyan2] * cff5ae14 - Fix sonic-vpp build issue in master (sonic-net#1745) (7 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it include changes from sairedis submodule 102d20b | [202211][submodule][SAI]Advance header include 0031470 | improve enum values integration check (sonic-net#1727) (sonic-net#1737) 04d3c41 | [Submodule][upgrade]Upgrade SAI submodule (sonic-net#1204) updates from SAI 7710e24 | [cherry-pick][202211]Enhance the check enum lock script (sonic-net#1741) (sonic-net#1742) 0031470 | improve enum values integration check (sonic-net#1727) (sonic-net#1737) 4f11c7e | Enable github code scanning to replace LGTM. (sonic-net#1709) How I did it How to verify it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The telemetry keys and certs are directly generated on SONiC switch, not
on localhost. There is no need to copy the files from local to
remote. Even worse, trying to copy the keys and certs from
localhost to SONiC will fail with source file not found issue.
Type of change
Approach
What is the motivation for this PR?
The change introduced in #1716 broke the deploy-mg function.
How did you do it?
Remove the unnecessary steps for copying keys and certs from local to remote.
How did you verify/test it?
Test run the
testbed-cli.sh deploy-mgon vs setup. Check on SONiC, the keys and certs can be found under /etc/sonic/telemetry.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation