Skip to content

Skip test_incremental_qos on Mellanox dualtor#17406

Merged
bingwang-ms merged 1 commit intomasterfrom
skip_incremental_qos_dualtor
Mar 7, 2025
Merged

Skip test_incremental_qos on Mellanox dualtor#17406
bingwang-ms merged 1 commit intomasterfrom
skip_incremental_qos_dualtor

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms commented Mar 7, 2025

Description of PR

Summary:
This PR is to skip test_incremental_qos.py on Mellanox dualtor testbed.
It's not skipped now because there is a longer match in the condition list. Actually it's not needed as there is only 1 test case in test module test_incremental_qos.py.

generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates:
  skip:
    reason: "This test is not run on this hwsku/asic type or version or topology currently"
    conditions_logical_operator: "OR"
    conditions:
      - "not any(i in hwsku for i in ['2700', 'Arista-7170-64C', 'montara', 'newport']) and asic_type in ['broadcom', 'cisco-8000'] and release in ['202211']"
      - "'t2' in topo_name"

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

This PR is to skip test_incremental_qos.py on Mellanox dualtor testbed.

How did you do it?

Update tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

How did you verify/test it?

The change is verified on a Mellanox dualtor testbed.

collected 9 items                                                                                                                                                                                                             

generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[add-ingress_lossless_pool/xoff] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 11%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[add-ingress_lossless_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 22%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[add-egress_lossy_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 33%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[replace-ingress_lossless_pool/xoff] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 44%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[replace-ingress_lossless_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 55%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[replace-egress_lossy_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 66%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[remove-ingress_lossless_pool/xoff] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 77%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[remove-ingress_lossless_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 88%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[remove-egress_lossy_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [100%]

Any platform specific information?

Mellanox dualtor.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Mar 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms mentioned this pull request Mar 7, 2025
Merged
11 tasks
@bingwang-ms bingwang-ms merged commit 4e22041 into master Mar 7, 2025
19 of 20 checks passed
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
@bingwang-ms @nnelluri-cisco
Skip test_incremental_qos on Mellanox dualtor (sonic-net#17406)
e821d2b
OriTrabelsi pushed a commit to OriTrabelsi/sonic-mgmt that referenced this pull request Apr 1, 2025
@bingwang-ms @OriTrabelsi
Skip test_incremental_qos on Mellanox dualtor (sonic-net#17406)
3a4a8b7
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Apr 18, 2025
@bingwang-ms @mssonicbld
Skip test_incremental_qos on Mellanox dualtor (sonic-net#17406)
ca69539
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 18, 2025

Cherry-pick PR to 202411: #18048

@mssonicbld mssonicbld mentioned this pull request Apr 18, 2025
Merged
11 tasks
bingwang-ms added a commit that referenced this pull request Apr 18, 2025
@mssonicbld @bingwang-ms
Skip test_incremental_qos on Mellanox dualtor (#17406) (#18048)
9ab1e7a 
Co-authored-by: bingwang-ms <66248323+bingwang-ms@users.noreply.github.com>
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request May 30, 2025
@Javier-Tan
[202503] Code sync sonic-net/sonic-mgmt:202411 => 202503 (sonic-net#245)
d0141ae 
Code sync sonic-net/sonic-mgmt:202411 => 202503
```
*   6b59eaa (HEAD -> sync/202503, origin/sync/202503) Merge remote-tracking branch 'pub_upstream/202411' into sync/202503
|\
| * c6a94a0 (pub_upstream/202411) Revert "[dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)" (sonic-net#18192)
| * de454d5 [testARPCompleted] Cleanup ptf ip after test failure (sonic-net#18170)
| * 4a3d1d9 [dualtor] Refine `fdb_mac_learning_test.py` (sonic-net#18092)
| * 5964a78 [dualtor_io] Fix the start marker not found issue (sonic-net#18096)
| * ce40816 Extend LACP time multiplier for advanced-reboot tests with cEOS peers (sonic-net#17964)
| * 0e70ba3 adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (sonic-net#18130)
| * 8bb7203 [202411] Restore disable packet aging fixture 202411 (sonic-net#18103)
| * 8f6d1a3 Filter out Not Applicable values in command line (sonic-net#18006)
| * 9d5de5c Backport t0-118 test configs to 202411 (sonic-net#17983)
| * e758401 mark xfail on generic hash test for isolated topo (sonic-net#18071)
| * c65ceab [202411][dualtor] Skip pfcwd warm reboot on dualtor (sonic-net#18072)
| * c509006 Improve disabling packet aging to support swap_syncd (sonic-net#17728) (sonic-net#17739)
| * 9dc2244 [202411][dualtor-aa] Fix test_arp_dualtor on active-active dualtor (sonic-net#18073)
| * cf12a33 fixed tacacs duplicate user issue (sonic-net#18068)
| * 330a893 Fix telemetry/test_events.py for dualtor (sonic-net#18025)
| * dc6fee8 Remove admin down ports in BUFFER PG check logic (sonic-net#17505)
| * 805d538 Update generic hash test to support dualtor active active topology (sonic-net#16217)
| * 7c31e46 [dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)
| * a7f50c6 Fix vlan vs router mac issue with test_qos_dscp_mapping.py (sonic-net#17846) (sonic-net#18003)
| * 9ab1e7a Skip test_incremental_qos on Mellanox dualtor (sonic-net#17406) (sonic-net#18048)
| * f42afd0 Force eos default creds to be string (sonic-net#18026)
| * be542b0 Restore config after vxlan_crm from vxlan_ecmp. (sonic-net#17767)
| * f0718b9 [Fix for Issue sonic-net#17413] Modified the Tx Rx port id list selection for all to all scenario (sonic-net#17919)
| * 3eb4ed4 [dualtor_io] Collect syslog to debug (sonic-net#17722)
| * d5bd995 Disable PFC-WD during PCBB and some wmk test improvements (sonic-net#17889)
| * 2f512aa Update outer UDP sport range to exclude port 53 (sonic-net#17570) (sonic-net#17798)
| * 980b373 skip test_bgp_slb advanced reboot for isolated topo (sonic-net#17470)
| * 408bf9e Default the inner dscp to outer dscp map to be 1-1. (sonic-net#17860)
| * 37495a1 Add dualtor fixtures to no_traffic test. (sonic-net#17916)
| * a13b599 Only print the matched syslog in loganalzyer teardown check, no traceback info printed (sonic-net#17926)
| * 6127f29 Revert "Skip test_vnet_decap on Cisco-8000 with 202411 (sonic-net#17776)" (sonic-net#17941) (sonic-net#17942)
| * 60274db Increase timeout to 5 in verify_packet_any_port for background traffic (sonic-net#17904)
```
@wangxin wangxin deleted the skip_incremental_qos_dualtor branch July 4, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lolyu lolyu lolyu approved these changes

Assignees

No one assigned

Labels

Approved for 202411 branch Included in 202411 branch Request for 202405 branch Request for 202411 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bingwang-ms @mssonicbld @lolyu