[dualtor] Refine `fdb_mac_learning_test.py` by lolyu · Pull Request #18092 · sonic-net/sonic-mgmt

lolyu · 2025-04-23T06:40:23Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

few improvements/fixes to fdb_mac_learning_test.py:

replace the config reload in the setup with sonic-clear commands to cleanup fdb/arp entries in setup, this reduces the reload overhead.
send ARP packets instead of simple Ether packets to populate fdb table, this avoids the complex toggle logic on dualtor as the ARP packets are duplicated/accepted by both sides regardless of the mux status.
add the ip assignment before the neighbor check to validate the ip is correctly assigned on DUT.
sleep after ip assignment/before ping to wait for the ip assignment finish.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

As the motivation.

How did you verify/test it?

t0:

fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testFdbMacLearning PASSED                                                                                                                    [ 50%]
fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testARPCompleted PASSED                                                                                                                      [100%]

dualtor:

fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testFdbMacLearning PASSED                                                                                                                    [ 50%]
fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testARPCompleted PASSED                                                                                                                      [100%]

dualtor-aa:

fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testFdbMacLearning PASSED                                                                                                                    [ 50%]
fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testARPCompleted PASSED                                                                                                                      [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-04-23T06:40:31Z

/azp run

azure-pipelines · 2025-04-23T06:40:42Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld · 2025-04-23T06:42:45Z

/azp run

azure-pipelines · 2025-04-23T06:42:57Z

Azure Pipelines successfully started running 1 pipeline(s).

bingwang-ms · 2025-04-23T06:45:53Z

Should we merge this PR only in master?

tests/fdb/test_fdb_mac_learning.py

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld · 2025-04-24T11:17:22Z

/azp run

azure-pipelines · 2025-04-24T11:17:33Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit e1d168d.

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld · 2025-04-29T07:17:02Z

Cherry-pick PR to 202411: #18172

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * | c6a94a0 (pub_upstream/202411) Revert "[dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)" (sonic-net#18192) * | de454d5 [testARPCompleted] Cleanup ptf ip after test failure (sonic-net#18170) * | 4a3d1d9 [dualtor] Refine `fdb_mac_learning_test.py` (sonic-net#18092) * | 5964a78 [dualtor_io] Fix the start marker not found issue (sonic-net#18096) * | ce40816 Extend LACP time multiplier for advanced-reboot tests with cEOS peers (sonic-net#17964) * | 0e70ba3 adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (sonic-net#18130) * | 8bb7203 [202411] Restore disable packet aging fixture 202411 (sonic-net#18103) * | 8f6d1a3 Filter out Not Applicable values in command line (sonic-net#18006) * | 9d5de5c Backport t0-118 test configs to 202411 (sonic-net#17983) ```

Code sync sonic-net/sonic-mgmt:202411 => 202503 ``` * 6b59eaa (HEAD -> sync/202503, origin/sync/202503) Merge remote-tracking branch 'pub_upstream/202411' into sync/202503 |\ | * c6a94a0 (pub_upstream/202411) Revert "[dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)" (sonic-net#18192) | * de454d5 [testARPCompleted] Cleanup ptf ip after test failure (sonic-net#18170) | * 4a3d1d9 [dualtor] Refine `fdb_mac_learning_test.py` (sonic-net#18092) | * 5964a78 [dualtor_io] Fix the start marker not found issue (sonic-net#18096) | * ce40816 Extend LACP time multiplier for advanced-reboot tests with cEOS peers (sonic-net#17964) | * 0e70ba3 adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (sonic-net#18130) | * 8bb7203 [202411] Restore disable packet aging fixture 202411 (sonic-net#18103) | * 8f6d1a3 Filter out Not Applicable values in command line (sonic-net#18006) | * 9d5de5c Backport t0-118 test configs to 202411 (sonic-net#17983) | * e758401 mark xfail on generic hash test for isolated topo (sonic-net#18071) | * c65ceab [202411][dualtor] Skip pfcwd warm reboot on dualtor (sonic-net#18072) | * c509006 Improve disabling packet aging to support swap_syncd (sonic-net#17728) (sonic-net#17739) | * 9dc2244 [202411][dualtor-aa] Fix test_arp_dualtor on active-active dualtor (sonic-net#18073) | * cf12a33 fixed tacacs duplicate user issue (sonic-net#18068) | * 330a893 Fix telemetry/test_events.py for dualtor (sonic-net#18025) | * dc6fee8 Remove admin down ports in BUFFER PG check logic (sonic-net#17505) | * 805d538 Update generic hash test to support dualtor active active topology (sonic-net#16217) | * 7c31e46 [dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909) | * a7f50c6 Fix vlan vs router mac issue with test_qos_dscp_mapping.py (sonic-net#17846) (sonic-net#18003) | * 9ab1e7a Skip test_incremental_qos on Mellanox dualtor (sonic-net#17406) (sonic-net#18048) | * f42afd0 Force eos default creds to be string (sonic-net#18026) | * be542b0 Restore config after vxlan_crm from vxlan_ecmp. (sonic-net#17767) | * f0718b9 [Fix for Issue sonic-net#17413] Modified the Tx Rx port id list selection for all to all scenario (sonic-net#17919) | * 3eb4ed4 [dualtor_io] Collect syslog to debug (sonic-net#17722) | * d5bd995 Disable PFC-WD during PCBB and some wmk test improvements (sonic-net#17889) | * 2f512aa Update outer UDP sport range to exclude port 53 (sonic-net#17570) (sonic-net#17798) | * 980b373 skip test_bgp_slb advanced reboot for isolated topo (sonic-net#17470) | * 408bf9e Default the inner dscp to outer dscp map to be 1-1. (sonic-net#17860) | * 37495a1 Add dualtor fixtures to no_traffic test. (sonic-net#17916) | * a13b599 Only print the matched syslog in loganalzyer teardown check, no traceback info printed (sonic-net#17926) | * 6127f29 Revert "Skip test_vnet_decap on Cisco-8000 with 202411 (sonic-net#17776)" (sonic-net#17941) (sonic-net#17942) | * 60274db Increase timeout to 5 in verify_packet_any_port for background traffic (sonic-net#17904) ```

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…onic-net#18092) HW Lane for Inband and Rec ports were conflicting with front panel ports Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>

[dualtor] Refine fdb_mac_learning_test.py

e2e455c

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

lolyu force-pushed the fdb_improve branch from b9efcb2 to e2e455c Compare April 23, 2025 06:42

lolyu requested review from bingwang-ms and yxieca April 23, 2025 06:43

lolyu added the Request for 202411 branch label Apr 23, 2025

bingwang-ms reviewed Apr 23, 2025

View reviewed changes

tests/fdb/test_fdb_mac_learning.py Show resolved Hide resolved

yxieca reviewed Apr 24, 2025

View reviewed changes

tests/fdb/test_fdb_mac_learning.py Outdated Show resolved Hide resolved

Fix comments

de7b830

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

bingwang-ms approved these changes Apr 28, 2025

View reviewed changes

bingwang-ms merged commit e1d168d into sonic-net:master Apr 28, 2025
18 checks passed

lolyu added a commit to lolyu/sonic-mgmt that referenced this pull request Apr 29, 2025

Revert "[dualtor] Refine fdb_mac_learning_test.py (sonic-net#18092)"

0adc101

This reverts commit e1d168d.

lolyu mentioned this pull request Apr 29, 2025

Revert "[dualtor] Refine fdb_mac_learning_test.py" #18169

Closed

lolyu added the Approved for 202411 branch label Apr 29, 2025

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Apr 29, 2025

[dualtor] Refine fdb_mac_learning_test.py (sonic-net#18092)

1883d4c

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld added the Created PR to 202411 branch label Apr 29, 2025

mssonicbld mentioned this pull request Apr 29, 2025

[action] [PR:18092] [dualtor] Refine fdb_mac_learning_test.py #18172

Merged

11 tasks

mssonicbld pushed a commit that referenced this pull request Apr 29, 2025

[dualtor] Refine fdb_mac_learning_test.py (#18092)

4a3d1d9

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Apr 29, 2025

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025

[dualtor] Refine fdb_mac_learning_test.py (sonic-net#18092)

746976c

* [dualtor] Refine `fdb_mac_learning_test.py` Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dualtor] Refine `fdb_mac_learning_test.py`#18092

[dualtor] Refine `fdb_mac_learning_test.py`#18092
bingwang-ms merged 2 commits intosonic-net:masterfrom
lolyu:fdb_improve

lolyu commented Apr 23, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

mssonicbld commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

bingwang-ms commented Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Apr 24, 2025

Uh oh!

azure-pipelines bot commented Apr 24, 2025

Uh oh!

Uh oh!

mssonicbld commented Apr 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lolyu commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

mssonicbld commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

bingwang-ms commented Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Apr 24, 2025

Uh oh!

azure-pipelines bot commented Apr 24, 2025

Uh oh!

Uh oh!

mssonicbld commented Apr 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lolyu commented Apr 23, 2025 •

edited

Loading