Skip to content

Update outer UDP sport range to exclude port 53#17570

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
echuawu:hash_test_fix
Mar 26, 2025
Merged

Update outer UDP sport range to exclude port 53#17570
bingwang-ms merged 1 commit intosonic-net:masterfrom
echuawu:hash_test_fix

Conversation

@echuawu
Copy link
Contributor

@echuawu echuawu commented Mar 18, 2025 •
edited
Loading

Description of PR

UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port due to an existing ovs rule:
cookie=0x0, duration=8133.286s, table=0, n_packets=0, n_bytes=0, idle_age=8133, priority=8,udp,in_port=3,tp_src=53 actions=output:1

Summary:
Fixes # (issue)
When UDP outer sport == 53, the packet would not be received at PTF ports in fib/test_fib.py::test_vxlan_hash test

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

When UDP outer sport == 53, the packet would not be received at PTF ports in fib/test_fib.py::test_vxlan_hash test

How did you do it?

Exclude 53 from the port range

How did you verify/test it?

Run it in local setup

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 18, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Mar 19, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 19, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Mar 20, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 20, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 20, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Mar 21, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 21, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 21, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Mar 24, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 24, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 24, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Update outer UDP sport range to exclude port 53
c60100a 
UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port

Change-Id: I7c16425c8cceebd3a5cd6d9a4b20c4d93277c037
@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 25, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Mar 25, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 25, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms enabled auto-merge (squash) March 26, 2025 01:34
@bingwang-ms
Copy link
Collaborator

bingwang-ms commented Mar 26, 2025

LGTM. Thanks for the fix

@bingwang-ms bingwang-ms merged commit 0f88068 into sonic-net:master Mar 26, 2025
19 checks passed
amulyan7 pushed a commit to amulyan7/sonic-mgmt that referenced this pull request Mar 31, 2025
@echuawu @amulyan7
Update outer UDP sport range to exclude port 53 (sonic-net#17570)
f645e0d 
UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port

Change-Id: I7c16425c8cceebd3a5cd6d9a4b20c4d93277c037
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Apr 1, 2025
@echuawu @mssonicbld
Update outer UDP sport range to exclude port 53 (sonic-net#17570)
9eac659 
UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port

Change-Id: I7c16425c8cceebd3a5cd6d9a4b20c4d93277c037
@mssonicbld
Copy link
Collaborator

mssonicbld commented Apr 1, 2025

Cherry-pick PR to 202411: #17798

@mssonicbld mssonicbld mentioned this pull request Apr 1, 2025
Merged
11 tasks
OriTrabelsi pushed a commit to OriTrabelsi/sonic-mgmt that referenced this pull request Apr 1, 2025
@echuawu @OriTrabelsi
Update outer UDP sport range to exclude port 53 (sonic-net#17570)
ca8ce35 
UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port

Change-Id: I7c16425c8cceebd3a5cd6d9a4b20c4d93277c037
kperumalbfn pushed a commit that referenced this pull request Apr 15, 2025
@mssonicbld
Update outer UDP sport range to exclude port 53 (#17570) (#17798)
2f512aa 
[202411] Update outer UDP sport range to exclude port 53
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request May 30, 2025
@Javier-Tan
[202503] Code sync sonic-net/sonic-mgmt:202411 => 202503 (sonic-net#245)
d0141ae 
Code sync sonic-net/sonic-mgmt:202411 => 202503
```
*   6b59eaa (HEAD -> sync/202503, origin/sync/202503) Merge remote-tracking branch 'pub_upstream/202411' into sync/202503
|\
| * c6a94a0 (pub_upstream/202411) Revert "[dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)" (sonic-net#18192)
| * de454d5 [testARPCompleted] Cleanup ptf ip after test failure (sonic-net#18170)
| * 4a3d1d9 [dualtor] Refine `fdb_mac_learning_test.py` (sonic-net#18092)
| * 5964a78 [dualtor_io] Fix the start marker not found issue (sonic-net#18096)
| * ce40816 Extend LACP time multiplier for advanced-reboot tests with cEOS peers (sonic-net#17964)
| * 0e70ba3 adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (sonic-net#18130)
| * 8bb7203 [202411] Restore disable packet aging fixture 202411 (sonic-net#18103)
| * 8f6d1a3 Filter out Not Applicable values in command line (sonic-net#18006)
| * 9d5de5c Backport t0-118 test configs to 202411 (sonic-net#17983)
| * e758401 mark xfail on generic hash test for isolated topo (sonic-net#18071)
| * c65ceab [202411][dualtor] Skip pfcwd warm reboot on dualtor (sonic-net#18072)
| * c509006 Improve disabling packet aging to support swap_syncd (sonic-net#17728) (sonic-net#17739)
| * 9dc2244 [202411][dualtor-aa] Fix test_arp_dualtor on active-active dualtor (sonic-net#18073)
| * cf12a33 fixed tacacs duplicate user issue (sonic-net#18068)
| * 330a893 Fix telemetry/test_events.py for dualtor (sonic-net#18025)
| * dc6fee8 Remove admin down ports in BUFFER PG check logic (sonic-net#17505)
| * 805d538 Update generic hash test to support dualtor active active topology (sonic-net#16217)
| * 7c31e46 [dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)
| * a7f50c6 Fix vlan vs router mac issue with test_qos_dscp_mapping.py (sonic-net#17846) (sonic-net#18003)
| * 9ab1e7a Skip test_incremental_qos on Mellanox dualtor (sonic-net#17406) (sonic-net#18048)
| * f42afd0 Force eos default creds to be string (sonic-net#18026)
| * be542b0 Restore config after vxlan_crm from vxlan_ecmp. (sonic-net#17767)
| * f0718b9 [Fix for Issue sonic-net#17413] Modified the Tx Rx port id list selection for all to all scenario (sonic-net#17919)
| * 3eb4ed4 [dualtor_io] Collect syslog to debug (sonic-net#17722)
| * d5bd995 Disable PFC-WD during PCBB and some wmk test improvements (sonic-net#17889)
| * 2f512aa Update outer UDP sport range to exclude port 53 (sonic-net#17570) (sonic-net#17798)
| * 980b373 skip test_bgp_slb advanced reboot for isolated topo (sonic-net#17470)
| * 408bf9e Default the inner dscp to outer dscp map to be 1-1. (sonic-net#17860)
| * 37495a1 Add dualtor fixtures to no_traffic test. (sonic-net#17916)
| * a13b599 Only print the matched syslog in loganalzyer teardown check, no traceback info printed (sonic-net#17926)
| * 6127f29 Revert "Skip test_vnet_decap on Cisco-8000 with 202411 (sonic-net#17776)" (sonic-net#17941) (sonic-net#17942)
| * 60274db Increase timeout to 5 in verify_packet_any_port for background traffic (sonic-net#17904)
```
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@echuawu
Update outer UDP sport range to exclude port 53 (sonic-net#17570)
f464249 
UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port

Change-Id: I7c16425c8cceebd3a5cd6d9a4b20c4d93277c037

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@echuawu @gshemesh2
Update outer UDP sport range to exclude port 53 (sonic-net#17570)
fe8f27b 
UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port

Change-Id: I7c16425c8cceebd3a5cd6d9a4b20c4d93277c037
Signed-off-by: Guy Shemesh <[email protected]>
congh-nvidia added a commit to congh-nvidia/sonic-mgmt that referenced this pull request Jan 5, 2026
@congh-nvidia
Fix the fib vxlan hash test
d1bd23a 
The fix in sonic-net#17570 was
overriden by another PR. Add it back.

Signed-off-by: Cong Hou <[email protected]>
@congh-nvidia congh-nvidia mentioned this pull request Jan 5, 2026
Merged
12 tasks
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@echuawu @gshemesh2
Update outer UDP sport range to exclude port 53 (sonic-net#17570)
a51667b 
UDP sport 53 is a special port to be used in DNS and there is a rule in test server ovs switch
It would forward packet with UDP sport 53 to VM instead of to PTF port

Change-Id: I7c16425c8cceebd3a5cd6d9a4b20c4d93277c037
Signed-off-by: Guy Shemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@nhe-NV nhe-NV nhe-NV approved these changes

Assignees

No one assigned

Labels

Approved for 202411 branch Included in 202411 branch Request for 202411 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@echuawu @mssonicbld @bingwang-ms @nhe-NV @r12f @kperumalbfn