Skip to content

[202405] Skip test_incremental_qos on Mellanox dualtor#17407

Merged
bingwang-ms merged 1 commit into202405from
skip_incremental_qos_dualtor_202405
Mar 7, 2025
Merged

[202405] Skip test_incremental_qos on Mellanox dualtor#17407
bingwang-ms merged 1 commit into202405from
skip_incremental_qos_dualtor_202405

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
This PR is to cherry-pick #17406 to 202405 branch.

This PR is to skip test_incremental_qos.py on Mellanox dualtor testbed.
It's not skipped now because there is a longer match in the condition list. Actually it's not needed as there is only 1 test case in test module test_incremental_qos.py.

generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates:
  skip:
    reason: "This test is not run on this hwsku/asic type or version or topology currently"
    conditions_logical_operator: "OR"
    conditions:
      - "not any(i in hwsku for i in ['2700', 'Arista-7170-64C', 'montara', 'newport']) and asic_type in ['broadcom', 'cisco-8000'] and release in ['202211']"
      - "'t2' in topo_name"

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

This PR is to skip test_incremental_qos.py on Mellanox dualtor testbed.

How did you do it?

Update tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

How did you verify/test it?

The change is verified on a Mellanox dualtor testbed.

collected 9 items                                                                                                                                                                                                             

generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[add-ingress_lossless_pool/xoff] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 11%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[add-ingress_lossless_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 22%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[add-egress_lossy_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 33%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[replace-ingress_lossless_pool/xoff] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 44%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[replace-ingress_lossless_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 55%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[replace-egress_lossy_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 66%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[remove-ingress_lossless_pool/xoff] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 77%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[remove-ingress_lossless_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [ 88%]
generic_config_updater/test_incremental_qos.py::test_incremental_qos_config_updates[remove-egress_lossy_pool/size] SKIPPED (Does not support dualtor right now, due to issue https://github.com/sonic-net/sonic-mgmt/issues/14865 / generic_config_updater is not a supported feature for T2) [100%]

Any platform specific information?

Mellanox dualtor.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@bingwang-ms bingwang-ms merged commit 59d32b9 into 202405 Mar 7, 2025
3 checks passed
@wangxin wangxin deleted the skip_incremental_qos_dualtor_202405 branch July 4, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants