Skip to content

Announce vips routes for bgp_multipath_relax testing #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 1 commit into from
May 21, 2020
Merged

Announce vips routes for bgp_multipath_relax testing #1692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 51 additions & 35 deletions tests/common/plugins/fib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,28 @@
import ipaddr as ipaddress
logger = logging.getLogger(__name__)

def announce_routes(ptfip, port, family, podset_number, tor_number, tor_subnet_number,

def announce_routes(ptfip, port, routes):
messages = []
for prefix, nexthop, aspath in routes:
if aspath:
messages.append("announce route {} next-hop {} as-path [ {} ]".format(prefix, nexthop, aspath))
else:
messages.append("announce route {} next-hop {}".format(prefix, nexthop))

url = "http://%s:%d" % (ptfip, port)
data = { "commands": ";".join(messages) }
r = requests.post(url, data=data)
print r
assert r.status_code == 200


def generate_routes(family, podset_number, tor_number, tor_subnet_number,
spine_asn, leaf_asn_start, tor_asn_start,
nexthop, nexthop_v6,
tor_subnet_size = 128, max_tor_subnet_number = 16,
router_type = "leaf"):
messages = []
routes = []

default_route_as_path = "6666 6667"

Expand All @@ -21,9 +37,9 @@ def announce_routes(ptfip, port, family, podset_number, tor_number, tor_subnet_n

if router_type != 'tor':
if family in ["v4", "both"]:
messages.append("announce route 0.0.0.0/0 next-hop {} as-path [ {} ]".format(nexthop, default_route_as_path))
routes.append(("0.0.0.0/0", nexthop, default_route_as_path))
if family in ["v6", "both"]:
messages.append("announce route ::/0 next-hop {} as-path [ {} ]".format(nexthop_v6, default_route_as_path))
routes.append(("::/0", nexthop_v6, default_route_as_path))

# NOTE: Using large enough values (e.g., podset_number = 200,
# us to overflow the 192.168.0.0/16 private address space here.
Expand Down Expand Up @@ -69,23 +85,13 @@ def announce_routes(ptfip, port, family, podset_number, tor_number, tor_subnet_n
else:
aspath = "{} {} {}".format(spine_asn, leaf_asn, tor_asn)

if aspath:
if family in ["v4", "both"]:
messages.append("announce route {} next-hop {} as-path [ {} ]".format(prefix, nexthop, aspath))
if family in ["v6", "both"]:
messages.append("announce route {} next-hop {} as-path [ {} ]".format(prefix_v6, nexthop_v6, aspath))
else:
if family in ["v4", "both"]:
messages.append("announce route {} next-hop {}".format(prefix, nexthop))
if family in ["v6", "both"]:
messages.append("announce route {} next-hop {}".format(prefix_v6, nexthop_v6))
if family in ["v4", "both"]:
routes.append((prefix, nexthop, aspath))
if family in ["v6", "both"]:
routes.append((prefix_v6, nexthop_v6, aspath))

return routes

url = "http://%s:%d" % (ptfip, port)
data = { "commands": ";".join(messages) }
r = requests.post(url, data=data)
print r
assert r.status_code == 200

def fib_t0(ptfhost, testbed):
logger.info("use fib_t0 to setup routes for topo {}".format(testbed['topo']['name']))
Expand Down Expand Up @@ -137,13 +143,15 @@ def fib_t0(ptfhost, testbed):
port = 5000 + vm_offset
port6 = 6000 + vm_offset

announce_routes(ptfip, port, "v4", podset_number, tor_number, tor_subnet_number,
spine_asn, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6)
routes_v4 = generate_routes("v4", podset_number, tor_number, tor_subnet_number,
spine_asn, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6)
routes_v6 = generate_routes("v6", podset_number, tor_number, tor_subnet_number,
spine_asn, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6)

announce_routes(ptfip, port, routes_v4 + routes_v6)

announce_routes(ptfip, port6, "v6", podset_number, tor_number, tor_subnet_number,
spine_asn, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6)

def fib_t1_lag(ptfhost, testbed):
logger.info("use fib_t1_lag to setup routes for topo {}".format(testbed['topo']['name']))
Expand Down Expand Up @@ -197,18 +205,26 @@ def fib_t1_lag(ptfhost, testbed):
port6 = 6000 + vm_offset

if 'spine' in v['properties']:
announce_routes(ptfip, port, "v4", podset_number, tor_number, tor_subnet_number,
None, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6, router_type="spine")

announce_routes(ptfip, port6, "v6", podset_number, tor_number, tor_subnet_number,
None, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6, router_type="spine")
routes_v4 = generate_routes("v4", podset_number, tor_number, tor_subnet_number,
None, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6, router_type="spine")
routes_v6 = generate_routes("v6", podset_number, tor_number, tor_subnet_number,
None, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6, router_type="spine")
announce_routes(ptfip, port, routes_v4 + routes_v6)

elif 'tor' in v['properties']:
announce_routes(ptfip, port, "v4", podset_number, tor_number, tor_subnet_number,
None, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6, router_type="tor")
routes_v4 = generate_routes("v4", podset_number, tor_number, tor_subnet_number,
None, leaf_asn_start, tor_asn_start,
local_ip, local_ipv6, router_type="tor")
announce_routes(ptfip, port, routes_v4)

if 'vips' in v:
routes_vips = []
for prefix in v["vips"]["ipv4"]["prefixes"]:
routes_vips.append((prefix, local_ip, v["vips"]["ipv4"]["asn"]))
announce_routes(ptfip, port, routes_vips)
Copy link
Copy Markdown
Contributor

@lguohan lguohan May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we want to advertise to every tor about the vip. I remember topology has information which tor needs to advertise the vip.

Copy link
Copy Markdown
Collaborator Author

@wangxin wangxin May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not advertise to every tor. It will only advertise to tor VMs that have configuration "vips" in topology definition file.

For example, in ansible/vars/topo_t1-lag.yml, only two VMs have the "vips" configuration: ARISTA01T0, ARISTA03T0.

  ARISTA01T0:
    properties:
    - common
    - tor
    tornum: 1
    bgp:
      asn: 64001
      peers:
        65100:
        - 10.0.0.32
        - FC00::41
    interfaces:
      Loopback0:
        ipv4: 100.1.0.17/32
        ipv6: 2064:100::11/128
      Ethernet1:
        ipv4: 10.0.0.33/31
        ipv6: fc00::42/126
    bp_interface:
      ipv4: 10.10.246.17/24
      ipv6: fc0a::22/64
    vips:
      ipv4:
        prefixes:
           - 200.0.1.0/26
        asn: 64700

  ARISTA03T0:
    properties:
    - common
    - tor
    tornum: 3
    bgp:
      asn: 64003
      peers:
        65100:
        - 10.0.0.36
        - FC00::49
    interfaces:
      Loopback0:
        ipv4: 100.1.0.19/32
        ipv6: 2064:100::13/128
      Ethernet1:
        ipv4: 10.0.0.37/31
        ipv6: fc00::4a/126
    bp_interface:
      ipv4: 10.10.246.19/24
      ipv6: fc0a::26/64
    vips:
      ipv4:
        prefixes:
          - 200.0.1.0/26
        asn: 64700

The vips routes will only be advertised to these two tor VMs.



@pytest.fixture(scope='module')
def fib(ptfhost, testbed):
Expand Down