[dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic by yaqiangz · Pull Request #16494 · sonic-net/sonic-mgmt

yaqiangz · 2025-01-13T09:47:19Z

Description of PR

Summary:
Fixes #16344

Type of change

Back port request

Approach

What is the motivation for this PR?

We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52
Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing

How did you do it?

Modify test_interface_binding:

Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established
Add LLA back
Verify whether sockets for LLA are established

How did you verify/test it?

Run test_dhcpv6_relay.py

collected 6 items                                                                                                                                                                                                                                                                  

dhcp_relay/test_dhcpv6_relay.py::test_interface_binding PASSED                                                                                                                                                                                                               [ 16%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcpv6_relay_counter PASSED                                                                                                                                                                                                            [ 33%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcp_relay_default PASSED                                                                                                                                                                                                              [ 50%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcp_relay_after_link_flap PASSED                                                                                                                                                                                                      [ 66%]
dhcp_relay/test_dhcpv6_relay.py::test_dhcp_relay_start_with_uplinks_down PASSED                                                                                                                                                                                              [ 83%]
dhcp_relay/test_dhcpv6_relay.py::TestDhcpv6RelayWithMultipleVlan::test_dhcp_relay_default[3] PASSED                                                                                                                                                                          [100%]

================================================================================================================================= warnings summary =================================================================================================================================
../../../../usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236
  /usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
    "class": algorithms.Blowfish,

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
--------------------------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt-int/tests/logs/dhcp_relay/test_dhcpv6_relay.xml ----------------------------------------------------------------------------------------------
===================================================================================================================== 6 passed, 1 warning in 967.94s (0:16:07) =====================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-01-13T09:47:23Z

/azp run

azure-pipelines · 2025-01-13T09:47:35Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-13T09:49:25Z

/azp run

azure-pipelines · 2025-01-13T09:49:38Z

Azure Pipelines successfully started running 1 pipeline(s).

yaqiangz · 2025-01-13T13:07:03Z

/azpw run Azure.sonic-mgmt

mssonicbld · 2025-01-13T13:07:05Z

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines · 2025-01-13T13:07:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-14T02:55:48Z

/azp run

azure-pipelines · 2025-01-14T02:56:00Z

Azure Pipelines successfully started running 1 pipeline(s).

yaqiangz · 2025-01-16T03:30:17Z

Hi @bingwang-ms could you please help to approve this backport request?

…nic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py

mssonicbld · 2025-01-16T16:49:56Z

Cherry-pick PR to 202405: #16554

…nic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py

mssonicbld · 2025-01-16T17:47:02Z

Cherry-pick PR to 202411: #16556

…nic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py

…ogic (sonic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py

…6494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py

…ogic (#16494) (#16567) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py

yaqiangz · 2025-01-21T01:39:41Z

Backport for 202405: #16567

Merge 202405 branch in as of 12:23pm 20/01/2025 AEST b118611 (HEAD -> merge/202405) Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348) 0e0e898 flap interface after sfp reset (sonic-net#16375) 41e2b2f Temporarily skip lpmode test for some transceivers with known issue (sonic-net#16547) de60273 [Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864) 7b357f5 [Snappi] New testcases for PFC-ECN. (sonic-net#13865) 3523a7f [Snappi]: PFC - Mixed Speed testcases (sonic-net#14122) 3754f2a sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708) 21f6526 [sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026) d8f23be Correcting client arguments to dynamically_compensate_leakout (sonic-net#16169) 3c47107 [sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357) 37352b8 Eliminate cross-feature dependency from macsec module (sonic-net#15617) 4f33b0d (pub_upstream/202405) [202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (sonic-net#16494) (sonic-net#16567)

…nic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py

[dhcp_relay] Add test case to verify dhcp6relay LLA

c2b5829

yaqiangz force-pushed the azure-master_dhcp6relay_lla branch from c435f64 to c2b5829 Compare January 13, 2025 09:49

Add restart dhcp_relay

27383b7

yaqiangz added Request for 202405 branch Request for 202411 branch and removed Request for 202405 branch Request for 202411 branch labels Jan 14, 2025

yxieca approved these changes Jan 14, 2025

View reviewed changes

yxieca merged commit 442e9c2 into sonic-net:master Jan 14, 2025

yaqiangz added the Request for 202405 branch label Jan 16, 2025

yaqiangz added the Request for 202411 branch label Jan 16, 2025

bingwang-ms added the Approved for 202405 branch label Jan 16, 2025

mssonicbld added the Created PR to 202405 branch label Jan 16, 2025

mssonicbld mentioned this pull request Jan 16, 2025

[action] [PR:16494] [dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic #16554

Closed

12 tasks

kperumalbfn added the Approved for 202411 branch label Jan 16, 2025

mssonicbld added the Created PR to 202411 branch label Jan 16, 2025

mssonicbld mentioned this pull request Jan 16, 2025

[action] [PR:16494] [dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic #16556

Merged

12 tasks

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Jan 17, 2025

yaqiangz added Included in 202405 branch and removed Created PR to 202405 branch labels Jan 21, 2025

Conversation

yaqiangz commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jan 13, 2025

Uh oh!

azure-pipelines bot commented Jan 13, 2025

Uh oh!

mssonicbld commented Jan 13, 2025

Uh oh!

azure-pipelines bot commented Jan 13, 2025

Uh oh!

yaqiangz commented Jan 13, 2025

Uh oh!

mssonicbld commented Jan 13, 2025

Uh oh!

azure-pipelines bot commented Jan 13, 2025

Uh oh!

mssonicbld commented Jan 14, 2025

Uh oh!

azure-pipelines bot commented Jan 14, 2025

Uh oh!

yaqiangz commented Jan 16, 2025

Uh oh!

mssonicbld commented Jan 16, 2025

Uh oh!

mssonicbld commented Jan 16, 2025

Uh oh!

yaqiangz commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yaqiangz commented Jan 13, 2025 •

edited

Loading