Eliminate cross-feature dependency from macsec module#15617
Merged
wangxin merged 3 commits intosonic-net:masterfrom Nov 20, 2024
Merged
Eliminate cross-feature dependency from macsec module#15617wangxin merged 3 commits intosonic-net:masterfrom
wangxin merged 3 commits intosonic-net:masterfrom
Conversation
Pterosaur
approved these changes
Nov 20, 2024
yutongzhang-microsoft
changed the title
wangxin
approved these changes
Nov 20, 2024
yutongzhang-microsoft
added a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
What is the motivation for this PR? Previously, the common script tests/conftest.py relied on importing a module from the feature-specific macsec folder, creating a cross-feature dependency. To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you do it? To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you verify/test it?
Collaborator
|
@yutongzhang-microsoft PR conflicts with 202405 branch |
augusdn
pushed a commit
to augusdn/sonic-mgmt
that referenced
this pull request
Jan 15, 2025
What is the motivation for this PR? Previously, the common script tests/conftest.py relied on importing a module from the feature-specific macsec folder, creating a cross-feature dependency. To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you do it? To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you verify/test it?
8 tasks
yejianquan
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jan 16, 2025
[manual] [PR:15617] Include macsec module change into 202405 branch What is the motivation for this PR? Original commit already merged into sonic-mgmt/master branch and also available in sonic-mgmt.msft/202412 branch as well. Merged PR available at sonic-net/sonic-mgmt#15617 Previously, the common script tests/conftest.py relied on importing a module from the feature-specific macsec folder, creating a cross-feature dependency. To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you do it? To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. co-authorized by: jianquanye@microsoft.com
yejianquan
pushed a commit
to yejianquan/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
What is the motivation for this PR? Previously, the common script tests/conftest.py relied on importing a module from the feature-specific macsec folder, creating a cross-feature dependency. To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you do it? To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you verify/test it?
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
What is the motivation for this PR? Previously, the common script tests/conftest.py relied on importing a module from the feature-specific macsec folder, creating a cross-feature dependency. To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you do it? To eliminate this dependency and improve code organization, we created a Python package named macsec under the common path tests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure. How did you verify/test it?
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
Merge 202405 branch in as of 12:23pm 20/01/2025 AEST b118611 (HEAD -> merge/202405) Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348) 0e0e898 flap interface after sfp reset (sonic-net#16375) 41e2b2f Temporarily skip lpmode test for some transceivers with known issue (sonic-net#16547) de60273 [Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864) 7b357f5 [Snappi] New testcases for PFC-ECN. (sonic-net#13865) 3523a7f [Snappi]: PFC - Mixed Speed testcases (sonic-net#14122) 3754f2a sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708) 21f6526 [sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026) d8f23be Correcting client arguments to dynamically_compensate_leakout (sonic-net#16169) 3c47107 [sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357) 37352b8 Eliminate cross-feature dependency from macsec module (sonic-net#15617) 4f33b0d (pub_upstream/202405) [202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (sonic-net#16494) (sonic-net#16567)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Previously, the common script
tests/conftest.pyrelied on importing a module from the feature-specificmacsecfolder, creating a cross-feature dependency. To eliminate this dependency and improve code organization, we created a Python package namedmacsecunder the common pathtests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Previously, the common script
tests/conftest.pyrelied on importing a module from the feature-specificmacsecfolder, creating a cross-feature dependency. To eliminate this dependency and improve code organization, we created a Python package namedmacsecunder the common pathtests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure.How did you do it?
To eliminate this dependency and improve code organization, we created a Python package named
macsecunder the common pathtests/common. The shared scripts were refactored and relocated into this new package, ensuring a cleaner and more modular structure.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation