[Snappi] Infra changes for new PFC-ECN testcases. by amitpawar12 · Pull Request #13864 · sonic-net/sonic-mgmt

amitpawar12 · 2024-07-29T14:14:42Z

Description of PR

67989d1312b1778681d6575b12b66aa42fdf05a7

Please review the commit-ID given above.

Original PR13655 was raised to add the new testcases. However, manage the changes efficiently, it was decided to split the original into three PRs for ease in review process.

This PR tracks are the infrastructure related changes required for the execution of the testcases.

Note - PR #13848 needs to be merged in first before this PR is merged.

Summary:
Fixes # (issue)
#13655
#13215

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

This PR tracks only the infrastructure related changes needed for addition of the new testcases.

How did you do it?

Important changes are listed below:

Change directory - tests/common/snappi_tests/

Additional member variable 'base_flow_config_list' is added as list to class 'SnappiTestParams' in snappi_test_params.py file to accommodate for multiple base-flow-configs.
Existing functions - generate_test_flows, generate_background_flows, generate_pause_flows are modified to check if the base_flow_config_list exists. If it does, then base_flow_config is assigned snappi_extra_params.base_flow_config_list[flow_index]. Else existing code is used.
Existing function - 'verify_egress_queue_frame_count' is modified to check if base_flow_config_list exists. If yes, base_flow_config_list[0] is assigned to dut_port_config, else existing code is used.
The testcases calls 'run_traffic_and_collect_stats' function in traffic_generation file to run and gather IXIA+DUT statistics. Statistics are summarized in test_stats dictionary in return.
A function has been created to access the IXIA rest_py framework. This will in turn can be used to integrate MACSEC related changes in future. Currently, rest_py is used to generate the imix custom profile if the flag is set in the test_def dictionary (defined and passed by the test).
Depending upon the test_duration and test_interval defined in test_def of the test, the test-case will be executed.
At every test_interval, the statistics from IXIA and DUT are pulled in form of dictionary, where date-timestamp is primary key.

Important parameters from IXIA like Tx and Rx throughput, number of packets, latency etc are captured with each interval.

From DUT side, the Rx and Tx packets, loss packets (combination of failures, drops and errors), PFC count, queue counts are captured. Additional functions like - get_pfc_count, get_ingerface_stats etc are defined in the common/snappi_test helper files to assist with the same. The support for the above is added as part of the different pull-request.

At the end of the test, a CSV is created as raw data for the test-case execution. Summary of the test-case is generated in form of text file with same name. The run_sys_test also returns a dictionary test_stats with all the important parameters to be used for the verification of the test.

How did you verify/test it?

Test was executed on the local clone.

Any platform specific information?

These testcases are specifically meant for Broadcom-DNX multi-ASIC based platforms.

Supported testbed topology if it's a new test case?

Documentation

sdszhang · 2024-08-16T01:25:17Z

@rraghav-cisco for review.

rraghav-cisco · 2024-09-12T04:42:46Z

@rraghav-cisco for review.

@sdszhang : Verified the diff works in my workspace. Approved.

sdszhang · 2024-10-09T11:17:09Z

tests/common/snappi_tests/traffic_generation.py

+        ixnetwork(obj): rest_py API object.
+    """
+
+    api = snappi.api(location="1.1.30.1", ext="ixnetwork")


Can we get IP and credential from existing infra code instead of hardcode?

Agreed. I think that can be part of a different PR to address this. IXIA IP-address and credentials, both need to be pulled from existing infra-code.

sdszhang · 2024-10-09T11:46:02Z

tests/common/snappi_tests/snappi_systest_params.py

+from tests.common.snappi_tests.multi_dut_params import MultiDUTParams
+
+
+class SnappiSysTestParams():


is this a duplication of SnappiTestParams? Can we reuse SnappiTestParams?
If this is needed, can we rename it for easier understanding. e.g.: SnappiTrafficGroupParams, SnappiFlowBuilderParams, or something similar?

sdszhang · 2024-10-09T12:00:41Z

tests/common/snappi_tests/snappi_fixtures.py

                        if port["peer_port"] in asic_port_map[asic] and hostname in port['peer_device']:
                            port['asic_value'] = asic
                            port['asic_type'] = host.facts["asic_type"]
-                            port['duthost'] = host


is this change needed?

@sdszhang - I thought this change came from @selldinesh and is not my change. We can discuss this and check if this is required or not.

I believe this change is not required. We will need another PR to cleanup unused functions.

@amitpawar12 can you remove this change from this PR?

Hi @sdszhang, This code is still part of the code and I am not sure why it was added in first place. I would recommend that we raise a different PR to remove this line of the code. I am not sure why it was added, and impact in case we removed it.

Thanks,

sdszhang · 2024-10-09T12:18:13Z

tests/common/snappi_tests/traffic_generation.py

+                    avg_latency = round(df_t[item].mean(), 2)
+                if (flow in item and item.split(flow)[1] == '_rx_pkts'):
+                    rx_pkts = df_t[item].max()
+                if (flow in item and item.split(flow)[1] == '_rx_pkts' and ('prio_3' in flow or 'prio_4' in flow)):


we can use the lossless priority list and lossy priority list instead of hard code prio_3/prio_4.

@amitpawar12 what's the plan to resolve this?

@sdszhang - This is fixed now.

amitpawar12 · 2024-10-10T20:12:48Z

@sdszhang , @developfast

For the port_map, this is going to be the format, that will be used to parameterize:
port_map = [{'egress_speed': 400, 'egress_num_link': 1, 'ingress_speed': 400, 'ingress_num_link': 1},
{'egress_speed': 100, 'egress_num_link': 1, 'ingress_speed': 100, 'ingress_num_link': 1}]

Internal test will see it as dictionary. Please let me know so that I can start working on it.

developfast · 2024-10-10T20:16:22Z

Can we set it up as a dataclass @amitpawar12 for example,

from dataclasses import dataclass
from typing import List

@dataclass
class PortConfig:
    egress_speed: int
    egress_num_link: int
    ingress_speed: int
    ingress_num_link: int
   .....(add more attributes as necessary)

# Define the port map as a list of PortConfig objects
port_map: List[PortConfig] = [
    PortConfig(egress_speed=400, egress_num_link=1, ingress_speed=400, ingress_num_link=1),
    PortConfig(egress_speed=100, egress_num_link=1, ingress_speed=100, ingress_num_link=1)
]

# Now you can access the port_map elements as objects
print(port_map)

This is cleaner and we can keep track of keys and their types. It also ensures we don't "accidentally" add new keys without first adding it to the dataclass

amitpawar12 · 2024-10-22T17:28:18Z

Thanks for the comments @developfast.

The port_map was an interim solution to ensure that we can run tests on both 100 and 400Gbps line-cards together. However, ideal scenario would be get rid of variables.py and pick up the ports (both 100 and 400Gbps, and of any other speeds) and make it available for the test.

I have PR for the same:
#15069

Thanks,
-A

sdszhang · 2024-12-11T23:07:57Z

@amitpawar12 can you update the test results.

amitpawar12 · 2025-01-06T20:54:03Z

@amitpawar12 can you update the test results.

Logs are kept at following link:
#13865 (comment)

Thanks,
-A

mssonicbld · 2025-01-09T20:16:53Z

/azp run

azure-pipelines · 2025-01-09T20:17:07Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-01-10T05:40:54Z

@selldinesh can you help to upload the T0/T1 test result?

@developfast for viz.

…ats function

…lect_stats function

… setup

mssonicbld · 2025-01-10T21:54:43Z

/azp run

azure-pipelines · 2025-01-10T21:54:55Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-01-14T03:10:43Z

Good to merge to master and msft.202405. No need for 202405.

Description of PR 67989d1312b1778681d6575b12b66aa42fdf05a7 Please review the commit-ID given above. Original PR13655 was raised to add the new testcases. However, manage the changes efficiently, it was decided to split the original into three PRs for ease in review process. This PR tracks are the infrastructure related changes required for the execution of the testcases. Note - PR sonic-net#13848 needs to be merged in first before this PR is merged. Summary: Fixes # (issue) sonic-net#13655 sonic-net#13215 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? This PR tracks only the infrastructure related changes needed for addition of the new testcases. How did you do it? Important changes are listed below: Change directory - tests/common/snappi_tests/ Additional member variable 'base_flow_config_list' is added as list to class 'SnappiTestParams' in snappi_test_params.py file to accommodate for multiple base-flow-configs. Existing functions - generate_test_flows, generate_background_flows, generate_pause_flows are modified to check if the base_flow_config_list exists. If it does, then base_flow_config is assigned snappi_extra_params.base_flow_config_list[flow_index]. Else existing code is used. Existing function - 'verify_egress_queue_frame_count' is modified to check if base_flow_config_list exists. If yes, base_flow_config_list[0] is assigned to dut_port_config, else existing code is used. The testcases calls 'run_traffic_and_collect_stats' function in traffic_generation file to run and gather IXIA+DUT statistics. Statistics are summarized in test_stats dictionary in return. A function has been created to access the IXIA rest_py framework. This will in turn can be used to integrate MACSEC related changes in future. Currently, rest_py is used to generate the imix custom profile if the flag is set in the test_def dictionary (defined and passed by the test). Depending upon the test_duration and test_interval defined in test_def of the test, the test-case will be executed. At every test_interval, the statistics from IXIA and DUT are pulled in form of dictionary, where date-timestamp is primary key. Important parameters from IXIA like Tx and Rx throughput, number of packets, latency etc are captured with each interval. From DUT side, the Rx and Tx packets, loss packets (combination of failures, drops and errors), PFC count, queue counts are captured. Additional functions like - get_pfc_count, get_ingerface_stats etc are defined in the common/snappi_test helper files to assist with the same. The support for the above is added as part of the different pull-request. At the end of the test, a CSV is created as raw data for the test-case execution. Summary of the test-case is generated in form of text file with same name. The run_sys_test also returns a dictionary test_stats with all the important parameters to be used for the verification of the test. How did you verify/test it? Test was executed on the local clone. Any platform specific information? These testcases are specifically meant for Broadcom-DNX multi-ASIC based platforms. co-authorized by: [email protected]

mssonicbld · 2025-01-14T03:38:44Z

Cherry-pick PR to 202411: #16505

Description of PR 67989d1312b1778681d6575b12b66aa42fdf05a7 Please review the commit-ID given above. Original PR13655 was raised to add the new testcases. However, manage the changes efficiently, it was decided to split the original into three PRs for ease in review process. This PR tracks are the infrastructure related changes required for the execution of the testcases. Note - PR #13848 needs to be merged in first before this PR is merged. Summary: Fixes # (issue) #13655 #13215 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? This PR tracks only the infrastructure related changes needed for addition of the new testcases. How did you do it? Important changes are listed below: Change directory - tests/common/snappi_tests/ Additional member variable 'base_flow_config_list' is added as list to class 'SnappiTestParams' in snappi_test_params.py file to accommodate for multiple base-flow-configs. Existing functions - generate_test_flows, generate_background_flows, generate_pause_flows are modified to check if the base_flow_config_list exists. If it does, then base_flow_config is assigned snappi_extra_params.base_flow_config_list[flow_index]. Else existing code is used. Existing function - 'verify_egress_queue_frame_count' is modified to check if base_flow_config_list exists. If yes, base_flow_config_list[0] is assigned to dut_port_config, else existing code is used. The testcases calls 'run_traffic_and_collect_stats' function in traffic_generation file to run and gather IXIA+DUT statistics. Statistics are summarized in test_stats dictionary in return. A function has been created to access the IXIA rest_py framework. This will in turn can be used to integrate MACSEC related changes in future. Currently, rest_py is used to generate the imix custom profile if the flag is set in the test_def dictionary (defined and passed by the test). Depending upon the test_duration and test_interval defined in test_def of the test, the test-case will be executed. At every test_interval, the statistics from IXIA and DUT are pulled in form of dictionary, where date-timestamp is primary key. Important parameters from IXIA like Tx and Rx throughput, number of packets, latency etc are captured with each interval. From DUT side, the Rx and Tx packets, loss packets (combination of failures, drops and errors), PFC count, queue counts are captured. Additional functions like - get_pfc_count, get_ingerface_stats etc are defined in the common/snappi_test helper files to assist with the same. The support for the above is added as part of the different pull-request. At the end of the test, a CSV is created as raw data for the test-case execution. Summary of the test-case is generated in form of text file with same name. The run_sys_test also returns a dictionary test_stats with all the important parameters to be used for the verification of the test. How did you verify/test it? Test was executed on the local clone. Any platform specific information? These testcases are specifically meant for Broadcom-DNX multi-ASIC based platforms. co-authorized by: [email protected]

Description of PR 67989d1312b1778681d6575b12b66aa42fdf05a7 Please review the commit-ID given above. Original PR13655 was raised to add the new testcases. However, manage the changes efficiently, it was decided to split the original into three PRs for ease in review process. This PR tracks are the infrastructure related changes required for the execution of the testcases. Note - PR sonic-net#13848 needs to be merged in first before this PR is merged. Summary: Fixes # (issue) sonic-net#13655 sonic-net#13215 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? This PR tracks only the infrastructure related changes needed for addition of the new testcases. How did you do it? Important changes are listed below: Change directory - tests/common/snappi_tests/ Additional member variable 'base_flow_config_list' is added as list to class 'SnappiTestParams' in snappi_test_params.py file to accommodate for multiple base-flow-configs. Existing functions - generate_test_flows, generate_background_flows, generate_pause_flows are modified to check if the base_flow_config_list exists. If it does, then base_flow_config is assigned snappi_extra_params.base_flow_config_list[flow_index]. Else existing code is used. Existing function - 'verify_egress_queue_frame_count' is modified to check if base_flow_config_list exists. If yes, base_flow_config_list[0] is assigned to dut_port_config, else existing code is used. The testcases calls 'run_traffic_and_collect_stats' function in traffic_generation file to run and gather IXIA+DUT statistics. Statistics are summarized in test_stats dictionary in return. A function has been created to access the IXIA rest_py framework. This will in turn can be used to integrate MACSEC related changes in future. Currently, rest_py is used to generate the imix custom profile if the flag is set in the test_def dictionary (defined and passed by the test). Depending upon the test_duration and test_interval defined in test_def of the test, the test-case will be executed. At every test_interval, the statistics from IXIA and DUT are pulled in form of dictionary, where date-timestamp is primary key. Important parameters from IXIA like Tx and Rx throughput, number of packets, latency etc are captured with each interval. From DUT side, the Rx and Tx packets, loss packets (combination of failures, drops and errors), PFC count, queue counts are captured. Additional functions like - get_pfc_count, get_ingerface_stats etc are defined in the common/snappi_test helper files to assist with the same. The support for the above is added as part of the different pull-request. At the end of the test, a CSV is created as raw data for the test-case execution. Summary of the test-case is generated in form of text file with same name. The run_sys_test also returns a dictionary test_stats with all the important parameters to be used for the verification of the test. How did you verify/test it? Test was executed on the local clone. Any platform specific information? These testcases are specifically meant for Broadcom-DNX multi-ASIC based platforms. co-authorized by: [email protected]

[Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864) Description of PR 67989d1312b1778681d6575b12b66aa42fdf05a7 Please review the commit-ID given above. Original PR13655 was raised to add the new testcases. However, manage the changes efficiently, it was decided to split the original into three PRs for ease in review process. This PR tracks are the infrastructure related changes required for the execution of the testcases. Note - PR sonic-net#13848 needs to be merged in first before this PR is merged. Summary: Fixes # (issue) sonic-net#13655 sonic-net#13215 Approach What is the motivation for this PR? This PR tracks only the infrastructure related changes needed for addition of the new testcases. How did you do it? Important changes are listed below: Change directory - tests/common/snappi_tests/ Additional member variable 'base_flow_config_list' is added as list to class 'SnappiTestParams' in snappi_test_params.py file to accommodate for multiple base-flow-configs. Existing functions - generate_test_flows, generate_background_flows, generate_pause_flows are modified to check if the base_flow_config_list exists. If it does, then base_flow_config is assigned snappi_extra_params.base_flow_config_list[flow_index]. Else existing code is used. Existing function - 'verify_egress_queue_frame_count' is modified to check if base_flow_config_list exists. If yes, base_flow_config_list[0] is assigned to dut_port_config, else existing code is used. The testcases calls 'run_traffic_and_collect_stats' function in traffic_generation file to run and gather IXIA+DUT statistics. Statistics are summarized in test_stats dictionary in return. A function has been created to access the IXIA rest_py framework. This will in turn can be used to integrate MACSEC related changes in future. Currently, rest_py is used to generate the imix custom profile if the flag is set in the test_def dictionary (defined and passed by the test). Depending upon the test_duration and test_interval defined in test_def of the test, the test-case will be executed. At every test_interval, the statistics from IXIA and DUT are pulled in form of dictionary, where date-timestamp is primary key. Important parameters from IXIA like Tx and Rx throughput, number of packets, latency etc are captured with each interval. From DUT side, the Rx and Tx packets, loss packets (combination of failures, drops and errors), PFC count, queue counts are captured. Additional functions like - get_pfc_count, get_ingerface_stats etc are defined in the common/snappi_test helper files to assist with the same. The support for the above is added as part of the different pull-request. At the end of the test, a CSV is created as raw data for the test-case execution. Summary of the test-case is generated in form of text file with same name. The run_sys_test also returns a dictionary test_stats with all the important parameters to be used for the verification of the test. How did you verify/test it? Test was executed on the local clone. Any platform specific information? These testcases are specifically meant for Broadcom-DNX multi-ASIC based platforms. co-authorized by: [email protected]

Description of PR 67989d1312b1778681d6575b12b66aa42fdf05a7 Please review the commit-ID given above. Original PR13655 was raised to add the new testcases. However, manage the changes efficiently, it was decided to split the original into three PRs for ease in review process. This PR tracks are the infrastructure related changes required for the execution of the testcases. Note - PR sonic-net#13848 needs to be merged in first before this PR is merged. Summary: Fixes # (issue) sonic-net#13655 sonic-net#13215 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? This PR tracks only the infrastructure related changes needed for addition of the new testcases. How did you do it? Important changes are listed below: Change directory - tests/common/snappi_tests/ Additional member variable 'base_flow_config_list' is added as list to class 'SnappiTestParams' in snappi_test_params.py file to accommodate for multiple base-flow-configs. Existing functions - generate_test_flows, generate_background_flows, generate_pause_flows are modified to check if the base_flow_config_list exists. If it does, then base_flow_config is assigned snappi_extra_params.base_flow_config_list[flow_index]. Else existing code is used. Existing function - 'verify_egress_queue_frame_count' is modified to check if base_flow_config_list exists. If yes, base_flow_config_list[0] is assigned to dut_port_config, else existing code is used. The testcases calls 'run_traffic_and_collect_stats' function in traffic_generation file to run and gather IXIA+DUT statistics. Statistics are summarized in test_stats dictionary in return. A function has been created to access the IXIA rest_py framework. This will in turn can be used to integrate MACSEC related changes in future. Currently, rest_py is used to generate the imix custom profile if the flag is set in the test_def dictionary (defined and passed by the test). Depending upon the test_duration and test_interval defined in test_def of the test, the test-case will be executed. At every test_interval, the statistics from IXIA and DUT are pulled in form of dictionary, where date-timestamp is primary key. Important parameters from IXIA like Tx and Rx throughput, number of packets, latency etc are captured with each interval. From DUT side, the Rx and Tx packets, loss packets (combination of failures, drops and errors), PFC count, queue counts are captured. Additional functions like - get_pfc_count, get_ingerface_stats etc are defined in the common/snappi_test helper files to assist with the same. The support for the above is added as part of the different pull-request. At the end of the test, a CSV is created as raw data for the test-case execution. Summary of the test-case is generated in form of text file with same name. The run_sys_test also returns a dictionary test_stats with all the important parameters to be used for the verification of the test. How did you verify/test it? Test was executed on the local clone. Any platform specific information? These testcases are specifically meant for Broadcom-DNX multi-ASIC based platforms. co-authorized by: [email protected]

Merge 202405 branch in as of 12:23pm 20/01/2025 AEST b118611 (HEAD -> merge/202405) Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348) 0e0e898 flap interface after sfp reset (sonic-net#16375) 41e2b2f Temporarily skip lpmode test for some transceivers with known issue (sonic-net#16547) de60273 [Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864) 7b357f5 [Snappi] New testcases for PFC-ECN. (sonic-net#13865) 3523a7f [Snappi]: PFC - Mixed Speed testcases (sonic-net#14122) 3754f2a sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708) 21f6526 [sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026) d8f23be Correcting client arguments to dynamically_compensate_leakout (sonic-net#16169) 3c47107 [sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357) 37352b8 Eliminate cross-feature dependency from macsec module (sonic-net#15617) 4f33b0d (pub_upstream/202405) [202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (sonic-net#16494) (sonic-net#16567)

Description of PR 67989d1312b1778681d6575b12b66aa42fdf05a7 Please review the commit-ID given above. Original PR13655 was raised to add the new testcases. However, manage the changes efficiently, it was decided to split the original into three PRs for ease in review process. This PR tracks are the infrastructure related changes required for the execution of the testcases. Note - PR sonic-net#13848 needs to be merged in first before this PR is merged. Summary: Fixes # (issue) sonic-net#13655 sonic-net#13215 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? This PR tracks only the infrastructure related changes needed for addition of the new testcases. How did you do it? Important changes are listed below: Change directory - tests/common/snappi_tests/ Additional member variable 'base_flow_config_list' is added as list to class 'SnappiTestParams' in snappi_test_params.py file to accommodate for multiple base-flow-configs. Existing functions - generate_test_flows, generate_background_flows, generate_pause_flows are modified to check if the base_flow_config_list exists. If it does, then base_flow_config is assigned snappi_extra_params.base_flow_config_list[flow_index]. Else existing code is used. Existing function - 'verify_egress_queue_frame_count' is modified to check if base_flow_config_list exists. If yes, base_flow_config_list[0] is assigned to dut_port_config, else existing code is used. The testcases calls 'run_traffic_and_collect_stats' function in traffic_generation file to run and gather IXIA+DUT statistics. Statistics are summarized in test_stats dictionary in return. A function has been created to access the IXIA rest_py framework. This will in turn can be used to integrate MACSEC related changes in future. Currently, rest_py is used to generate the imix custom profile if the flag is set in the test_def dictionary (defined and passed by the test). Depending upon the test_duration and test_interval defined in test_def of the test, the test-case will be executed. At every test_interval, the statistics from IXIA and DUT are pulled in form of dictionary, where date-timestamp is primary key. Important parameters from IXIA like Tx and Rx throughput, number of packets, latency etc are captured with each interval. From DUT side, the Rx and Tx packets, loss packets (combination of failures, drops and errors), PFC count, queue counts are captured. Additional functions like - get_pfc_count, get_ingerface_stats etc are defined in the common/snappi_test helper files to assist with the same. The support for the above is added as part of the different pull-request. At the end of the test, a CSV is created as raw data for the test-case execution. Summary of the test-case is generated in form of text file with same name. The run_sys_test also returns a dictionary test_stats with all the important parameters to be used for the verification of the test. How did you verify/test it? Test was executed on the local clone. Any platform specific information? These testcases are specifically meant for Broadcom-DNX multi-ASIC based platforms. co-authorized by: [email protected]

amitpawar12 mentioned this pull request Jul 29, 2024

[Snappi] - Infra changes related to new testcases added for PFC, ECN. #13655

Closed

8 tasks

vmittal-msft requested review from developfast and vmittal-msft August 2, 2024 00:14

vmittal-msft self-assigned this Aug 2, 2024

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from 67989d1 to d377281 Compare August 7, 2024 19:23

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from 78c1829 to abbb216 Compare August 28, 2024 21:21

rlhui assigned amitpawar12 and unassigned vmittal-msft Sep 1, 2024

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from abbb216 to 2d5673e Compare October 7, 2024 18:48

sdszhang reviewed Oct 9, 2024

View reviewed changes

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from 2d5673e to a031921 Compare October 30, 2024 15:54

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from a031921 to 6a99744 Compare December 2, 2024 17:40

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from ba465d8 to 4f8480b Compare December 10, 2024 20:52

sdszhang approved these changes Dec 11, 2024

View reviewed changes

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from 4f8480b to 29c5e36 Compare December 11, 2024 17:08

sdszhang added the IXIA_CHASSIS label Dec 18, 2024

sdszhang added Request for 202411 branch Request for 202405 branch labels Jan 8, 2025

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from 29c5e36 to 0d67ff5 Compare January 9, 2025 20:16

Snappi-PR-13655 New Testcases Infra

59c283e

amitpawar12 added 4 commits January 10, 2025 15:47

re-added port['duthost'] back to the code for future cleanup

9a14709

fixed issue in switch_tx_lossless_prios in run_traffic_and_collect_St…

0fdf0f6

…ats function

Added hardcoded checks for lossless priorities in run_traffic_and_col…

626fb5e

…lect_stats function

snappi:removed get_ixnetwork function and hardcoded reference to IXIA…

f64b85c

… setup

amitpawar12 force-pushed the Snappi-Base-PR-13655-Infra branch from 0d67ff5 to f64b85c Compare January 10, 2025 21:54

sdszhang added Request for msft-202405 Branch and removed Request for 202405 branch labels Jan 14, 2025

yejianquan merged commit 4f28bfe into sonic-net:master Jan 14, 2025

yejianquan added Approved for 202411 branch Approved for msft-202405 Branch labels Jan 14, 2025

mssonicbld added the Created PR to 202411 branch label Jan 14, 2025

mssonicbld mentioned this pull request Jan 14, 2025

[action] [PR:13864] [Snappi] Infra changes for new PFC-ECN testcases. #16505

Merged

8 tasks

sdszhang mentioned this pull request Jan 14, 2025

[Snappi] New testcases for PFC-ECN. #13865

Merged

8 tasks

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Jan 15, 2025

Javier-Tan added Included in msft-202405 Branch Request for msft-202405 Branch and removed Request for msft-202405 Branch labels Jan 16, 2025

amitpawar12 mentioned this pull request Mar 7, 2025

[Snappi]- Support of IMIX profile on MACSEC enabled ingress and egress. #13403

Closed

		from tests.common.snappi_tests.multi_dut_params import MultiDUTParams


		class SnappiSysTestParams():

Conversation

amitpawar12 commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

sdszhang commented Aug 16, 2024

Uh oh!

rraghav-cisco commented Sep 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdszhang Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdszhang Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amitpawar12 commented Oct 10, 2024

Uh oh!

developfast commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amitpawar12 commented Oct 22, 2024

Uh oh!

sdszhang commented Dec 11, 2024

Uh oh!

amitpawar12 commented Jan 6, 2025

Uh oh!

mssonicbld commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

sdszhang commented Jan 10, 2025

Uh oh!

mssonicbld commented Jan 10, 2025

Uh oh!

azure-pipelines bot commented Jan 10, 2025

Uh oh!

sdszhang commented Jan 14, 2025

Uh oh!

mssonicbld commented Jan 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

amitpawar12 commented Jul 29, 2024 •

edited

Loading

sdszhang Oct 9, 2024 •

edited

Loading

sdszhang Oct 10, 2024 •

edited

Loading

developfast commented Oct 10, 2024 •

edited

Loading